)]}'
{"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"f3b65c17d307615d51c3ccb46bb3b2a851f91199","unresolved":false,"context_lines":[{"line_number":5286,"context_line":"        secret \u003d creds[-1][\u0027blob\u0027]"},{"line_number":5287,"context_line":""},{"line_number":5288,"context_line":"        past \u003d datetime.datetime.utcnow() - datetime.timedelta(seconds\u003d30)"},{"line_number":5289,"context_line":"        with freezegun.freeze_time(past):"},{"line_number":5290,"context_line":"            auth_data \u003d self._make_auth_data_by_id("},{"line_number":5291,"context_line":"                totp._generate_totp_passcodes(secret)[0])"},{"line_number":5292,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_25dd0a70","side":"PARENT","line":5289,"updated":"2020-02-27 09:36:36.000000000","message":"shouldn\u0027t we change this freezegun library from everywhere in such case?","commit_id":"b3cbf60c3c764bd9e0cf6168156e5de71c081449"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d8317484731bb182872fc68818b46816867f36fa","unresolved":false,"context_lines":[{"line_number":5286,"context_line":"        secret \u003d creds[-1][\u0027blob\u0027]"},{"line_number":5287,"context_line":""},{"line_number":5288,"context_line":"        past \u003d datetime.datetime.utcnow() - datetime.timedelta(seconds\u003d30)"},{"line_number":5289,"context_line":"        with freezegun.freeze_time(past):"},{"line_number":5290,"context_line":"            auth_data \u003d self._make_auth_data_by_id("},{"line_number":5291,"context_line":"                totp._generate_totp_passcodes(secret)[0])"},{"line_number":5292,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_4dc70847","side":"PARENT","line":5289,"in_reply_to":"1fa4df85_25dd0a70","updated":"2020-02-27 15:56:17.000000000","message":"We\u0027re using freezegun in these tests in the same way that the oslo TimeFixture works, freezegun is more flexible for other situations as well. However there is something odd going on with the time setting with freezegun and the TOTP windows \u003e 1.\n\nI haven\u0027t seen the random test failure once switching to TimeFixture in the py36 test (specifically py36 for some reason), hence this change. I don\u0027t see a reason to modify the other tests since they haven\u0027t had any issues.","commit_id":"b3cbf60c3c764bd9e0cf6168156e5de71c081449"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"6b4b9c87d128a3d9f822d60a509025df8f8f97ea","unresolved":false,"context_lines":[{"line_number":5286,"context_line":"        secret \u003d creds[-1][\u0027blob\u0027]"},{"line_number":5287,"context_line":""},{"line_number":5288,"context_line":"        past \u003d datetime.datetime.utcnow() - datetime.timedelta(seconds\u003d30)"},{"line_number":5289,"context_line":"        with freezegun.freeze_time(past):"},{"line_number":5290,"context_line":"            auth_data \u003d self._make_auth_data_by_id("},{"line_number":5291,"context_line":"                totp._generate_totp_passcodes(secret)[0])"},{"line_number":5292,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_322bfc30","side":"PARENT","line":5289,"in_reply_to":"1fa4df85_4dc70847","updated":"2020-02-28 09:59:56.000000000","message":"I can see the gate passing everytime after this change.","commit_id":"b3cbf60c3c764bd9e0cf6168156e5de71c081449"}]}