)]}'
{"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5dcdedfac64d7d39fbf0ed89f4755a26ba32b2ad","unresolved":false,"context_lines":[{"line_number":2879,"context_line":"        )"},{"line_number":2880,"context_line":""},{"line_number":2881,"context_line":""},{"line_number":2882,"context_line":"class TestTokenRevokeSelfAndAdmin(test_v3.RestfulTestCase):"},{"line_number":2883,"context_line":"    \"\"\"Test token revoke using v3 Identity API by token owner and admin.\"\"\""},{"line_number":2884,"context_line":""},{"line_number":2885,"context_line":"    def load_sample_data(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_928e8425","side":"PARENT","line":2882,"updated":"2019-10-04 17:17:52.000000000","message":"I\u0027m not seeing how this is specific to policy.v3cloudsample.json ? Or can you say in the commit message which protection tests make this redundant?","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f5adc189b2de8dfe106231bc0e2115ff0de8ab9f","unresolved":false,"context_lines":[{"line_number":2879,"context_line":"        )"},{"line_number":2880,"context_line":""},{"line_number":2881,"context_line":""},{"line_number":2882,"context_line":"class TestTokenRevokeSelfAndAdmin(test_v3.RestfulTestCase):"},{"line_number":2883,"context_line":"    \"\"\"Test token revoke using v3 Identity API by token owner and admin.\"\"\""},{"line_number":2884,"context_line":""},{"line_number":2885,"context_line":"    def load_sample_data(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e61b7a70","side":"PARENT","line":2882,"in_reply_to":"3fa7e38b_928e8425","updated":"2019-10-04 19:59:27.000000000","message":"Looks like we have a couple of gaps. Porting the missing tests over to keystone.tests.protection.v3.test_tokens","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"a583751341f9751d09b6aa67366f0d846e207283","unresolved":false,"context_lines":[{"line_number":2946,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND,"},{"line_number":2947,"context_line":"                  token\u003dadminA_token)"},{"line_number":2948,"context_line":""},{"line_number":2949,"context_line":"    def test_adminA_revokes_userA_token(self):"},{"line_number":2950,"context_line":"        user_token \u003d self.get_requested_token("},{"line_number":2951,"context_line":"            self.build_authentication_request("},{"line_number":2952,"context_line":"                user_id\u003dself.userNormalA[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a9af4be1","side":"PARENT","line":2949,"range":{"start_line":2949,"start_character":8,"end_line":2949,"end_character":39},"updated":"2019-10-10 06:12:43.000000000","message":"AFAIK a system admin can revoke project scoped and domain scoped token. For this case we Can add a test case later?","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"805f3df5a6fd4f5609596cd171a92fc155b76f83","unresolved":false,"context_lines":[{"line_number":2946,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND,"},{"line_number":2947,"context_line":"                  token\u003dadminA_token)"},{"line_number":2948,"context_line":""},{"line_number":2949,"context_line":"    def test_adminA_revokes_userA_token(self):"},{"line_number":2950,"context_line":"        user_token \u003d self.get_requested_token("},{"line_number":2951,"context_line":"            self.build_authentication_request("},{"line_number":2952,"context_line":"                user_id\u003dself.userNormalA[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_dc0b357a","side":"PARENT","line":2949,"range":{"start_line":2949,"start_character":8,"end_line":2949,"end_character":39},"in_reply_to":"3fa7e38b_9bd08d21","updated":"2019-10-14 07:20:42.000000000","message":"++","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e4ccaf8cf18c26c345628f940f747a3065530f3b","unresolved":false,"context_lines":[{"line_number":2946,"context_line":"                  expected_status\u003dhttp_client.NOT_FOUND,"},{"line_number":2947,"context_line":"                  token\u003dadminA_token)"},{"line_number":2948,"context_line":""},{"line_number":2949,"context_line":"    def test_adminA_revokes_userA_token(self):"},{"line_number":2950,"context_line":"        user_token \u003d self.get_requested_token("},{"line_number":2951,"context_line":"            self.build_authentication_request("},{"line_number":2952,"context_line":"                user_id\u003dself.userNormalA[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_9bd08d21","side":"PARENT","line":2949,"range":{"start_line":2949,"start_character":8,"end_line":2949,"end_character":39},"in_reply_to":"3fa7e38b_a9af4be1","updated":"2019-10-10 13:15:26.000000000","message":"We already have those cases covered:\n\nhttps://opendev.org/openstack/keystone/src/branch/master/keystone/tests/protection/v3/test_tokens.py#L283-L355","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"}],"keystone/tests/unit/test_v3_protection.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5dcdedfac64d7d39fbf0ed89f4755a26ba32b2ad","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _policy_fixture(self):"},{"line_number":39,"context_line":"        return ksfixtures.Policy("},{"line_number":40,"context_line":"            self.config_fixture, policy_file\u003dself.tmpfilename"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_92b764d9","side":"PARENT","line":40,"updated":"2019-10-04 17:17:52.000000000","message":"This isn\u0027t specific to policy.v3cloudsample.json. Are all of these tests redundant with the new protection tests?","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f5adc189b2de8dfe106231bc0e2115ff0de8ab9f","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def _policy_fixture(self):"},{"line_number":39,"context_line":"        return ksfixtures.Policy("},{"line_number":40,"context_line":"            self.config_fixture, policy_file\u003dself.tmpfilename"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3bac4b34","side":"PARENT","line":40,"in_reply_to":"3fa7e38b_92b764d9","updated":"2019-10-04 19:59:27.000000000","message":"Yes - at least as far as I can tell. I\u0027ll add a note to the commit message.","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"38d195dcf023507d81791043f11ac6279a25284e","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        Test Plan:"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        - Update policy so api is unprotected"},{"line_number":148,"context_line":"        - Use an un-scoped token to make sure we can get back all"},{"line_number":149,"context_line":"          the users independent of domain"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_fbd3d036","side":"PARENT","line":147,"updated":"2019-10-09 17:29:07.000000000","message":"What a weird thing to test","commit_id":"d4a6023de5bdfe5a6e9214579a35e083a45c1151"}]}