)]}'
{"id":"openstack%2Fkeystone~687770","triplet_id":"openstack%2Fkeystone~master~I636f420e8a0c274131281af1d5aae931c164d91d","project":"openstack/keystone","branch":"master","topic":"fix-repo-prefix-check","hashtags":[],"change_id":"I636f420e8a0c274131281af1d5aae931c164d91d","subject":"Fix sql migrate repo prefix check","status":"MERGED","created":"2019-10-10 03:35:47.000000000","updated":"2019-10-14 21:06:36.000000000","submitted":"2019-10-14 20:56:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"687770-1571086584880-d25b5e01","meta_rev_id":"f6113197755861d0b53937b6f97a4447c345b4e9","_number":687770,"virtual_id_number":687770,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-10-11 16:51:42.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-14 20:56:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"recommended":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":1,"date":"2019-10-11 04:41:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":1,"date":"2019-10-13 15:27:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"value":1,"date":"2019-10-11 08:16:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":1,"date":"2019-10-14 09:26:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-14 15:08:21.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":2,"date":"2019-10-11 08:05:06.000000000","_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":1,"date":"2019-10-14 03:17:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-14 15:08:21.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-11 04:41:03.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2019-10-11 08:05:06.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2019-10-11 08:16:00.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-10-13 15:27:16.000000000","updated_by":{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},"reviewer":{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},"state":"REVIEWER"},{"updated":"2019-10-14 03:17:57.000000000","updated_by":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"reviewer":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"state":"REVIEWER"},{"updated":"2019-10-14 09:26:14.000000000","updated_by":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"reviewer":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"state":"REVIEWER"},{"updated":"2019-10-14 15:08:21.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2019-10-14 20:56:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a4434868a4927eedf8f8696b49e4d64a542234f4","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-10-10 03:35:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d069fbaa9dae7604ccd54ebaff8d8e0acf36001b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-10 04:22:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f8a090a3aeb54d9cb779fba080074891 : FAILURE in 22m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6fe29db476ec4dd88eee27f0a7cadeea : FAILURE in 19m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ae055cb912c3405e8386a3b524bb5ad0 : FAILURE in 6m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0717ef92981a41478048bcae36f0b570 : TIMED_OUT in 40m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/77300835629448d6ac86a814ed9fb229 : TIMED_OUT in 41m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c3118a75bb1c4cd48d4653e1e27826a3 : TIMED_OUT in 41m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c9999ca774874b6c909befdfd6a06cfd : SUCCESS in 15m 15s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/a7b7cbcc84f54071a9c13e6d9b88c5ea : SUCCESS in 43m 19s","accounts_in_message":[],"_revision_number":1},{"id":"89636ca334e5a733eb35f92890d9621990783f9b","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-10-10 04:50:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9d4790889cb9a80d39f5f9e0687c5805fdb1b568","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-10 05:34:12.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4e385be4941c4097b074f2467c3a84bc : FAILURE in 14m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cbfa0a70b3a74917a0ee213dcd2156dc : FAILURE in 12m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2faceeb6cae143d3bf858f22f50d0b02 : SUCCESS in 5m 26s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/497833533f62491c91b8873294c5c216 : FAILURE in 13m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b1f4730a19b04ef4bc1c99fe379b6af0 : FAILURE in 13m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4054ed11eb6145bd883f90b9e9f788b6 : FAILURE in 12m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/69c825822a91494db7993771ccfe0298 : SUCCESS in 10m 38s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/1dd36f89ebfe40aeb467d4467ea94465 : SUCCESS in 39m 06s","accounts_in_message":[],"_revision_number":2},{"id":"87b6fea75bc503cd6494f86c3e9710c11701c712","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-10-10 15:09:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c8dff7e9977b69577edae9f4bf66f04fd6eaf6d2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-10 17:14:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/08b1fc8ecb0a4c76801efd474316b122 : SUCCESS in 14m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3288208c800e4ee88ee2cb8cfedb6deb : SUCCESS in 13m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6c7feb39c31d40c7921a0f6dcd84eed3 : SUCCESS in 6m 46s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/28b421311a7b4502be8654790437e51a : SUCCESS in 14m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/831734cdca4242f9bdc26ae50b9cb16e : SUCCESS in 13m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bb0514640aa74563bf1a2192bf4e1613 : SUCCESS in 17m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/232cbbe23ac648438e199ad3013f0720 : SUCCESS in 11m 39s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/f4d13c762e32441ea32a647d43a2125c : SUCCESS in 40m 42s","accounts_in_message":[],"_revision_number":3},{"id":"64fb7b4393bc705ef49d6b96ec1513da5cba1c5b","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-10-11 04:41:03.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)\n\nThanks Colleen. Seems like we don\u0027t play much with migrations :)","accounts_in_message":[],"_revision_number":3},{"id":"06d9a29ba563c424d79c70586cbe07f0be1423be","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2019-10-11 08:05:06.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"bd3266a2fe5b3489d77a033232686c1a1560ca00","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2019-10-11 08:16:00.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"ba72dd041dcbb3697c5afac7497d0fd6dad6748e","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-10-11 16:51:42.000000000","message":"Patch Set 3:\n\nhttps://zuul.opendev.org/t/openstack/build/908a2092ab8c4d2b9549dc3f2206539b is an example of this working properly, the test now fails on improperly named migration files","accounts_in_message":[],"_revision_number":3},{"id":"42057e976c7052f25485577dffe486126352ce35","author":{"_account_id":26297,"name":"pippo","email":"1211099771@qq.com","username":"huang.zhiping"},"date":"2019-10-13 15:27:16.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"045b16ec00e68fb2168199612a92164d1e186182","author":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"date":"2019-10-14 03:17:57.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"8719a321ad721c5e6901ca6ff90307e663b645f3","author":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"date":"2019-10-14 09:26:14.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"b6b2ffcab22d70294716e53a00d67deebb7c3237","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-10-14 15:08:21.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"2e1b157642751e154ef73b5c7b2cdbdb6be17342","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-14 15:08:49.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"a4aed2feb0c0a72d87f19830723b04e3dbf6c19e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-14 20:56:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"1d4fb0ef4c87483cc2227a9bb13432f76aa90b9a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-14 20:56:24.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/703874d03aea45199418b562c14a7230 : SUCCESS in 23m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/85e1ca4115e9473fbbd52779d1df202f : SUCCESS in 6m 10s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d5f25204f47c43dbb329cc04a0a67c67 : SUCCESS in 14m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/16cadba76b86487081a4e178da94fd71 : SUCCESS in 15m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/79953931c77d40589b3fcf56c26edb07 : SUCCESS in 14m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6478e3f9966c40cb96c8531fe26b023a : SUCCESS in 12m 29s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/6c30a7585a994e3daf5c15d07f99ffb5 : SUCCESS in 38m 27s","accounts_in_message":[],"_revision_number":3},{"id":"82ea06ef04c896a55d6ae678522df3d9a982e5eb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-14 21:06:36.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3d2aa0977ef848c98e9e6102b4550587 : SUCCESS in 2m 15s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1f860f939dcbd90a7a3b6cd88d21066e306dfd98","revisions":{"a1dc2834b0d06f2483e95174d545f3205274217a":{"kind":"REWORK","_number":1,"created":"2019-10-10 03:35:47.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/70/687770/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/70/687770/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/70/687770/1"}}},"commit":{"parents":[{"commit":"feeaa3823addc8bd8346ec3a10c74ee6da438a51","subject":"Merge \"Update token definitions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/feeaa3823addc8bd8346ec3a10c74ee6da438a51"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-10 03:28:52.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-10 03:28:52.000000000","tz":-420},"subject":"Fix sql migrate repo prefix check","message":"Fix sql migrate repo prefix check\n\nWithout this patch, the test_migrate_repos_file_names_have_prefix test\nmay not necessarily check the latest migration in the repo but could be\nchecking a __pycache__ file or a .pyc bytecode file, which would cause\nthe test to pass even if the latest migration did not contain the\nrequired expand/migrate/contract prefix[1]. This patch corrects the\nissue by using the glob module to filter only valid python files to\ncheck.\n\nThis issue was noticed when the test correctly caught an error in the\npy27 unit test job[1] but erroneously let slide the issue in the py3\ntests[2].\n\n[1] https://aca43ed1a01d95dea0ee-dcdb6cbb330bdac08ffee1284f86c919.ssl.cf2.rackcdn.com/687753/2/check/openstack-tox-py27/f602c1f/testr_results.html.gz\n[2] https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/zuul_opendev_logs_832/687753/2/check/openstack-tox-py37/8322cff/testr_results.html.gz\n\nChange-Id: I636f420e8a0c274131281af1d5aae931c164d91d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/a1dc2834b0d06f2483e95174d545f3205274217a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/a1dc2834b0d06f2483e95174d545f3205274217a"}]},"branch":"refs/heads/master"},"4dff56fa1dd2366f79b9d7287ef274609ab324ef":{"kind":"REWORK","_number":2,"created":"2019-10-10 04:50:10.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/70/687770/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/70/687770/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/70/687770/2"}}},"commit":{"parents":[{"commit":"feeaa3823addc8bd8346ec3a10c74ee6da438a51","subject":"Merge \"Update token definitions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/feeaa3823addc8bd8346ec3a10c74ee6da438a51"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-10 03:28:52.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-10 04:49:55.000000000","tz":-420},"subject":"Fix sql migrate repo prefix check","message":"Fix sql migrate repo prefix check\n\nWithout this patch, the test_migrate_repos_file_names_have_prefix test\nmay not necessarily check the latest migration in the repo but could be\nchecking a __pycache__ file or a .pyc bytecode file, which would cause\nthe test to pass even if the latest migration did not contain the\nrequired expand/migrate/contract prefix[1]. This patch corrects the\nissue by using the glob module to filter only valid python files to\ncheck.\n\nThis issue was noticed when the test correctly caught an error in the\npy27 unit test job[1] but erroneously let slide the issue in the py3\ntests[2].\n\n[1] https://aca43ed1a01d95dea0ee-dcdb6cbb330bdac08ffee1284f86c919.ssl.cf2.rackcdn.com/687753/2/check/openstack-tox-py27/f602c1f/testr_results.html.gz\n[2] https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/zuul_opendev_logs_832/687753/2/check/openstack-tox-py37/8322cff/testr_results.html.gz\n\nChange-Id: I636f420e8a0c274131281af1d5aae931c164d91d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4dff56fa1dd2366f79b9d7287ef274609ab324ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4dff56fa1dd2366f79b9d7287ef274609ab324ef"}]},"branch":"refs/heads/master"},"1f860f939dcbd90a7a3b6cd88d21066e306dfd98":{"kind":"REWORK","_number":3,"created":"2019-10-10 15:09:24.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/70/687770/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/70/687770/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/70/687770/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/70/687770/3"}}},"commit":{"parents":[{"commit":"ccb080867bddfeb744f97076d44d4e47b67ffe08","subject":"Merge \"Add schema placeholders for Train\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ccb080867bddfeb744f97076d44d4e47b67ffe08"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-10 03:28:52.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-10-10 15:09:18.000000000","tz":-420},"subject":"Fix sql migrate repo prefix check","message":"Fix sql migrate repo prefix check\n\nWithout this patch, the test_migrate_repos_file_names_have_prefix test\nmay not necessarily check the latest migration in the repo but could be\nchecking a __pycache__ file or a .pyc bytecode file, which would cause\nthe test to pass even if the latest migration did not contain the\nrequired expand/migrate/contract prefix[1]. This patch corrects the\nissue by using the glob module to filter only valid python files to\ncheck.\n\nThis issue was noticed when the test correctly caught an error in the\npy27 unit test job[1] but erroneously let slide the issue in the py3\ntests[2].\n\n[1] https://aca43ed1a01d95dea0ee-dcdb6cbb330bdac08ffee1284f86c919.ssl.cf2.rackcdn.com/687753/2/check/openstack-tox-py27/f602c1f/testr_results.html.gz\n[2] https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/zuul_opendev_logs_832/687753/2/check/openstack-tox-py37/8322cff/testr_results.html.gz\n\nChange-Id: I636f420e8a0c274131281af1d5aae931c164d91d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/1f860f939dcbd90a7a3b6cd88d21066e306dfd98"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/1f860f939dcbd90a7a3b6cd88d21066e306dfd98"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}