)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ba9ebe4f057e17181284353e31e9541c544a7951","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-10-17 09:56:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove group deletion for non-sql driver when removing domains."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I15b92b35b31d0e5d735a629e7c154ddd7bdda03d"},{"line_number":10,"context_line":"Closes-bug: #1848238"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_74d74951","line":8,"updated":"2019-10-21 17:30:09.000000000","message":"(nitpick) this would be a good place to explain what the problem was and why trying to delete the group isn\u0027t a good idea for the ldap backend.","commit_id":"4133d3d24bc11758a8591ba80ddfb89746efc0c5"}],"keystone/identity/core.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"d08b61ba7a281e844bca3cd998862c1d5470f49d","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        driver \u003d self._select_identity_driver(domain_id)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        user_refs \u003d self.list_users(domain_scope\u003ddomain_id)"},{"line_number":504,"context_line":"        group_refs \u003d self.list_groups(domain_scope\u003ddomain_id)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if driver.is_sql:"},{"line_number":507,"context_line":"            for group in group_refs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_45bedaff","line":504,"range":{"start_line":503,"start_character":8,"end_line":504,"end_character":61},"updated":"2019-10-24 18:36:45.000000000","message":"suggest moving these to inside the \u0027if driver.is_sql:\u0027 statement to improve efficiency. For LDAP driver, no need to perform the unnecessary lookups.","commit_id":"c3a8791e62e20de46e6003cb2b4e7af885498913"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"e7ce0bf2b3ae66ac1a7ba9fd4e423691153cf7a6","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        user_refs \u003d self.list_users(domain_scope\u003ddomain_id)"},{"line_number":504,"context_line":"        group_refs \u003d self.list_groups(domain_scope\u003ddomain_id)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if driver.is_sql:"},{"line_number":507,"context_line":"            for group in group_refs:"},{"line_number":508,"context_line":"                # Cleanup any existing groups."},{"line_number":509,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_16b828e3","line":506,"range":{"start_line":506,"start_character":7,"end_line":506,"end_character":25},"updated":"2019-10-24 07:23:33.000000000","message":"according to this if any group is associated with the domain backed by ldap, we wont delete that group and directly delete domain?","commit_id":"c3a8791e62e20de46e6003cb2b4e7af885498913"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0cc90680d0e9808926b1a388e79478cb71734fcb","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        user_refs \u003d self.list_users(domain_scope\u003ddomain_id)"},{"line_number":504,"context_line":"        group_refs \u003d self.list_groups(domain_scope\u003ddomain_id)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if driver.is_sql:"},{"line_number":507,"context_line":"            for group in group_refs:"},{"line_number":508,"context_line":"                # Cleanup any existing groups."},{"line_number":509,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_4139f1a0","line":506,"range":{"start_line":506,"start_character":7,"end_line":506,"end_character":25},"in_reply_to":"3fa7e38b_16b828e3","updated":"2019-10-24 15:37:10.000000000","message":"This sounds weird. Do we mirror LDAP groups in Keystone? If not, why are there any LDAP groups in Keystone to delete?","commit_id":"c3a8791e62e20de46e6003cb2b4e7af885498913"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6070a0e720d80b21f148882912536787b2047f48","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        user_refs \u003d self.list_users(domain_scope\u003ddomain_id)"},{"line_number":504,"context_line":"        group_refs \u003d self.list_groups(domain_scope\u003ddomain_id)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if driver.is_sql:"},{"line_number":507,"context_line":"            for group in group_refs:"},{"line_number":508,"context_line":"                # Cleanup any existing groups."},{"line_number":509,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_a23a24c1","line":506,"range":{"start_line":506,"start_character":7,"end_line":506,"end_character":25},"in_reply_to":"3fa7e38b_4139f1a0","updated":"2019-10-24 17:25:53.000000000","message":"Maybe this discussion will help provide context: http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2019-10-15.log.html#t2019-10-15T14:58:20\n\nGroups are the same as users, see below for how we handle them when the domain is deleted. A domain is the namespace for users and groups, and normally when we delete a domain there are notifications emitted and we try to clean up everything owned by that domain - projects, users, roles, and groups. But users and groups are part of a different driver than projects and roles. If we try to delete a user that is *owned* by the domain but *backed* by LDAP, we get an error because we can\u0027t write to LDAP. Same with groups.","commit_id":"c3a8791e62e20de46e6003cb2b4e7af885498913"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"d08b61ba7a281e844bca3cd998862c1d5470f49d","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        user_refs \u003d self.list_users(domain_scope\u003ddomain_id)"},{"line_number":504,"context_line":"        group_refs \u003d self.list_groups(domain_scope\u003ddomain_id)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if driver.is_sql:"},{"line_number":507,"context_line":"            for group in group_refs:"},{"line_number":508,"context_line":"                # Cleanup any existing groups."},{"line_number":509,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_25395ea2","line":506,"range":{"start_line":506,"start_character":7,"end_line":506,"end_character":25},"in_reply_to":"3fa7e38b_a23a24c1","updated":"2019-10-24 18:36:45.000000000","message":"I see. Thanks for the context.","commit_id":"c3a8791e62e20de46e6003cb2b4e7af885498913"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"6f2d36c3817c1b48341d5a68784c409ed48e9abe","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        user_refs \u003d self.list_users(domain_scope\u003ddomain_id)"},{"line_number":504,"context_line":"        group_refs \u003d self.list_groups(domain_scope\u003ddomain_id)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if driver.is_sql:"},{"line_number":507,"context_line":"            for group in group_refs:"},{"line_number":508,"context_line":"                # Cleanup any existing groups."},{"line_number":509,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_7d592259","line":506,"range":{"start_line":506,"start_character":7,"end_line":506,"end_character":25},"in_reply_to":"3fa7e38b_a23a24c1","updated":"2019-10-25 10:02:33.000000000","message":"ahhh ok. Thanks for sharing the logs.","commit_id":"c3a8791e62e20de46e6003cb2b4e7af885498913"}]}