)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"1f6d851575146be5ef197955a17d073b28af5213","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        yield session"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def _filter(model, query, hints):"},{"line_number":157,"context_line":"    \"\"\"Applies filtering to a query."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    :param model: the table model in question"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bd6s%3D","line":156,"updated":"2014-01-25 16:46:13.000000000","message":"as this is becoming a public module-level function, it needs to be renamed as part of this patch","commit_id":"3ab5178c85484ce1590a1dcbba5e35303dfe939b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1a84907d485e0ebadad79bef40d0abf64b68b232","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        yield session"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def _filter(model, query, hints):"},{"line_number":157,"context_line":"    \"\"\"Applies filtering to a query."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    :param model: the table model in question"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bd5g%3D","line":156,"in_reply_to":"AAAAUH%2F%2Bd6s%3D","updated":"2014-01-25 16:51:56.000000000","message":"Dolph - This function isn\u0027t meant to be public -- the only place it\u0027s called is from filter_query() at line 259, which is the public function.\n\nI could probably get rid of this function and just put all this code in filter_query.","commit_id":"3ab5178c85484ce1590a1dcbba5e35303dfe939b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9879cbd1b9255bafa2c87c2831e3f2a538dea21e","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if hints is not None:"},{"line_number":265,"context_line":"        query \u003d _filter(model, query, hints)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    return query"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2Bbe0%3D","line":265,"updated":"2014-01-26 21:37:49.000000000","message":"this wrapper is pointless","commit_id":"220334577a692284672149d6b6df8c3ae291a242"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"75923313d809fa8cca75877618821050f4e40b1b","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if hints is not None:"},{"line_number":265,"context_line":"        query \u003d _filter(model, query, hints)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    return query"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9lgo%3D","line":265,"in_reply_to":"AAAAUH%2F%2Bbe0%3D","updated":"2014-02-05 22:18:25.000000000","message":"++ This seems to be adding in an extra layer for the sake of adding in an extra layer","commit_id":"220334577a692284672149d6b6df8c3ae291a242"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3fc7025e7ccf3af150f755b82c6a31f7c18bb093","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if hints is not None:"},{"line_number":265,"context_line":"        query \u003d _filter(model, query, hints)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    return query"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9kaE%3D","line":265,"in_reply_to":"AAAAUH%2F9kbw%3D","updated":"2014-02-06 00:01:34.000000000","message":"I marked this change as a wip because I plan to rebase it on https://review.openstack.org/#/c/44836/ (I\u0027d do it now but I don\u0027t think 44836 is ready and then I\u0027d have to rebase it again) Hopefully that will satisfy everyone.","commit_id":"220334577a692284672149d6b6df8c3ae291a242"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"bfb23182043e3411a2371251444bb2aed5d8c4c7","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if hints is not None:"},{"line_number":265,"context_line":"        query \u003d _filter(model, query, hints)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    return query"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9kbw%3D","line":265,"in_reply_to":"AAAAUH%2F9lgo%3D","updated":"2014-02-05 23:56:02.000000000","message":"Except, if you look at the next patch for limits, you see why it makes sense to have it, see: https://review.openstack.org/#/c/44836/","commit_id":"220334577a692284672149d6b6df8c3ae291a242"}]}