)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"66c4b3253390dab8ea0432af1202e7f252b59fdf","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        for filter_ in hints.filters():"},{"line_number":234,"context_line":"            # TODO(henry-nash): Check if name is valid column, if not skip"},{"line_number":235,"context_line":"            if filter_[\u0027comparator\u0027] \u003d\u003d \u0027equals\u0027:"},{"line_number":236,"context_line":"                filter_dict \u003d exact_filter(model, filter_, hints)"},{"line_number":237,"context_line":"            else:"},{"line_number":238,"context_line":"                query \u003d inexact_filter(model, query, filter_, hints)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BbxM%3D","line":236,"updated":"2014-01-26 17:54:45.000000000","message":"This combination of updating filter_dict within the method as well as returning the result is confusing to me…it\u0027s not obvious reading this line that the previous contents of flter_dict are retained.  However, if others feel this is OK, then I\u0027ll remove the -1.","commit_id":"599b919d58c3232184e8a38a9471c7e0d7b5e9b4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"56d37189c771f7c1854a3b64cf4bde52477e6818","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        for filter_ in hints.filters():"},{"line_number":234,"context_line":"            # TODO(henry-nash): Check if name is valid column, if not skip"},{"line_number":235,"context_line":"            if filter_[\u0027comparator\u0027] \u003d\u003d \u0027equals\u0027:"},{"line_number":236,"context_line":"                filter_dict \u003d exact_filter(model, filter_, hints)"},{"line_number":237,"context_line":"            else:"},{"line_number":238,"context_line":"                query \u003d inexact_filter(model, query, filter_, hints)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BbwQ%3D","line":236,"in_reply_to":"AAAAUH%2F%2BbxM%3D","updated":"2014-01-26 18:05:34.000000000","message":"the behavior of the exact_filter function hasn\u0027t changed. Before, the filter_dict was passed in as cumlative_filter_dict and then it wasn\u0027t used. I could fix it to use the value passed in instead if that\u0027s the preferred fix. I was just trying to avoid changing the behavior at all.","commit_id":"599b919d58c3232184e8a38a9471c7e0d7b5e9b4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"aa4e009af23defad953aff7a32ef96e3710b0bc2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        key \u003d filter_[\u0027name\u0027]"},{"line_number":223,"context_line":"        if isinstance(getattr(model, key).property.columns[0].type,"},{"line_number":224,"context_line":"                      sql.types.Boolean):"},{"line_number":225,"context_line":"            filter_dict[key] \u003d utils.attr_as_boolean(filter_[\u0027value\u0027])"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            filter_dict[key] \u003d filter_[\u0027value\u0027]"},{"line_number":228,"context_line":"        hints.remove(filter_)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BblA%3D","line":225,"updated":"2014-01-26 20:35:18.000000000","message":"Ahh, so the now I get the issue.  filter_dict here (and below) should actually have been cumlative_filter_dict.  In fact it works with that bug due to the scope of filter_dict, but isn\u0027t actually what I intended.  Let me post a different patch and then we\u0027ll see which we prefer","commit_id":"9a2f01ea68584bd335dafcf0151532cc8312728d"}]}