)]}'
{"keystone/tests/test_v3.py":[{"author":{"_account_id":6738,"name":"bryan-murray","email":"bryan.murray@hp.com","username":"bryan-murray"},"change_message_id":"c98edd12319b682fdbe39a02440fbc0951b5a678","unresolved":false,"context_lines":[{"line_number":948,"context_line":""},{"line_number":949,"context_line":"        self.assertValidListLinks(entity.get(\u0027roles_links\u0027))"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        # these were used during dev and shouldn\u0027t land in final impl"},{"line_number":952,"context_line":"        self.assertNotIn(\u0027role_ids\u0027, entity)"},{"line_number":953,"context_line":"        self.assertNotIn(\u0027role_names\u0027, entity)"},{"line_number":954,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BNmI%3D","side":"PARENT","line":951,"updated":"2014-01-29 01:09:13.000000000","message":"Why are these tests being removed? It seems if it was important to check for this in the past that we should continue to make sure that some old debugging code does not get re-enabled.","commit_id":"0d83e7eee20a50a75863a9d3c75aee7030518229"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"e7881c9ef8504d87870ff94a4870f8a420722f0a","unresolved":false,"context_lines":[{"line_number":948,"context_line":""},{"line_number":949,"context_line":"        self.assertValidListLinks(entity.get(\u0027roles_links\u0027))"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        # these were used during dev and shouldn\u0027t land in final impl"},{"line_number":952,"context_line":"        self.assertNotIn(\u0027role_ids\u0027, entity)"},{"line_number":953,"context_line":"        self.assertNotIn(\u0027role_names\u0027, entity)"},{"line_number":954,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9%2FDc%3D","side":"PARENT","line":951,"in_reply_to":"AAAAUH%2F%2BNmI%3D","updated":"2014-01-31 10:43:25.000000000","message":"What debugging code?  Neither of these appear in the published spec for the interface, or any of the interface implementation, so there\u0027s no reason to test them AFAICS.  \n\nIf you think otherwise, you\u0027re free to propose a patch to keystone master reinstating the tests.  We can\u0027t make any changes here anyway, this is a stable branch backport of something which has already landed in master.","commit_id":"0d83e7eee20a50a75863a9d3c75aee7030518229"}],"keystone/trust/controllers.py":[{"author":{"_account_id":994,"name":"Arvind Tiwari","email":"arvindt7@gmail.com","username":"arvind-tiwari"},"change_message_id":"1ba3d6ffc2bec53d3be7cd2516970833aece97d1","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            if trust.get(\u0027expires_at\u0027) is not None:"},{"line_number":213,"context_line":"                trust[\u0027expires_at\u0027] \u003d (timeutils.isotime"},{"line_number":214,"context_line":"                                       (trust[\u0027expires_at\u0027],"},{"line_number":215,"context_line":"                                        subsecond\u003dTrue))"},{"line_number":216,"context_line":"        return TrustV3.wrap_collection(context, trusts)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BQhk%3D","line":215,"updated":"2014-01-28 16:20:20.000000000","message":"Some comments on \"expires_at\" would be helpful.","commit_id":"f6a6bba0d447182e06120598c718b92b2e3d72a5"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"f5701c5b76a407acce7a208342296fee98fd118d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            if trust.get(\u0027expires_at\u0027) is not None:"},{"line_number":213,"context_line":"                trust[\u0027expires_at\u0027] \u003d (timeutils.isotime"},{"line_number":214,"context_line":"                                       (trust[\u0027expires_at\u0027],"},{"line_number":215,"context_line":"                                        subsecond\u003dTrue))"},{"line_number":216,"context_line":"        return TrustV3.wrap_collection(context, trusts)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BOmI%3D","line":215,"in_reply_to":"AAAAUH%2F%2BPB4%3D","updated":"2014-01-28 21:47:53.000000000","message":"also this is cherry picked from master onto stable. I dont want to actually modify the code","commit_id":"f6a6bba0d447182e06120598c718b92b2e3d72a5"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"75d1bbd4d89239db51cb79f6b5946fe8056f8d46","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            if trust.get(\u0027expires_at\u0027) is not None:"},{"line_number":213,"context_line":"                trust[\u0027expires_at\u0027] \u003d (timeutils.isotime"},{"line_number":214,"context_line":"                                       (trust[\u0027expires_at\u0027],"},{"line_number":215,"context_line":"                                        subsecond\u003dTrue))"},{"line_number":216,"context_line":"        return TrustV3.wrap_collection(context, trusts)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BPB4%3D","line":215,"in_reply_to":"AAAAUH%2F%2BQhk%3D","updated":"2014-01-28 20:19:07.000000000","message":"pretty standard in keystone to maintain the expiration date","commit_id":"f6a6bba0d447182e06120598c718b92b2e3d72a5"}]}