)]}'
{"id":"openstack%2Fkeystone~697355","triplet_id":"openstack%2Fkeystone~master~I5dd85a6b8368373a27aef2942a64499d020662ef","project":"openstack/keystone","branch":"master","topic":"credential-list-sec","hashtags":[],"change_id":"I5dd85a6b8368373a27aef2942a64499d020662ef","subject":"Fix credential list for project members","status":"MERGED","created":"2019-12-04 19:45:16.000000000","updated":"2019-12-06 02:57:02.000000000","submitted":"2019-12-06 02:20:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697355-1575598819817-758459c9","meta_rev_id":"07773b782bf7db441e74771df612e4eb1d7dbed7","_number":697355,"virtual_id_number":697355,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"date":"2019-12-05 19:27:41.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-06 02:20:19.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"recommended":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"all":[{"value":0,"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":1,"date":"2019-12-05 09:14:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":2,"date":"2019-12-05 19:42:36.000000000","_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":2,"date":"2019-12-05 19:50:20.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":0,"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":1,"date":"2019-12-05 19:50:20.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-04 19:45:39.000000000","updated_by":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"},{"updated":"2019-12-04 20:29:22.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2019-12-05 09:14:23.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2019-12-05 19:42:36.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2019-12-05 19:50:20.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2019-12-06 02:20:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a0ba24bfe1897f54520e82e1fd13454fdd69ebd5","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-04 19:45:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89e2d397ae1b6d7bf3f670d0186ff50da43888e1","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-12-04 19:53:25.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Colleen","accounts_in_message":[],"_revision_number":1},{"id":"eceb20ca7ac3da7992debf3c4edf9c9871671e6e","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-12-04 20:29:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0146d757bae3c74361bdfc31f7a73c3153228301","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-04 20:54:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1650b3e3363783bac8aed9e0ba4a013752d98674","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2019-12-04 21:09:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"54330b0412bdad1d25032e75c512634d47182336","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 21:14:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5500284f51b349bfb1a3fc0bcfba111c : SUCCESS in 16m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4ee8970fc2f14882a8f0fd1567c4de4c : SUCCESS in 13m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/63c9a6ae10f145d4abc0a6cdc3e680cc : SUCCESS in 5m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e1df5dd6e42c4efb8e809a86e883eb77 : SUCCESS in 18m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f50b31e06c8a4361bbc058788c9aec15 : TIMED_OUT in 41m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7a9e14aa36034b0da4d01f7ae817193c : SUCCESS in 11m 54s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/0f9a9d6c1f3d415b917f99e81de65a17 : SUCCESS in 1h 02m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f133e002ac24474fa2008a37a52821dc : FAILURE in 1h 19m 46s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b70b0ed0b43d4163aaead4da74bb8365 : SUCCESS in 17m 15s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/e4b7bf6eeb4047f985105976ac1f34c6 : SUCCESS in 44m 06s\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/4b1d8138d12e411a825064a10357bce0 : SUCCESS in 35m 36s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/8bbd0682dbe24df6b22bcf28a81d34da : SUCCESS in 35m 20s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/33efd7d8aaaa451ebcc37fb7aaf5067d : FAILURE in 19m 28s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/0ad05b5ae70d479db698f6224fade4d0 : SUCCESS in 44m 14s (non-voting)\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/820756adbde14463b0a468b5b441b33d : SUCCESS in 1h 03m 04s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ba5102ec722940c5822950d0fa48b26c : SUCCESS in 1h 05m 06s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/45423c6f64954496a11ea3f75b36b18b : SUCCESS in 42m 31s","accounts_in_message":[],"_revision_number":1},{"id":"630529e678e841002d66a97060e8e30d474ce417","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-12-04 21:16:15.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"ea6a3b8df94b2b745d711da123b84a88e1ae5a26","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 22:52:40.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d9521db707b24ddda6d320eda48a75fc : SUCCESS in 21m 16s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/737ccb508df64a7991c238fab0722fe9 : SUCCESS in 16m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4be7857343304e28b24c8a6ecf635068 : SUCCESS in 5m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5d37a58b0ea41c483ec3aba171a0994 : SUCCESS in 19m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/34c334551ac64f0d89c1db47f7695ca7 : SUCCESS in 21m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e597dd26a50c489f9ba835d65805daa9 : SUCCESS in 11m 46s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/9c9f1ff66df247f8930099e02b094c36 : SUCCESS in 1h 11m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1d3607f451204c518e6ebfea435f27a5 : FAILURE in 1h 24m 43s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/da7c8be0a4344fefb56a786c3860d599 : SUCCESS in 17m 37s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/01f8f8865bbe4217afeecd3ac92c46a0 : SUCCESS in 27m 36s\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/8dcdcd699b11489db7f20e4351df8c8c : SUCCESS in 38m 44s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/17b748323c494285b3d388ca89b42a8d : SUCCESS in 41m 47s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/7e5146ded93744a1b22e15ab928c3ce7 : FAILURE in 18m 29s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/f67aa50758b04771aef95630a8e35eb3 : SUCCESS in 45m 29s (non-voting)\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/06c3c263478a446da022005760f996b3 : SUCCESS in 1h 06m 42s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0cf7e4020c5b4985a1246a16b1ba1a43 : SUCCESS in 1h 02m 21s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/03edda7d45894d468fd6467a1377fcf5 : SUCCESS in 47m 08s","accounts_in_message":[],"_revision_number":1},{"id":"0470e827a161c51c847f002f3d97608ef5f7e601","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-04 22:59:29.000000000","message":"Patch Set 1:\n\nvalid test failure, don\u0027t recheck\n\n Traceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/api/identity/admin/v3/test_credentials.py\", line 105, in test_credentials_list_delete\n    \u0027, \u0027.join(m_cred for m_cred in missing_creds))\n  File \"/opt/stack/tempest/tempest/test.py\", line 888, in assertEmpty\n    self.assertFalse(items, msg)\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.6/site-packages/unittest2/case.py\", line 696, in assertFalse\n    raise self.failureException(msg)\n AssertionError: [\u0027c89d54d43c651b98b2a640b2ad9501caea860892df347b23c8c697d9f83905e5\u0027, \u00271cd17dcaf6fd5b0d415344a6514f962c400828092bb3bf1037ea15d5d7ee5d11\u0027] is not false : Failed to find cred c89d54d43c651b98b2a640b2ad9501caea860892df347b23c8c697d9f83905e5, 1cd17dcaf6fd5b0d415344a6514f962c400828092bb3bf1037ea15d5d7ee5d11 in fetched list","accounts_in_message":[],"_revision_number":1},{"id":"6379551714a82009acacd5e26ce0a50abc797175","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-05 00:41:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"72b3d758d8ab5cd3602a972a2f45bf7072b1997c","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-05 00:42:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"99b47d59a7b2ba42941bdac547dbf09a3ec102e7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-05 01:54:32.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c86aebc8a033478db7862f292d5fcf59 : SUCCESS in 23m 46s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b105caabb73c48edba1eb8b981759ff0 : SUCCESS in 22m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f1ddc28a469645f3904b6cd233321b73 : SUCCESS in 5m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/140957d171844785b12763f64a967a13 : SUCCESS in 15m 11s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9d328aaf3db7421192efd585f4a0b03b : SUCCESS in 17m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/857a7a59463e48a1b82d31e82e445475 : SUCCESS in 13m 14s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/5e70c44203e94cbcb4e48b51beeb9f8f : SUCCESS in 55m 13s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/80b99fb39e3f46c288cd5d8d8ca1d1bf : SUCCESS in 1h 08m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/92687386a5b34b99b5074057f6205bf9 : SUCCESS in 15m 00s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/b757dc1bb83549f381908f59c187801d : SUCCESS in 31m 17s\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/11e4ff87265c40939219e551eb15a156 : SUCCESS in 34m 51s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/83dd1ddade624eceb5a93f08c3fae449 : SUCCESS in 36m 52s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/3ffddbaac9624b74abfdfafbb9158e19 : SUCCESS in 17m 36s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/544fe2a2003446eea22dc18d1aa1068b : SUCCESS in 38m 30s (non-voting)\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/618209c0859a4388b9640ad3af782c2d : SUCCESS in 1h 06m 32s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9479fa5ea228421c921a2843e4a2bffe : SUCCESS in 1h 04m 24s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/1a986719a3504efa85708c9dc57536ac : SUCCESS in 36m 32s","accounts_in_message":[],"_revision_number":3},{"id":"3214abd34cbf9540fe3061a3f1c54eb7c88b21f8","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-12-05 09:14:23.000000000","message":"Patch Set 3: Code-Review+1\n\nTested the patch, only project admins are able to list all application credentials when enforce scope is false and when true the list credentials is only applicable to system admins.","accounts_in_message":[],"_revision_number":3},{"id":"0fd29a7e763c0cfbfe9d201146373781d88d96f3","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2019-12-05 19:06:54.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"d83dbe41ebc241aa3b9ff3c4382bd5fc8f49e998","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2019-12-05 19:07:30.000000000","message":"Patch Set 3:\n\nAre we planning on backporting this?","accounts_in_message":[],"_revision_number":3},{"id":"3a2eec7b72df95d35ea636f6c439f25b5b19f617","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-12-05 19:09:46.000000000","message":"Patch Set 3:\n\n\u003e Are we planning on backporting this?\n\nShould backport this to Stein, the api code changed here after Rocky.","accounts_in_message":[],"_revision_number":3},{"id":"397e9f77c80046047819432e233d2be17ad3ecbe","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-05 19:27:41.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"572e3d49e6b359ca814e60294f8c8fc6e250b6f3","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2019-12-05 19:42:34.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c3b6bc2ffd482e077f6d00ea117e7650352dc484","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2019-12-05 19:42:36.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c42b08b4264ddbed1c99c3d764c8a317f2fd572b","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2019-12-05 19:42:47.000000000","message":"Patch Set 3:\n\nMy comments were addressed. Thanks, Colleen.","accounts_in_message":[],"_revision_number":3},{"id":"d1cf2588d34f3a188b4376c9894b5cd38ec26405","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-12-05 19:50:20.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"5298646c9aa513411d3aa68b43d0cefd37cfe934","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-05 19:51:07.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"1508a9508bbddfb9bdc4c35d235f8182ae43fcfd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-06 02:20:19.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/520a058d86554561808ee39ea0341e38 : SUCCESS in 22m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/862107a7a545480cbe6f8bd38754e568 : SUCCESS in 5m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0b23e562495c4269ba31d2959e528fc5 : SUCCESS in 20m 52s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/aa23b2ce11cd4a0b9e204436ef52969f : SUCCESS in 19m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7b4d8c27192449f8ab80684ae46c0047 : SUCCESS in 12m 13s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/88d0cef94e5b46f98725948567505dd3 : SUCCESS in 1h 01m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7ab2785599034db6819b6a4d135167ee : SUCCESS in 1h 38m 48s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cd340d2b914b41d5ae91b4e80601aae3 : SUCCESS in 19m 53s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/99df363dfeb64b6790f700b177f0b885 : SUCCESS in 36m 02s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/be5f6780ba894bbe9ad816046d1b536c : SUCCESS in 33m 04s\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/1a459662abb04d2f884142266c7f31cd : SUCCESS in 38m 57s\n- tempest-full https://zuul.opendev.org/t/openstack/build/340056fcb3fb4b428f67dd1ce5f48c3e : SUCCESS in 1h 41m 12s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/9a9ce795480c4da4ab75398758dcb9ef : SUCCESS in 59m 05s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/fa42ad6047da449ebaaf0053dcc0cb43 : SUCCESS in 1h 22m 04s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/df2a34f66a1d4e7798452e466fbec2f0 : SUCCESS in 40m 47s","accounts_in_message":[],"_revision_number":3},{"id":"2423fc3651e2c8432fc1dbdabea265b5a7f5aec9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-06 02:20:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"728b445c41e8a07debe7dc4fa11f1fc66c6c6983","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-06 02:22:02.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6f6bec0b258147d2952952cb41af9f71 : SUCCESS in 1m 22s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9e0c7913b01e403db5daa638f2d70f80 : SUCCESS in 52s","accounts_in_message":[],"_revision_number":3},{"id":"f799c66e00c7a85cd2e4e1840f16fa1ba20058d0","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-06 02:57:02.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit bd3f63787151183f4daa43578aa491856fefae5b","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"17c337dbdbfb9d548ad531c2ad0483c9bce5b98f","revisions":{"137bd97be978faa5c77986f1f0166deca03b05e4":{"kind":"REWORK","_number":1,"created":"2019-12-04 19:45:16.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/55/697355/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/55/697355/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/55/697355/1"}}},"commit":{"parents":[{"commit":"72cbaa91ffa6727f6400ec38331896f0a9e326c6","subject":"Start README.rst with a better title","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/72cbaa91ffa6727f6400ec38331896f0a9e326c6"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-04 18:51:05.000000000","tz":-480},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-04 18:51:05.000000000","tz":-480},"subject":"Fix credential list for project members","message":"Fix credential list for project members\n\nWithout this patch, project members and readers can list any credentials\nwith the /v3/credentials API when enforce_scope is false. enforce_scope\nis only applicable to project admins due to the admin-ness problem[1],\nand this policy is not meant to allow project admins any access to users\u0027\ncredentials (only system admins should be able to access them), so this\npatch simply removes the config check.\n\nCloses-bug: #1855080\n\n[1] https://bugs.launchpad.net/keystone/+bug/968696\n\nChange-Id: I5dd85a6b8368373a27aef2942a64499d020662ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/137bd97be978faa5c77986f1f0166deca03b05e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/137bd97be978faa5c77986f1f0166deca03b05e4"}]},"branch":"refs/heads/master"},"fd7882f669f477e6d3b978ca45617595134e6719":{"kind":"REWORK","_number":2,"created":"2019-12-05 00:41:07.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/55/697355/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/55/697355/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/55/697355/2"}}},"commit":{"parents":[{"commit":"72cbaa91ffa6727f6400ec38331896f0a9e326c6","subject":"Start README.rst with a better title","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/72cbaa91ffa6727f6400ec38331896f0a9e326c6"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-04 18:51:05.000000000","tz":-480},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-05 00:40:51.000000000","tz":-480},"subject":"Fix credential list for project members","message":"Fix credential list for project members\n\nWithout this patch, project members and readers can list any credentials\nwith the /v3/credentials API when enforce_scope is false. enforce_scope\nis only applicable to project admins due to the admin-ness problem[1],\nand this policy is not meant to allow project admins any access to users\u0027\ncredentials (only system admins should be able to access them). However,\nwhen enforce_scope is false, we need to preserve the old behavior of\nproject admins being able to list all credentials. This change mitigates\nthe problem by running the identity:get_credential policy check to\nfilter out credentials the user does not have access to. This will\nimpact performance.\n\nCloses-bug: #1855080\n\n[1] https://bugs.launchpad.net/keystone/+bug/968696\n\nChange-Id: I5dd85a6b8368373a27aef2942a64499d020662ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/fd7882f669f477e6d3b978ca45617595134e6719"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/fd7882f669f477e6d3b978ca45617595134e6719"}]},"branch":"refs/heads/master"},"17c337dbdbfb9d548ad531c2ad0483c9bce5b98f":{"kind":"REWORK","_number":3,"created":"2019-12-05 00:42:23.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/55/697355/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/55/697355/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/697355/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/55/697355/3"}}},"commit":{"parents":[{"commit":"72cbaa91ffa6727f6400ec38331896f0a9e326c6","subject":"Start README.rst with a better title","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/72cbaa91ffa6727f6400ec38331896f0a9e326c6"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-04 18:51:05.000000000","tz":-480},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-05 00:42:17.000000000","tz":-480},"subject":"Fix credential list for project members","message":"Fix credential list for project members\n\nWithout this patch, project members and readers can list any credentials\nwith the /v3/credentials API when enforce_scope is false. enforce_scope\nis only applicable to project admins due to the admin-ness problem[1],\nand this policy is not meant to allow project admins any access to users\u0027\ncredentials (only system admins should be able to access them). However,\nwhen enforce_scope is false, we need to preserve the old behavior of\nproject admins being able to list all credentials. This change mitigates\nthe problem by running the identity:get_credential policy check to\nfilter out credentials the user does not have access to. This will\nimpact performance.\n\nCloses-bug: #1855080\n\n[1] https://bugs.launchpad.net/keystone/+bug/968696\n\nChange-Id: I5dd85a6b8368373a27aef2942a64499d020662ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/17c337dbdbfb9d548ad531c2ad0483c9bce5b98f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/17c337dbdbfb9d548ad531c2ad0483c9bce5b98f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}