)]}'
{"id":"openstack%2Fkeystone~697731","triplet_id":"openstack%2Fkeystone~stable%2Fstein~I5dd85a6b8368373a27aef2942a64499d020662ef","project":"openstack/keystone","branch":"stable/stein","hashtags":[],"change_id":"I5dd85a6b8368373a27aef2942a64499d020662ef","subject":"Fix credential list for project members","status":"MERGED","created":"2019-12-06 22:25:33.000000000","updated":"2019-12-07 20:21:51.000000000","submitted":"2019-12-07 20:20:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697731-1575750024839-91269b4c","meta_rev_id":"44e96860c39dabf822407ac2b88f9fd77c161df0","_number":697731,"virtual_id_number":697731,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-07 20:20:24.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-12-07 18:48:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2019-12-06 22:27:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":1,"date":"2019-12-06 22:36:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2019-12-07 18:48:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-06 22:27:44.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2019-12-06 22:36:38.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2019-12-07 18:48:02.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-12-07 20:20:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"155db3fea82e3392e44c7d182682139d17c5f7ae","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-12-06 22:25:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a53ce2f633f25e03cfa69019b18f330647a18d8a","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2019-12-06 22:27:44.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks like a clean cherry-pick.","accounts_in_message":[],"_revision_number":1},{"id":"7fe4e6fc6af5901755e8e81f4a2525da45dd1460","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2019-12-06 22:36:38.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0b62ef178667a8309b70b92fb08952a12f70c5eb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-06 23:59:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0d646dd4e87845d7a1bb3d912d4ad28e : SUCCESS in 32m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1c0df274229f404b971119466447ee3e : SUCCESS in 32m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0bf653b6784543c2960f55abd0a25fd5 : SUCCESS in 5m 06s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e84f5247e35c42ae968e55e73801f726 : SUCCESS in 18m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b4e93b92e55e4758b435f3effae0a5ec : SUCCESS in 19m 54s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/de67e98c0c3341cf8a3335bb86c1ec64 : SUCCESS in 26m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c304de4eb754c88bc4f4f7835cc6d89 : SUCCESS in 11m 17s\n- tempest-full https://zuul.opendev.org/t/openstack/build/ad2546c92bb047bb9bab8c05ed32633b : SUCCESS in 1h 32m 09s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/6a1db05f9b1d420e936f593df7d297e4 : SUCCESS in 54m 42s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/a06959ae0d304eadabce97780f0cda88 : SUCCESS in 50m 25s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d9d1bc109d85429bafe0316dbc95dbf1 : SUCCESS in 1h 29m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1f510fe4f96348d1b55e8eeaa7b2f1f3 : SUCCESS in 15m 28s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/d487232ef6e445db8b0f70f627388016 : SUCCESS in 32m 45s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/c82cd7a2bf5a43b59a643367050e65b7 : SUCCESS in 34m 04s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/5a02eabcf27a4082a4c5bbb988e165f5 : FAILURE in 36m 24s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/d2896361851c409fa99d92704e677a23 : FAILURE in 39m 29s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/f2ef7bc7215a4007b46232a753745376 : FAILURE in 12m 17s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/4f99569e4c4a49f4b90b666aeeab99ed : SUCCESS in 43m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"02d4a8b553889d821b94357d0e0f2b532eb2f8d5","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-12-07 18:48:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7c4bb24e10a9b2904e35a7eb28ba3405314e27bf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 18:50:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7a3825b5564025965ea0a0141923778418e67926","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 20:20:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"6d7214fe9a963acd6c43af2c09e75414ea4358e8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 20:20:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e5c0302f1be646d4bb639849d54cf73e : SUCCESS in 24m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7860f5f55dd04c4ebd8d293f8455c5e6 : SUCCESS in 5m 33s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ed8ec41cdb074b92b4fb24e7b6d051fa : SUCCESS in 18m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d497461fa2df47a58f1a2a6dc81145e4 : SUCCESS in 20m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/060d616336564c2fb988adfa25a4b7e3 : SUCCESS in 20m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/19e554b47e3f4ff1b20b366f2c9fcab0 : SUCCESS in 8m 33s\n- tempest-full https://zuul.opendev.org/t/openstack/build/6a2223549ad148659a5c80e865f830aa : SUCCESS in 1h 23m 59s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/3b9ce6c6c2ae4822bda78e768d28dfbc : SUCCESS in 52m 21s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/0fafa59cc2de4b59b73bba8af5803bff : SUCCESS in 54m 06s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/9993d21f7ef74ea8950f21961fd7486b : SUCCESS in 1h 16m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/82f34c5b06c141a48e23acac45532351 : SUCCESS in 17m 17s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/1d173b807372473b9c8414a1d39754ee : SUCCESS in 31m 27s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/b5d9b53e76c146498093733486615a92 : SUCCESS in 29m 14s","accounts_in_message":[],"_revision_number":1},{"id":"44e96860c39dabf822407ac2b88f9fd77c161df0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-07 20:21:51.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a4c6df8d62bf474e9bf824ba64a41866 : SUCCESS in 1m 05s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a277a2d1a29e42e48356886259ecf7b3 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"17947516b0095c51da5cff94771247f2e7c44ee6","revisions":{"17947516b0095c51da5cff94771247f2e7c44ee6":{"kind":"REWORK","_number":1,"created":"2019-12-06 22:25:33.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/31/697731/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/31/697731/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/31/697731/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/31/697731/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/31/697731/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/31/697731/1"}}},"commit":{"parents":[{"commit":"7a81c84e2fbd79522f695827dd80e7120b38def7","subject":"Merge \"token: consistently decode binary types\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/7a81c84e2fbd79522f695827dd80e7120b38def7"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-04 18:51:05.000000000","tz":-480},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-12-06 22:25:23.000000000","tz":-480},"subject":"Fix credential list for project members","message":"Fix credential list for project members\n\nWithout this patch, project members and readers can list any credentials\nwith the /v3/credentials API when enforce_scope is false. enforce_scope\nis only applicable to project admins due to the admin-ness problem[1],\nand this policy is not meant to allow project admins any access to users\u0027\ncredentials (only system admins should be able to access them). However,\nwhen enforce_scope is false, we need to preserve the old behavior of\nproject admins being able to list all credentials. This change mitigates\nthe problem by running the identity:get_credential policy check to\nfilter out credentials the user does not have access to. This will\nimpact performance.\n\nCloses-bug: #1855080\n\n[1] https://bugs.launchpad.net/keystone/+bug/968696\n\nChange-Id: I5dd85a6b8368373a27aef2942a64499d020662ef\n(cherry picked from commit 17c337dbdbfb9d548ad531c2ad0483c9bce5b98f)\n(cherry picked from commit bd3f63787151183f4daa43578aa491856fefae5b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/17947516b0095c51da5cff94771247f2e7c44ee6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/17947516b0095c51da5cff94771247f2e7c44ee6"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}