)]}'
{"devstack/lib/scope.sh":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4bea7147182ee84ebc41e25eb73cc44f0a998d3f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    iniset $KEYSTONE_CONF oslo_policy enforce_scope true"},{"line_number":17,"context_line":"    iniset $KEYSTONE_CONF oslo_policy policy_file policy.yaml"},{"line_number":18,"context_line":"    sudo systemctl restart devstack@keystone"},{"line_number":19,"context_line":"    oslopolicy-policy-generator --namespace keystone \u003e /etc/keystone/policy.yaml"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function configure_protection_tests {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_fbdc7372","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":80},"updated":"2019-12-18 21:55:21.000000000","message":"We don\u0027t want to use the defaults? Or is this so that we don\u0027t apply the logical OR for deprecated policies?","commit_id":"71ee705e78b9487e999ec21c46b82a162c568942"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ce4788268b104f6a6ffd9ec3f8d7414e937d514c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    iniset $KEYSTONE_CONF oslo_policy enforce_scope true"},{"line_number":17,"context_line":"    iniset $KEYSTONE_CONF oslo_policy policy_file policy.yaml"},{"line_number":18,"context_line":"    sudo systemctl restart devstack@keystone"},{"line_number":19,"context_line":"    oslopolicy-policy-generator --namespace keystone \u003e /etc/keystone/policy.yaml"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function configure_protection_tests {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_fb0c21ec","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":80},"in_reply_to":"3fa7e38b_b66822f4","updated":"2020-01-02 15:25:51.000000000","message":"++ thanks for the clarifying.","commit_id":"71ee705e78b9487e999ec21c46b82a162c568942"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2b75c950cfc4a9a49c5664997edfe087a377aeaf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    iniset $KEYSTONE_CONF oslo_policy enforce_scope true"},{"line_number":17,"context_line":"    iniset $KEYSTONE_CONF oslo_policy policy_file policy.yaml"},{"line_number":18,"context_line":"    sudo systemctl restart devstack@keystone"},{"line_number":19,"context_line":"    oslopolicy-policy-generator --namespace keystone \u003e /etc/keystone/policy.yaml"},{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function configure_protection_tests {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_b66822f4","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":80},"in_reply_to":"3fa7e38b_fbdc7372","updated":"2019-12-23 18:03:30.000000000","message":"This is so we don\u0027t use the deprecated policies.","commit_id":"71ee705e78b9487e999ec21c46b82a162c568942"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0e179b139eaccececd45456b4a3e8c2a071d4eb9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"function configure_enforce_scope {"},{"line_number":16,"context_line":"    iniset $KEYSTONE_CONF oslo_policy enforce_scope true"},{"line_number":17,"context_line":"    iniset $KEYSTONE_CONF oslo_policy policy_file policy.yaml"},{"line_number":18,"context_line":"    sudo systemctl restart devstack@keystone"},{"line_number":19,"context_line":"    oslopolicy-policy-generator --namespace keystone \u003e /etc/keystone/policy.yaml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_3d8e3878","line":16,"updated":"2020-10-29 17:46:14.000000000","message":"Should we also opt into the new defaults?\n\n  iniset $KEYSTONE_CONF oslo_policy enforce_new_defaults true\n\nIIRC - this would make line 19 unnecessary.\n\nhttps://docs.openstack.org/keystone/latest/configuration/config-options.html#oslo_policy.enforce_new_defaults","commit_id":"5d7c92e20463fb2ba9a508789b8e2d5a3ce78f0f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f69f28aaf601fa2a639f8d23e91bd8d5022a770a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"function configure_enforce_scope {"},{"line_number":16,"context_line":"    iniset $KEYSTONE_CONF oslo_policy enforce_scope true"},{"line_number":17,"context_line":"    iniset $KEYSTONE_CONF oslo_policy policy_file policy.yaml"},{"line_number":18,"context_line":"    sudo systemctl restart devstack@keystone"},{"line_number":19,"context_line":"    oslopolicy-policy-generator --namespace keystone \u003e /etc/keystone/policy.yaml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_5d54d4ca","line":16,"in_reply_to":"1f621f24_3d8e3878","updated":"2020-10-29 17:49:22.000000000","message":"I didn\u0027t know this option existed, I think I wrote this before it existed. I would prefer to get this merged first and revise later.","commit_id":"5d7c92e20463fb2ba9a508789b8e2d5a3ce78f0f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"05e3798f3f68e3a4cdbf779495ce69c301cb638f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"function configure_enforce_scope {"},{"line_number":16,"context_line":"    iniset $KEYSTONE_CONF oslo_policy enforce_scope true"},{"line_number":17,"context_line":"    iniset $KEYSTONE_CONF oslo_policy policy_file policy.yaml"},{"line_number":18,"context_line":"    sudo systemctl restart devstack@keystone"},{"line_number":19,"context_line":"    oslopolicy-policy-generator --namespace keystone \u003e /etc/keystone/policy.yaml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_fd2040b3","line":16,"in_reply_to":"1f621f24_5d54d4ca","updated":"2020-10-29 18:31:46.000000000","message":"Sounds good - I threw up a patch.\n\nhttps://review.opendev.org/#/c/760441/","commit_id":"5d7c92e20463fb2ba9a508789b8e2d5a3ce78f0f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"05e3798f3f68e3a4cdbf779495ce69c301cb638f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function configure_protection_tests {"},{"line_number":23,"context_line":"    iniset $TEMPEST_CONFIG identity-feature-enabled enforce_scope true"},{"line_number":24,"context_line":"    iniset $TEMPEST_CONFIG auth admin_system true"},{"line_number":25,"context_line":"    iniset $TEMPEST_CONFIG auth admin_project_name \u0027\u0027"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_7d50b033","line":24,"range":{"start_line":24,"start_character":45,"end_line":24,"end_character":49},"updated":"2020-10-29 18:31:46.000000000","message":"According to the tempest config help text, this should be either \u0027all\u0027 or None. Does this work with True?\n\nhttps://review.opendev.org/#/c/686073/8/tempest/config.py,unified","commit_id":"5d7c92e20463fb2ba9a508789b8e2d5a3ce78f0f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d62b4e7a3de4efb69ca768b2f5eb9690c8716645","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function configure_protection_tests {"},{"line_number":23,"context_line":"    iniset $TEMPEST_CONFIG identity-feature-enabled enforce_scope true"},{"line_number":24,"context_line":"    iniset $TEMPEST_CONFIG auth admin_system true"},{"line_number":25,"context_line":"    iniset $TEMPEST_CONFIG auth admin_project_name \u0027\u0027"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_9d6dc79a","line":24,"range":{"start_line":24,"start_character":45,"end_line":24,"end_character":49},"in_reply_to":"1f621f24_130d2d3e","updated":"2020-10-30 01:46:05.000000000","message":"Cool - I rolled that into 760441","commit_id":"5d7c92e20463fb2ba9a508789b8e2d5a3ce78f0f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"89701e83a285101776a861390a3026cc8284f1b5","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function configure_protection_tests {"},{"line_number":23,"context_line":"    iniset $TEMPEST_CONFIG identity-feature-enabled enforce_scope true"},{"line_number":24,"context_line":"    iniset $TEMPEST_CONFIG auth admin_system true"},{"line_number":25,"context_line":"    iniset $TEMPEST_CONFIG auth admin_project_name \u0027\u0027"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1f621f24_130d2d3e","line":24,"range":{"start_line":24,"start_character":45,"end_line":24,"end_character":49},"in_reply_to":"1f621f24_7d50b033","updated":"2020-10-29 21:21:26.000000000","message":"It technically works but you\u0027re right it should be \u0027all\u0027","commit_id":"5d7c92e20463fb2ba9a508789b8e2d5a3ce78f0f"}]}
