)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d805c596b5a33774210147ae5586aaf796d3a1b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix token auth error if federated_groups_id is empty list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"`federation_group_ids` could be zero length list, so deciding weather"},{"line_number":10,"context_line":"a token is federated by checking if it is none."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0f4b9e24d949aa4838ee721a165999b29c684d32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_2b029673","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":69},"updated":"2019-12-22 13:26:50.000000000","message":"whether?","commit_id":"bf5d2594006ba3705fbc58e6797d1f43d280b428"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"3f1782e1afe3343e80ed5fc26b9b8822d0a2399d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix token auth error if federated_groups_id is empty list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"`federation_group_ids` could be zero length list, so deciding weather"},{"line_number":10,"context_line":"a token is federated by checking if it is none."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0f4b9e24d949aa4838ee721a165999b29c684d32"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_618d0d7b","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":69},"in_reply_to":"3fa7e38b_2b029673","updated":"2019-12-23 04:00:07.000000000","message":"done","commit_id":"bf5d2594006ba3705fbc58e6797d1f43d280b428"}],"keystone/tests/unit/token/test_fernet_provider.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d805c596b5a33774210147ae5586aaf796d3a1b8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual(idp_id, token.identity_provider_id)"},{"line_number":137,"context_line":"        self.assertEqual(protocol, token.protocol_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_validate_v3_token_federated_info(self):"},{"line_number":140,"context_line":"        # Check the user fields in the token result when use validate_v3_token"},{"line_number":141,"context_line":"        # when the token has federated info."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        group_ids \u003d [uuid.uuid4().hex, ]"},{"line_number":144,"context_line":"        self._test_validate_v3_token_federted_info(group_ids)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_validate_v3_token_federated_info_empty_group(self):"},{"line_number":147,"context_line":"        # Check the user fields in the token result when use validate_v3_token"},{"line_number":148,"context_line":"        # when the token has federated info."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self._test_validate_v3_token_federted_info([])"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_validate_v3_token_trust(self):"},{"line_number":153,"context_line":"        # Check the trust fields in the token result when use validate_v3_token"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4b059278","line":150,"range":{"start_line":139,"start_character":0,"end_line":150,"end_character":54},"updated":"2019-12-22 13:26:50.000000000","message":"can you combine these two testcase into one?  maybe something like \n\ngroup_ids \u003d [uuid.uuid4().hex, []] is enough?","commit_id":"bf5d2594006ba3705fbc58e6797d1f43d280b428"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"3f1782e1afe3343e80ed5fc26b9b8822d0a2399d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual(idp_id, token.identity_provider_id)"},{"line_number":137,"context_line":"        self.assertEqual(protocol, token.protocol_id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_validate_v3_token_federated_info(self):"},{"line_number":140,"context_line":"        # Check the user fields in the token result when use validate_v3_token"},{"line_number":141,"context_line":"        # when the token has federated info."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        group_ids \u003d [uuid.uuid4().hex, ]"},{"line_number":144,"context_line":"        self._test_validate_v3_token_federted_info(group_ids)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_validate_v3_token_federated_info_empty_group(self):"},{"line_number":147,"context_line":"        # Check the user fields in the token result when use validate_v3_token"},{"line_number":148,"context_line":"        # when the token has federated info."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self._test_validate_v3_token_federted_info([])"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_validate_v3_token_trust(self):"},{"line_number":153,"context_line":"        # Check the trust fields in the token result when use validate_v3_token"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_61466d53","line":150,"range":{"start_line":139,"start_character":0,"end_line":150,"end_character":54},"in_reply_to":"3fa7e38b_4b059278","updated":"2019-12-23 04:00:07.000000000","message":"I am afraid not. the last test case is used test when group id is empty","commit_id":"bf5d2594006ba3705fbc58e6797d1f43d280b428"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d805c596b5a33774210147ae5586aaf796d3a1b8","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        )"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class TestValidateWithoutCache(TestValidate):"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def config_overrides(self):"},{"line_number":219,"context_line":"        super(TestValidateWithoutCache, self).config_overrides()"},{"line_number":220,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, caching\u003dFalse)"},{"line_number":221,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, cache_on_issue\u003dFalse)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"class TestTokenFormatter(unit.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ebfb1e78","line":221,"range":{"start_line":216,"start_character":0,"end_line":221,"end_character":71},"updated":"2019-12-22 13:26:50.000000000","message":"does this has anything to do with the change here?","commit_id":"bf5d2594006ba3705fbc58e6797d1f43d280b428"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"3f1782e1afe3343e80ed5fc26b9b8822d0a2399d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        )"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class TestValidateWithoutCache(TestValidate):"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def config_overrides(self):"},{"line_number":219,"context_line":"        super(TestValidateWithoutCache, self).config_overrides()"},{"line_number":220,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, caching\u003dFalse)"},{"line_number":221,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, cache_on_issue\u003dFalse)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"class TestTokenFormatter(unit.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_414c9174","line":221,"range":{"start_line":216,"start_character":0,"end_line":221,"end_character":71},"in_reply_to":"3fa7e38b_ebfb1e78","updated":"2019-12-23 04:00:07.000000000","message":"this test case is added intentionally for when cache is disabled. test case should succeed regardless of cache enabled or not.","commit_id":"bf5d2594006ba3705fbc58e6797d1f43d280b428"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"61a38b8fe550923380903a2c531b94ef575a8629","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self._test_validate_v3_token_federted_info(group_ids)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_validate_v3_token_federated_info_empty_group(self):"},{"line_number":147,"context_line":"        # Check the user fields in the token result when use validate_v3_token"},{"line_number":148,"context_line":"        # when the token has federated info."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self._test_validate_v3_token_federted_info([])"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_61550d1e","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":44},"updated":"2019-12-23 07:15:09.000000000","message":"you might want differentiate the comment here with above.","commit_id":"3fd3192028a15854997984a321e55dacce01a386"}]}
