)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6627d583b38abcf8e4f7918b2ac02db5bcd0a22a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add rules to be a required field for mapping schema"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As the summary says, previously in schema would have validated"},{"line_number":10,"context_line":"a mapping that had no rules key. This patch enforces that a rules"},{"line_number":11,"context_line":"key be present."},{"line_number":12,"context_line":"I also removed the `name` key from a fixture, note that the name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUH%2F96Nc%3D","line":9,"updated":"2014-02-01 16:20:01.000000000","message":"Remove \"As the summary says\"\n\nOtherwise, this sentence still doesn\u0027t make sense. \"in schema something would have\" ??","commit_id":"3831cbcd5f9cba362c3c48a634b843c54048b57c"}],"keystone/contrib/federation/utils.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e76f777bdfd39e5943a1707cddc87db25d31d57e","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MAPPING_SCHEMA \u003d {"},{"line_number":24,"context_line":"    \"type\": \"object\","},{"line_number":25,"context_line":"    \"required\": [\u0027rules\u0027],"},{"line_number":26,"context_line":"    \"properties\": {"},{"line_number":27,"context_line":"        \"rules\": {"},{"line_number":28,"context_line":"            \"minItems\": 1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F980s%3D","line":25,"updated":"2014-01-31 18:42:33.000000000","message":"\"additionalProperties\": False ?","commit_id":"8412c3e3b43c879dd3baff15d37c4eb1eea0c6c0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"658e2119a0299bf1a2b2c39e08a9954ff35ec47b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MAPPING_SCHEMA \u003d {"},{"line_number":24,"context_line":"    \"type\": \"object\","},{"line_number":25,"context_line":"    \"required\": [\u0027rules\u0027],"},{"line_number":26,"context_line":"    \"properties\": {"},{"line_number":27,"context_line":"        \"rules\": {"},{"line_number":28,"context_line":"            \"minItems\": 1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F98lw%3D","line":25,"in_reply_to":"AAAAUH%2F980s%3D","updated":"2014-01-31 19:30:54.000000000","message":"I thought about that, but just in case \u0027id\u0027 is coming in, too.\nSo I figured it was OK to leave additionalProps out this time.","commit_id":"8412c3e3b43c879dd3baff15d37c4eb1eea0c6c0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e3c513e39aca6168ba5a26922c60234bae734770","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MAPPING_SCHEMA \u003d {"},{"line_number":24,"context_line":"    \"type\": \"object\","},{"line_number":25,"context_line":"    \"required\": [\u0027rules\u0027],"},{"line_number":26,"context_line":"    \"properties\": {"},{"line_number":27,"context_line":"        \"rules\": {"},{"line_number":28,"context_line":"            \"minItems\": 1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9z9g%3D","line":25,"in_reply_to":"AAAAUH%2F98lw%3D","updated":"2014-02-03 18:02:19.000000000","message":"I actually like the suggestion.  I\u0027m pretty sure you can set additionalProperties to False and let id be an optional property.  I would err on being overly strict because it\u0027s usually more backward compatible to remove restrictions than to add them.","commit_id":"8412c3e3b43c879dd3baff15d37c4eb1eea0c6c0"}],"keystone/tests/test_v3_federation.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"282ab11720e2519d871d6514dc69a7dbe482c62d","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    def test_create_mapping_empty_map(self):"},{"line_number":564,"context_line":"        url \u003d self.MAPPING_URL + uuid.uuid4().hex"},{"line_number":565,"context_line":"        self.put(url, expected_status\u003d400,"},{"line_number":566,"context_line":"                 body\u003d{\u0027mapping\u0027: {}})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9yQM%3D","line":566,"updated":"2014-02-03 23:33:19.000000000","message":"would be nice if could prove that the failure was because \"rules\" was missing... e.g., something in the response... or call a function directly that\u0027s able to indicate what was missing.","commit_id":"e40ba40307e125b3d1d333de2cbb0433a26a1c5a"}]}