)]}'
{"id":"openstack%2Fkeystone~704726","triplet_id":"openstack%2Fkeystone~stable%2Fstein~Icfce3b14abb55c6fef3de1b314cee22fc8b1d08c","project":"openstack/keystone","branch":"stable/stein","topic":"assignment-role-filtering-stable-stein","hashtags":[],"change_id":"Icfce3b14abb55c6fef3de1b314cee22fc8b1d08c","subject":"Fix role_assignments role.id filter","status":"MERGED","created":"2020-01-29 05:02:50.000000000","updated":"2020-01-29 21:48:03.000000000","submitted":"2020-01-29 21:45:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"704726-1580334320425-46a14a57","meta_rev_id":"43a1e909d02793645d7aafaafc2b3c145063bb3f","_number":704726,"virtual_id_number":704726,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-29 21:45:20.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":2,"date":"2020-01-29 16:33:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":1,"date":"2020-01-29 16:35:21.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-29 16:33:37.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2020-01-29 21:45:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8d9db70b1279e04380ca44aa5618396bc41825c5","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-01-29 05:02:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"881b836d41b4db28b7120dce0d301ea415f529be","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 06:32:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1f17b4858b354ea884806689c7138bd6 : SUCCESS in 25m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/96a37c27bdde49f288ce012a28672bc7 : SUCCESS in 30m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/22275069a598426486efd0f0e68173c4 : SUCCESS in 7m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a39b8c3d91c841e0a18f62b7031f29a1 : SUCCESS in 26m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f2fe68e63468443984e923afd33dc63c : SUCCESS in 28m 54s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ff6facb8f77c405d92f842105a34d66f : SUCCESS in 23m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3724d5a2f1fb40d1ab323e011afcdba3 : SUCCESS in 9m 20s\n- tempest-full https://zuul.opendev.org/t/openstack/build/ed5e81667fa84536a7248fe3bf2f88a4 : SUCCESS in 1h 28m 25s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/9f2debccc8c047778c552770ae9c9fc8 : SUCCESS in 1h 01m 22s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/1ea32f82bfd245b58431306e6eed8d48 : SUCCESS in 49m 53s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/890216559b5f46b8823374aecd4aa25a : SUCCESS in 1h 15m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1b7e420676da4216bc989f36a389dcb5 : SUCCESS in 16m 25s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/455a04983e154de3bc82b648eb2cd19d : SUCCESS in 29m 47s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/dade49d3e8fb49df869606f52dc89be5 : SUCCESS in 39m 30s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/fad8ed78f5394b869d02422cbdf99252 : FAILURE in 31m 37s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/e6c06560c5174514be27260680bfc213 : FAILURE in 32m 00s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/e6bd5b0b586048f8a27c611ae1e59cf0 : SUCCESS in 13m 55s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/6c169e52a16d4bd5919fecbef5fe48bb : SUCCESS in 36m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"44d659868a62c61463a73ec79342c3ca851aab29","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2020-01-29 16:33:37.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9bb6f478ef2fb27763f3b1e8bb3b77cd836d365a","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-01-29 16:35:21.000000000","message":"Patch Set 1: Workflow+1\n\npushing through since proposed by stable core","accounts_in_message":[],"_revision_number":1},{"id":"9ff66d691a139878a2c8a62175242933f7672f52","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 16:35:41.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c98d1c949ba684f4a34867969a49a93ede3f665f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 21:45:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a77ac4c5904d472588d9bc25328e432a : SUCCESS in 35m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/01715ed0ea2e480e9cb43e8f87b1148b : SUCCESS in 9m 33s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2a4a83c579204f68bf1e89c886e42274 : SUCCESS in 26m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0c05fc63ebd54b869da9e286a2dea547 : SUCCESS in 31m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e26673566c6345798fef1240d0f0d66b : SUCCESS in 27m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ab26064757ab40aca660f871cd6ba3fd : SUCCESS in 11m 31s\n- tempest-full https://zuul.opendev.org/t/openstack/build/ba48a23d3a9b4170935400aef6a44a94 : SUCCESS in 1h 28m 24s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/d9709d031c474160a9348a0d63db1bd8 : SUCCESS in 57m 48s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/311ba5446b3840b99484c8e9a08c5762 : SUCCESS in 1h 08m 27s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/545604fa80a248769103a51c519e03a2 : SUCCESS in 1h 23m 15s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d91790a1e09d44b3882eb2a90a865991 : SUCCESS in 15m 49s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/d9958405c20f4e9f8c88d79ce57018c9 : SUCCESS in 36m 26s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/5ccb8684d4134320bbf890efd0ba93cb : SUCCESS in 57m 04s","accounts_in_message":[],"_revision_number":1},{"id":"929d5f8a1d742df952a9417878cf22320076ec8b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 21:45:20.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"df92fbdf124ff811a9bc3e1e6509d5c57d75e4b0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 21:48:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c120a96b8341417bb1a856e13e0c3e36 : SUCCESS in 1m 20s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e6b1eb6bfd324a939b4ce1ce5e72bfc6 : SUCCESS in 2m 17s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"af470fd6394af9758a277f05744dd4544bac09e5","revisions":{"af470fd6394af9758a277f05744dd4544bac09e5":{"kind":"REWORK","_number":1,"created":"2020-01-29 05:02:50.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/26/704726/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/26/704726/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/26/704726/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/26/704726/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/26/704726/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/26/704726/1"}}},"commit":{"parents":[{"commit":"5ad8a33d5a43c3d3e63f434c10223d9f42070e0e","subject":"Merge \"Docs: Make robust with using real links\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/5ad8a33d5a43c3d3e63f434c10223d9f42070e0e"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.com","date":"2020-01-01 00:22:34.000000000","tz":-480},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2020-01-29 05:02:57.000000000","tz":-480},"subject":"Fix role_assignments role.id filter","message":"Fix role_assignments role.id filter\n\nWithout this patch, if there are multiple role assignments on the system\nand they are not all the same role, querying for role assignments with\n/v3/role_assignments?role.id\u003d{role_id} may leak some role assignments\nthat don\u0027t match the role_id, making the returned results incorrect.\nThis patch fixes the issue by using a list comprehension instead of a\nfor loop over a list that was being modified within the loop.\n\nChange-Id: Icfce3b14abb55c6fef3de1b314cee22fc8b1d08c\nCloses-bug: #1858012\n(cherry picked from commit c2d88306621f890a857acd6831ea8bf073f55537)\n(cherry picked from commit 4d413f1eba2d1e6b16ecd57fa27de528dd0f67cb)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/af470fd6394af9758a277f05744dd4544bac09e5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/af470fd6394af9758a277f05744dd4544bac09e5"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
