)]}'
{"keystone/tests/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"55740b954ecc28086f383bfa9df25a81fd985f5e","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        standardMsg \u003d \u0027\\n\u0027.join(lines)"},{"line_number":620,"context_line":"        self.fail(self._formatMessage(msg, standardMsg))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def new_ref(self):"},{"line_number":623,"context_line":"        \"\"\"Populates a ref with attributes common to all API entities.\"\"\""},{"line_number":624,"context_line":"        return {"},{"line_number":625,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F96K0%3D","line":622,"updated":"2014-02-01 16:45:24.000000000","message":"is there any reason these need to be in tests.TestCase? If not, move them out.","commit_id":"03c431dcd18162f42613ec5081f9a9d2d0d1b574"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"267d42c165575f90f18e91ebfbafb9d95ba362f5","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        standardMsg \u003d \u0027\\n\u0027.join(lines)"},{"line_number":620,"context_line":"        self.fail(self._formatMessage(msg, standardMsg))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def new_ref(self):"},{"line_number":623,"context_line":"        \"\"\"Populates a ref with attributes common to all API entities.\"\"\""},{"line_number":624,"context_line":"        return {"},{"line_number":625,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9zmw%3D","line":622,"in_reply_to":"AAAAUH%2F96K0%3D","updated":"2014-02-03 19:04:45.000000000","message":"I believe they need to be in tests.TestCase.\n\nOther test_v3_classes (and others) extend test_v3.RestfulTestCase -\u003e rest.RestfulTestCase -\u003e test.TestCase. \n\nAs I don\u0027t think many import tests.core, I would have to go in and change each one?","commit_id":"03c431dcd18162f42613ec5081f9a9d2d0d1b574"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7b13fe9e1907dda3669ff54385b47e02f8cf1a26","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        standardMsg \u003d \u0027\\n\u0027.join(lines)"},{"line_number":620,"context_line":"        self.fail(self._formatMessage(msg, standardMsg))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def new_ref(self):"},{"line_number":623,"context_line":"        \"\"\"Populates a ref with attributes common to all API entities.\"\"\""},{"line_number":624,"context_line":"        return {"},{"line_number":625,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9x3Y%3D","line":622,"in_reply_to":"AAAAUH%2F9x5U%3D","updated":"2014-02-04 01:45:27.000000000","message":"Since these aren\u0027t actually tests, they probably don\u0027t belong in a test_*.py file at all... how about utility_v3.py ?\n\nI\u0027m not a fan of Mixins in general, so I\u0027d suggest don\u0027t make it a mixin.","commit_id":"03c431dcd18162f42613ec5081f9a9d2d0d1b574"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b7158543f29e82a944a539eb4a2c7b401dd70652","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        standardMsg \u003d \u0027\\n\u0027.join(lines)"},{"line_number":620,"context_line":"        self.fail(self._formatMessage(msg, standardMsg))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def new_ref(self):"},{"line_number":623,"context_line":"        \"\"\"Populates a ref with attributes common to all API entities.\"\"\""},{"line_number":624,"context_line":"        return {"},{"line_number":625,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9x5U%3D","line":622,"in_reply_to":"AAAAUH%2F9yEU%3D","updated":"2014-02-04 01:35:40.000000000","message":"Dolph brought up a good point that these are v3 entities, and maybe this class isn\u0027t the best spot for the change. \n\nHow about leaving this in test_v3, but putting them in their own class, like MockResources? \n\nHave test_v3.RestulfulTestCase extend the new MockResources. \n\nThen exploit mixin, have the stuff that doesn\u0027t need a wsgi server, like test_auth and test_catalog extend both MockResources and TestCase?\n\nMaybe I\u0027m off the mark.","commit_id":"03c431dcd18162f42613ec5081f9a9d2d0d1b574"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"79627d8063b45ad417e1d487ebd55348f0d672bf","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        standardMsg \u003d \u0027\\n\u0027.join(lines)"},{"line_number":620,"context_line":"        self.fail(self._formatMessage(msg, standardMsg))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    def new_ref(self):"},{"line_number":623,"context_line":"        \"\"\"Populates a ref with attributes common to all API entities.\"\"\""},{"line_number":624,"context_line":"        return {"},{"line_number":625,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9yEU%3D","line":622,"in_reply_to":"AAAAUH%2F9zmw%3D","updated":"2014-02-04 00:29:51.000000000","message":"If we\u0027re going to do this then I think we should do it right -- there\u0027s too much in this class already, and this is an abuse of inheritance.","commit_id":"03c431dcd18162f42613ec5081f9a9d2d0d1b574"}]}