)]}'
{"id":"openstack%2Fkeystone~708255","triplet_id":"openstack%2Fkeystone~master~I6953f2404f79d004939d4a4fcd114f11bd83b773","project":"openstack/keystone","branch":"master","topic":"req-fix","hashtags":[],"change_id":"I6953f2404f79d004939d4a4fcd114f11bd83b773","subject":"Check if content-type contains http, not equals","status":"MERGED","created":"2020-02-17 21:04:13.000000000","updated":"2020-02-18 23:18:21.000000000","submitted":"2020-02-18 23:16:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"708255-1582067777670-5f1f21a0","meta_rev_id":"2c20e382bc2664cf72a93f9660588396c1613f48","_number":708255,"virtual_id_number":708255,"owner":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"date":"2020-02-18 05:42:42.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-18 23:16:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"all":[{"value":2,"date":"2020-02-18 14:32:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":1,"date":"2020-02-18 10:45:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":2,"date":"2020-02-18 17:18:01.000000000","_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":1,"date":"2020-02-18 17:18:01.000000000","_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-18 10:45:06.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2020-02-18 14:32:22.000000000","updated_by":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"},{"updated":"2020-02-18 17:18:01.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2020-02-18 23:16:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1ff0a8fd2b024c0d85e148327c63b5a924a01981","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-02-17 21:04:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a38c3bcee787c378c59c73de2bd48d5d33bcd8e","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-02-17 21:06:17.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2ff29a324d08c1272c3922c4cf2132f34790be76","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-17 23:37:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5492214d4c17472da40c049ed241a867 : SUCCESS in 18m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/19d71bb8829b4d52a09b98fc9cac7c33 : SUCCESS in 16m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ea2837f693e9431e92ba9115b96d8b20 : SUCCESS in 8m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e2b9e5c4ae2f4b218dc2795cea1ed397 : SUCCESS in 22m 51s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bd915388193e40909ed68cf8d29d3140 : SUCCESS in 23m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f68d2adbb4da498ab55c0e4e66223f16 : SUCCESS in 21m 42s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c229ba834c2449b8b40c7c6f0b434774 : SUCCESS in 15m 45s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/7ad6a648e4db4cf9993ee8d551172ce5 : SUCCESS in 46m 08s","accounts_in_message":[],"_revision_number":2},{"id":"eb518a40f8824a387704bbe6f91ce308de517ff8","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2020-02-18 05:36:29.000000000","message":"Patch Set 2:\n\nAny specific reason for this change?","accounts_in_message":[],"_revision_number":2},{"id":"d14288df28fa88d7566fc1d5b60e6c78e21e86f6","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-02-18 05:42:42.000000000","message":"Patch Set 2:\n\n\u003e Any specific reason for this change?\n\nShould fix the test failures from the reqs update here: https://review.opendev.org/#/c/707064/","accounts_in_message":[],"_revision_number":2},{"id":"e2607436b847609141872cba1ea9226e13ed540a","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2020-02-18 10:45:06.000000000","message":"Patch Set 2: Code-Review+1\n\nI can see its a fix for the test case failing here [1]. LGTM\n\n[1] https://41e8f9738ccc4ce30bc0-e0419d2da2313928ed85c22410bb6c0a.ssl.cf5.rackcdn.com/707064/11/check/cross-keystone-py36/d071784/testr_results.html","accounts_in_message":[],"_revision_number":2},{"id":"b07287745e14288a9d02672aca52e2c927d8ac59","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2020-02-18 14:32:22.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"1fdf4c3cf0555f38cb53aec0c0b5b012b673c526","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2020-02-18 17:18:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bbcf6d9d7fb845be2273862376bdc877c2ce4edb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-18 17:18:52.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"cbe9051d32c77db6e957f749c45048b0d018bf92","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-18 23:16:17.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7475e0c5d60f4869aa186cf68e155d89 : SUCCESS in 17m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/23cd5a95c1ce4a0aad28ed31b2fedd8c : SUCCESS in 8m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3fcb06c987864d669518c78ace9aa2cd : SUCCESS in 22m 03s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b03696356eb7413eb2a49010939227cc : SUCCESS in 23m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a8ad72dd3d9e43eaa38dbe1216f545ab : SUCCESS in 17m 10s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/53666296c7c8450b914d48f07a9f6051 : SUCCESS in 37m 44s","accounts_in_message":[],"_revision_number":2},{"id":"cfa3c2bccafb4058bd55787e44bb850c7bb1401a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-18 23:16:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"ba8dc400bce95bf78cdf0c2600be87fe0cec0b59","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-18 23:18:21.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f9f61cee028f4879bf642743ea0e3856 : SUCCESS in 1m 40s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5544bca8ea48f77e9ac3a76d84f194e0ec24b883","revisions":{"fbbe28cd92d49536991b968443bb8162bd8c19ce":{"kind":"REWORK","_number":1,"created":"2020-02-17 21:04:13.000000000","uploader":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"ref":"refs/changes/55/708255/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/55/708255/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/708255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/708255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/708255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/55/708255/1"}}},"commit":{"parents":[{"commit":"b3cbf60c3c764bd9e0cf6168156e5de71c081449","subject":"Merge \"Default to bootstrapping roles as immutable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b3cbf60c3c764bd9e0cf6168156e5de71c081449"}]}],"author":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2020-02-17 21:00:38.000000000","tz":-360},"committer":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2020-02-17 21:00:38.000000000","tz":-360},"subject":"Change unit test to check in rather than equals","message":"Change unit test to check in rather than equals\n\nThis change modifies the unit test for checking if the response is\nan html error. Rather than checking for equality, just check that\nthe content type contains text/html.\n\nChange-Id: I6953f2404f79d004939d4a4fcd114f11bd83b773\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/fbbe28cd92d49536991b968443bb8162bd8c19ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/fbbe28cd92d49536991b968443bb8162bd8c19ce"}]},"branch":"refs/heads/master"},"5544bca8ea48f77e9ac3a76d84f194e0ec24b883":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-02-17 21:06:17.000000000","uploader":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"ref":"refs/changes/55/708255/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/55/708255/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/708255/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/708255/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/708255/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/55/708255/2"}}},"commit":{"parents":[{"commit":"b3cbf60c3c764bd9e0cf6168156e5de71c081449","subject":"Merge \"Default to bootstrapping roles as immutable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b3cbf60c3c764bd9e0cf6168156e5de71c081449"}]}],"author":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2020-02-17 21:00:38.000000000","tz":-360},"committer":{"name":"Gage Hugo","email":"gagehugo@gmail.com","date":"2020-02-17 21:06:13.000000000","tz":0},"subject":"Check if content-type contains http, not equals","message":"Check if content-type contains http, not equals\n\nThis change modifies the unit test for checking if the response is\nan html error. Rather than checking for equality, just check that\nthe content type contains text/html.\n\nChange-Id: I6953f2404f79d004939d4a4fcd114f11bd83b773\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/5544bca8ea48f77e9ac3a76d84f194e0ec24b883"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/5544bca8ea48f77e9ac3a76d84f194e0ec24b883"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}