)]}'
{"id":"openstack%2Fkeystone~711743","triplet_id":"openstack%2Fkeystone~stable%2Ftrain~I22f3bce647182996dfc06084ee6d4989449e3d2d","project":"openstack/keystone","branch":"stable/train","topic":"implement-yoctozepto-ldap-fix-todos-stable/train","hashtags":[],"change_id":"I22f3bce647182996dfc06084ee6d4989449e3d2d","subject":"Refactor some ldap code to implement TODOs","status":"MERGED","created":"2020-03-06 19:16:36.000000000","updated":"2020-05-19 18:25:20.000000000","submitted":"2020-05-19 18:22:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"711743-1589912573591-df490097","meta_rev_id":"a47cbcef58291ef86243f0ea9f256d56318c9a40","_number":711743,"virtual_id_number":711743,"owner":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-19 18:22:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-03-06 19:16:53.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":2,"date":"2020-05-19 15:37:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":2,"date":"2020-03-10 20:14:40.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":1,"date":"2020-05-19 15:37:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-10 20:14:40.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2020-05-19 15:37:44.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2020-05-19 18:22:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a593b54ac9f9736c86abc3dfe3edb90cdb2b0b45","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-03-06 19:16:36.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"b711075b52e394d3d61ee77ccb7e3c7bd2e1e893","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-03-06 19:16:53.000000000","message":"Patch Set 1:\n\nclean backport here","accounts_in_message":[],"_revision_number":1},{"id":"8cc95fd22ef0aa0c91e51906d484431c9db81f08","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-06 21:54:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7876549f9bcd403895457b00d194c4af : SUCCESS in 17m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f69d9536fdc94e1dac35202d80af3a2b : SUCCESS in 28m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8bfc75638b08430daaa0e61eaeada801 : SUCCESS in 9m 34s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d868ed2da9944ee38a9e085e69c8dd98 : SUCCESS in 13m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b03939b32c334be4b747a0edf2f28533 : SUCCESS in 14m 49s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7f71b39460514e99825dde234ba3b991 : SUCCESS in 17m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/452cdfded15a4d248cfc4334dcd8db62 : SUCCESS in 25m 16s\n- tempest-full https://zuul.opendev.org/t/openstack/build/4fde45157dff4eb38f15dcdde5727323 : SUCCESS in 2h 07m 29s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/e4ddbe69836849a0a64f622091c2d81d : SUCCESS in 1h 06m 01s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d022787f10774a2eafc47cab51fdc601 : SUCCESS in 1h 05m 45s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d4a3be81f23f4872ac9e8b38e78a2b2d : SUCCESS in 1h 24m 31s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/7181b32f983a4d00b10f3876bf03723f : SUCCESS in 33m 49s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/3192657fc15344dca33e1de40b678567 : SUCCESS in 34m 03s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/d0dc3a21cd134cd28cb70586bb7962c0 : SUCCESS in 36m 03s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/8be55a6e2435456b838babf718a2fd21 : SUCCESS in 42m 47s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/3b5f22050a7e471782332cab09047af1 : SUCCESS in 47m 59s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/2108fd9f1b464795823f8369e8c4e0e3 : SUCCESS in 20m 49s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/faf915c595f2499a8c0b21a99cf35277 : SUCCESS in 41m 46s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/011b64a631234a439dd0f27f061542fb : SUCCESS in 1h 10m 38s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/a11272247cc54156b6a7ae23cc38be94 : SUCCESS in 44m 20s","accounts_in_message":[],"_revision_number":1},{"id":"7c496db17279e48418a9e7423f24a8f9cef66169","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-03-10 20:14:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"725e5a2d4da06c0dfbabe16b7ff6df06692c66e1","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2020-03-10 20:14:59.000000000","message":"Patch Set 1:\n\nLooks like a clean backport","accounts_in_message":[],"_revision_number":1},{"id":"5eabd73ad54abfcf12d5f4ce3116b249acebdb24","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2020-05-19 15:37:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a686e5f5967fa0c44958fb02f9f9b6aa1bf9988e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-19 15:38:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5bdfbea8aec88b3686625df5dde00f168286a26d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-19 18:22:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0acac3fab02c43f5b5ac1f801b4e56ca : SUCCESS in 14m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cfa3f54eb3ee43b18eb9e52cc2064714 : SUCCESS in 10m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5ce1f429ca5649a0aba4ccd691c86cb2 : SUCCESS in 30m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f67caec12d82408c872a48220b43c5e5 : SUCCESS in 30m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9f286ecbfa734b239d93e0c0e9a3d3b7 : SUCCESS in 26m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4d4a05a4ac6a4e7d8f4d361554bc10c7 : SUCCESS in 14m 04s\n- tempest-full https://zuul.opendev.org/t/openstack/build/d75f6accd84f4a39b548d8386ae3780c : SUCCESS in 1h 42m 29s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/0465386b8ca44875a3f0f2730dc06e8d : SUCCESS in 1h 01m 05s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/27f29bc520654863bfd58c064fd5d331 : SUCCESS in 1h 35m 35s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/cd11ed23e1ab41bf8cf52e0069176ce0 : SUCCESS in 44m 22s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/52dd0c78dd014e0584735e8af266f580 : SUCCESS in 36m 15s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d11d88ce234e4a98a9721e99615e5d18 : SUCCESS in 57m 55s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5546f44636d34e39810b0260a5d16428 : SUCCESS in 1h 10m 27s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/75dba7e309054882ab3a7acf0e66dcb9 : SUCCESS in 53m 19s","accounts_in_message":[],"_revision_number":1},{"id":"4199dd47d8c8abbcc3e9da086b76a7956ddb8b22","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-19 18:22:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3d0fa9c6abc3e5669b16b01baf0af6366488695b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-19 18:25:20.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca2d34fcf57e46acbbdf0a91e1c26c49 : SUCCESS in 1m 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"93f548a72569bfdf323827bb05c367381c8dedfb","revisions":{"93f548a72569bfdf323827bb05c367381c8dedfb":{"kind":"REWORK","_number":1,"created":"2020-03-06 19:16:36.000000000","uploader":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"ref":"refs/changes/43/711743/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/43/711743/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/711743/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/711743/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/711743/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/43/711743/1"}}},"commit":{"parents":[{"commit":"40b7de87e04fbc49ab3a96b5114a9ab09c2734b7","subject":"Tell reno to ignore the kilo branch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/40b7de87e04fbc49ab3a96b5114a9ab09c2734b7"}]}],"author":{"name":"Radosław Piliszek","email":"radoslaw.piliszek@gmail.com","date":"2020-02-28 18:42:24.000000000","tz":60},"committer":{"name":"Radosław Piliszek","email":"radoslaw.piliszek@gmail.com","date":"2020-03-06 19:16:36.000000000","tz":0},"subject":"Refactor some ldap code to implement TODOs","message":"Refactor some ldap code to implement TODOs\n\nThis implements TODOs added in [1], as promised in [2].\nThe first TODO is realised only partially because most ldap code\nactually relies on having two connections obtained from the pool.\n\nThis optimizes mixin code by removing extra ldap calls.\nThere is no change in the observed behaviour of integration.\n\nThis also removes some duplication and refactors names to avoid\nsome confusion related to dn/object_id.\n\nBackport to: Train, Stein (with [1]\u0026[3]), Rocky (with [1]\u0026[3]),\n             Queens (with [1]\u0026[3])\n\n[1] c7fae97d873f72068ca65538ec5b5919c0ac7d5a\n[2] https://review.opendev.org/683303\n[3] 19d4831daa3991bed48fb364fa05927740c96445\n\nChange-Id: I22f3bce647182996dfc06084ee6d4989449e3d2d\n(cherry picked from commit a6bb81146ff2126f055834459f428cf97080466f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/93f548a72569bfdf323827bb05c367381c8dedfb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/93f548a72569bfdf323827bb05c367381c8dedfb"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}