)]}'
{"keystone/cmd/doctor/caching.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7eff543cc545a090254c927b34f0597156527e93","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    as dead. Please ensure `keystone.conf [cache] memcache_servers` is"},{"line_number":58,"context_line":"    configured properly."},{"line_number":59,"context_line":"    \"\"\""},{"line_number":60,"context_line":"    if CONF.cache.enabled and CONF.cache.backend \u003d\u003d \u0027dogpile.cache.memcached\u0027:"},{"line_number":61,"context_line":"        cache.configure_cache()"},{"line_number":62,"context_line":"        cache_stats \u003d cache.CACHE_REGION.actual_backend.client.get_stats()"},{"line_number":63,"context_line":"        memcached_server_count \u003d len(CONF.cache.memcache_servers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_75ff1434","line":60,"range":{"start_line":60,"start_character":53,"end_line":60,"end_character":76},"updated":"2020-07-02 20:48:35.000000000","message":"What about oslo_cache.memcache_pool?","commit_id":"2bcc40628c0a37958c2d49260220c95bbefee950"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2772004a8ef6c4aa60b9d5d9a393e07bab4961c6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    as dead. Please ensure `keystone.conf [cache] memcache_servers` is"},{"line_number":58,"context_line":"    configured properly."},{"line_number":59,"context_line":"    \"\"\""},{"line_number":60,"context_line":"    if CONF.cache.enabled and CONF.cache.backend \u003d\u003d \u0027dogpile.cache.memcached\u0027:"},{"line_number":61,"context_line":"        cache.configure_cache()"},{"line_number":62,"context_line":"        cache_stats \u003d cache.CACHE_REGION.actual_backend.client.get_stats()"},{"line_number":63,"context_line":"        memcached_server_count \u003d len(CONF.cache.memcache_servers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_59a30ab2","line":60,"range":{"start_line":60,"start_character":53,"end_line":60,"end_character":76},"in_reply_to":"bf51134e_75ff1434","updated":"2020-07-06 19:08:56.000000000","message":"Done","commit_id":"2bcc40628c0a37958c2d49260220c95bbefee950"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7eff543cc545a090254c927b34f0597156527e93","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        memcached_server_count \u003d len(CONF.cache.memcache_servers)"},{"line_number":64,"context_line":"        if len(cache_stats) !\u003d memcached_server_count:"},{"line_number":65,"context_line":"            return True"},{"line_number":66,"context_line":"    else:"},{"line_number":67,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_d591c0f3","line":67,"range":{"start_line":66,"start_character":4,"end_line":67,"end_character":20},"updated":"2020-07-02 20:48:35.000000000","message":"This is redundant and inconsistent with the conditional on line 64, either this should be removed so it returns None or another return False should be added for the inner case on line 64 so that it\u0027s always returning either True or False and not None","commit_id":"2bcc40628c0a37958c2d49260220c95bbefee950"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2772004a8ef6c4aa60b9d5d9a393e07bab4961c6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        memcached_server_count \u003d len(CONF.cache.memcache_servers)"},{"line_number":64,"context_line":"        if len(cache_stats) !\u003d memcached_server_count:"},{"line_number":65,"context_line":"            return True"},{"line_number":66,"context_line":"    else:"},{"line_number":67,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_d98efa30","line":67,"range":{"start_line":66,"start_character":4,"end_line":67,"end_character":20},"in_reply_to":"bf51134e_d591c0f3","updated":"2020-07-06 19:08:56.000000000","message":"Good catch. I\u0027ll explicitly return False in the conditional above since it appears we always return booleans in symptoms.","commit_id":"2bcc40628c0a37958c2d49260220c95bbefee950"}],"releasenotes/notes/bug-1332058-f25e2de40411b711.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8e8200439c16c5898ae1d94c96445d997d56b7d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1332058 \u003chttps://bugs.launchpad.net/keystone/+bug/1332058\u003e`_]"},{"line_number":5,"context_line":"    ``keystone-manage doctor`` now checks that keystone can establish"},{"line_number":6,"context_line":"    connections to Memcached, if configured."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_a4410b3c","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":17},"updated":"2020-06-23 17:44:35.000000000","message":"I\u0027m not sure if this is the best bug to associate this to, but I know we\u0027ve had several bugs about memcached configuration. I didn\u0027t want to open up another bug just for reporting this enhancement.\n\nI\u0027m open to suggestions here.","commit_id":"2bcc40628c0a37958c2d49260220c95bbefee950"}]}