)]}'
{"keystone/middleware/swift_auth.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2f7a7fdcfa9c17a746b7ee03316d4deb813215b8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # authentication"},{"line_number":115,"context_line":"        if (self.allow_overrides and"},{"line_number":116,"context_line":"            environ.get(\u0027swift.authorize_override\u0027, False)):"},{"line_number":117,"context_line":"            msg \u003d \u0027Authorizing from a middleware overriding (ie: tempurl)\u0027"},{"line_number":118,"context_line":"            self.logger.debug(msg)"},{"line_number":119,"context_line":"            return self.app(environ, start_response)"},{"line_number":120,"context_line":"        elif identity:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7kU%3D","line":117,"updated":"2012-05-15 19:22:06.000000000","message":"a middleware overriding \u003d\u003e an overriding middleware\n\nie: tempurl -\u003e i.e. tempurl","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4e3530ed088b9b103634dc0996b42d705fe4aec2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # authentication"},{"line_number":115,"context_line":"        if (self.allow_overrides and"},{"line_number":116,"context_line":"            environ.get(\u0027swift.authorize_override\u0027, False)):"},{"line_number":117,"context_line":"            msg \u003d \u0027Authorizing from a middleware overriding (ie: tempurl)\u0027"},{"line_number":118,"context_line":"            self.logger.debug(msg)"},{"line_number":119,"context_line":"            return self.app(environ, start_response)"},{"line_number":120,"context_line":"        elif identity:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7W4%3D","line":117,"in_reply_to":"AAAAHX%2F%2F7kU%3D","updated":"2012-05-16 06:13:28.000000000","message":"Done","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2f7a7fdcfa9c17a746b7ee03316d4deb813215b8","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            msg \u003d \u0027Authorizing from a middleware overriding (ie: tempurl)\u0027"},{"line_number":118,"context_line":"            self.logger.debug(msg)"},{"line_number":119,"context_line":"            return self.app(environ, start_response)"},{"line_number":120,"context_line":"        elif identity:"},{"line_number":121,"context_line":"            self.logger.debug(\u0027Using identity: %r\u0027 % (identity))"},{"line_number":122,"context_line":"            environ[\u0027keystone.identity\u0027] \u003d identity"},{"line_number":123,"context_line":"            environ[\u0027REMOTE_USER\u0027] \u003d identity.get(\u0027tenant\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7kQ%3D","line":120,"updated":"2012-05-15 19:22:06.000000000","message":"Consider leaving this as an if statement since the previous conditional is unrelated to this one.","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4e3530ed088b9b103634dc0996b42d705fe4aec2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            msg \u003d \u0027Authorizing from a middleware overriding (ie: tempurl)\u0027"},{"line_number":118,"context_line":"            self.logger.debug(msg)"},{"line_number":119,"context_line":"            return self.app(environ, start_response)"},{"line_number":120,"context_line":"        elif identity:"},{"line_number":121,"context_line":"            self.logger.debug(\u0027Using identity: %r\u0027 % (identity))"},{"line_number":122,"context_line":"            environ[\u0027keystone.identity\u0027] \u003d identity"},{"line_number":123,"context_line":"            environ[\u0027REMOTE_USER\u0027] \u003d identity.get(\u0027tenant\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7W0%3D","line":120,"in_reply_to":"AAAAHX%2F%2F7kQ%3D","updated":"2012-05-16 06:13:28.000000000","message":"Done","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"}],"tests/test_swift_auth_middleware.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2f7a7fdcfa9c17a746b7ee03316d4deb813215b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def setUpModule(self):"},{"line_number":28,"context_line":"    self.stubs \u003d stubout.StubOutForTesting()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Stub out swift_utils.get_logger.  get_logger tries to configure"},{"line_number":31,"context_line":"    # syslogging to \u0027/dev/log\u0027, which will fail on OS X."},{"line_number":32,"context_line":"    def fake_get_logger(config, log_route\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7kw%3D","line":29,"updated":"2012-05-15 19:22:06.000000000","message":"Unrelated formatting change","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"275e2268e2fb409ff0481accab4a941e7299d3a4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def setUpModule(self):"},{"line_number":28,"context_line":"    self.stubs \u003d stubout.StubOutForTesting()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Stub out swift_utils.get_logger.  get_logger tries to configure"},{"line_number":31,"context_line":"    # syslogging to \u0027/dev/log\u0027, which will fail on OS X."},{"line_number":32,"context_line":"    def fake_get_logger(config, log_route\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7Ek%3D","line":29,"in_reply_to":"AAAAHX%2F%2F7IU%3D","updated":"2012-05-16 17:03:39.000000000","message":"I\u0027m more afraid of the opposite scenario: non-functional changes grouped up with a functional change that doesn\u0027t belong.","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"42c1a8042a2856d5e10da461e4d208135b1cda03","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def setUpModule(self):"},{"line_number":28,"context_line":"    self.stubs \u003d stubout.StubOutForTesting()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Stub out swift_utils.get_logger.  get_logger tries to configure"},{"line_number":31,"context_line":"    # syslogging to \u0027/dev/log\u0027, which will fail on OS X."},{"line_number":32,"context_line":"    def fake_get_logger(config, log_route\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7IU%3D","line":29,"in_reply_to":"AAAAHX%2F%2F7W8%3D","updated":"2012-05-16 16:33:08.000000000","message":"I know what the intent is, but the best practice would be to commit unrelated non-functional changes in a separate patch.  It\u0027s up to the keystone core reviewers whether they care, though.","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4e3530ed088b9b103634dc0996b42d705fe4aec2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def setUpModule(self):"},{"line_number":28,"context_line":"    self.stubs \u003d stubout.StubOutForTesting()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Stub out swift_utils.get_logger.  get_logger tries to configure"},{"line_number":31,"context_line":"    # syslogging to \u0027/dev/log\u0027, which will fail on OS X."},{"line_number":32,"context_line":"    def fake_get_logger(config, log_route\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7W8%3D","line":29,"in_reply_to":"AAAAHX%2F%2F7kw%3D","updated":"2012-05-16 06:13:28.000000000","message":"That\u0027s a PEP8 fix.","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2f7a7fdcfa9c17a746b7ee03316d4deb813215b8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                 exception\u003dwebob.exc.HTTPForbidden)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_authorize_succeeds_for_reseller_admin(self):"},{"line_number":182,"context_line":"        roles \u003d [self.test_auth.reseller_admin_role]"},{"line_number":183,"context_line":"        identity \u003d self._get_identity(roles\u003droles)"},{"line_number":184,"context_line":"        req \u003d self._check_authenticate(identity\u003didentity)"},{"line_number":185,"context_line":"        self.assertTrue(req.environ.get(\u0027swift_owner\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7ks%3D","line":182,"updated":"2012-05-15 19:22:06.000000000","message":"Unrelated formatting change","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4e3530ed088b9b103634dc0996b42d705fe4aec2","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                 exception\u003dwebob.exc.HTTPForbidden)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_authorize_succeeds_for_reseller_admin(self):"},{"line_number":182,"context_line":"        roles \u003d [self.test_auth.reseller_admin_role]"},{"line_number":183,"context_line":"        identity \u003d self._get_identity(roles\u003droles)"},{"line_number":184,"context_line":"        req \u003d self._check_authenticate(identity\u003didentity)"},{"line_number":185,"context_line":"        self.assertTrue(req.environ.get(\u0027swift_owner\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAHX%2F%2F7XA%3D","line":182,"in_reply_to":"AAAAHX%2F%2F7ks%3D","updated":"2012-05-16 06:13:28.000000000","message":"PEP8 fix.","commit_id":"88cb708bf7f7251ea93e3fa428541dc219c60342"}]}