)]}'
{"keystone/identity/backends/ldap/core.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"db053b375ecd05e54dbef753a7959fecb3699181","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                        group_dn},"},{"line_number":444,"context_line":"                    attrlist\u003d[self.member_attribute])"},{"line_number":445,"context_line":"                attrs +\u003d self._ldap_get_list(group_dn, ldap.SCOPE_BASE,"},{"line_number":446,"context_line":"                                   attrlist\u003d[self.member_attribute])"},{"line_number":447,"context_line":"            else:"},{"line_number":448,"context_line":"                attrs \u003d self._ldap_get_list(group_dn, ldap.SCOPE_BASE,"},{"line_number":449,"context_line":"                                            attrlist\u003d[self.member_attribute])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_680f3de1","line":446,"updated":"2020-10-15 18:25:27.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"c135e708a808fac79e22e4a12576b9269caf5a24"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"7b43efce202c8d691017f7e276d7285a876351d9","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                        group_dn},"},{"line_number":444,"context_line":"                    attrlist\u003d[self.member_attribute])"},{"line_number":445,"context_line":"                attrs +\u003d self._ldap_get_list(group_dn, ldap.SCOPE_BASE,"},{"line_number":446,"context_line":"                                             attrlist\u003d[self.member_attribute])"},{"line_number":447,"context_line":"            else:"},{"line_number":448,"context_line":"                attrs \u003d self._ldap_get_list(group_dn, ldap.SCOPE_BASE,"},{"line_number":449,"context_line":"                                            attrlist\u003d[self.member_attribute])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_3e3be69c","line":446,"updated":"2020-10-21 13:36:26.000000000","message":"iiuc the lines 441 to 443 filter the previous resoulg by group_dn, so I don\u0027t think that we were going to have a different result by requesting the get_list using group_dn as the base_dn.\n\nAlso, would be nice to have some unit tests, so we can take this doubts out with a better test result.","commit_id":"8e6d464deccce49cc41319440345e322b5999edb"},{"author":{"_account_id":29466,"name":"snecklifter","email":"snecklifter@gmail.com","username":"snecker"},"change_message_id":"3396515dee3b153bc85e1ae3c666b01e1e71791e","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                        group_dn},"},{"line_number":444,"context_line":"                    attrlist\u003d[self.member_attribute])"},{"line_number":445,"context_line":"                attrs +\u003d self._ldap_get_list(group_dn, ldap.SCOPE_BASE,"},{"line_number":446,"context_line":"                                             attrlist\u003d[self.member_attribute])"},{"line_number":447,"context_line":"            else:"},{"line_number":448,"context_line":"                attrs \u003d self._ldap_get_list(group_dn, ldap.SCOPE_BASE,"},{"line_number":449,"context_line":"                                            attrlist\u003d[self.member_attribute])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_0d47d41f","line":446,"in_reply_to":"3f65232a_3e3be69c","updated":"2020-10-22 10:40:21.000000000","message":"The difference in the result is returning users which are not nested as well as users that are. I have updated the commit message to reflect this.","commit_id":"8e6d464deccce49cc41319440345e322b5999edb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"e69c403552994505b9f04c6c123eb5e445c1aeda","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                attrs \u003d self._ldap_get_list("},{"line_number":440,"context_line":"                    self.tree_dn, self.LDAP_SCOPE,"},{"line_number":441,"context_line":"                    query_params\u003d{"},{"line_number":442,"context_line":"                        \"memberOf:%s:\" % LDAP_MATCHING_RULE_IN_CHAIN:"},{"line_number":443,"context_line":"                        group_dn},"},{"line_number":444,"context_line":"                    attrlist\u003d[self.member_attribute])"},{"line_number":445,"context_line":"                attrs +\u003d self._ldap_get_list(group_dn, ldap.SCOPE_BASE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_7d2a9e7e","line":442,"range":{"start_line":442,"start_character":25,"end_line":442,"end_character":33},"updated":"2020-11-16 23:08:56.000000000","message":"I don\u0027t think it\u0027s correct to hardcode this attribute name, I\u0027m guessing it should probably come from the configurable group_member_attribute name: https://docs.openstack.org/keystone/latest/configuration/config-options.html#ldap.group_member_attribute","commit_id":"b9393f43ea5db1cb086105afd029b1b2f97d1b6d"}]}