)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6771,"name":"tiago-martins","email":"tiago.ferraz@gmail.com","username":"tiago-martins"},"change_message_id":"e3cd85d826211bae9c3a456362d3a305818f6ac3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enforce required parameters for V3 Regions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating regions without \u0027description\u0027 specified in the request,"},{"line_number":10,"context_line":"it is possible to recieve an exception from the backend, such as a MySQL"},{"line_number":11,"context_line":"error \u0027Column \"impersonation\" cannot be null\u0027. This check should be"},{"line_number":12,"context_line":"handled in the controllers so that the behavior is consistent across all"},{"line_number":13,"context_line":"backends."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAWH%2F%2FUx0%3D","line":10,"updated":"2014-03-18 16:06:06.000000000","message":"receive","commit_id":"6e9dce6a6198520a18ff4215825a78bc6e5f6fc7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c5bb9a859fe577103f41bbf20564ee5a3cd52e40","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enforce required parameters for V3 Regions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating regions without \u0027description\u0027 specified in the request,"},{"line_number":10,"context_line":"it is possible to recieve an exception from the backend, such as a MySQL"},{"line_number":11,"context_line":"error \u0027Column \"impersonation\" cannot be null\u0027. This check should be"},{"line_number":12,"context_line":"handled in the controllers so that the behavior is consistent across all"},{"line_number":13,"context_line":"backends."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAWH%2F%2FMOE%3D","line":10,"in_reply_to":"AAAAWH%2F%2FUx0%3D","updated":"2014-03-19 15:32:27.000000000","message":"Done","commit_id":"6e9dce6a6198520a18ff4215825a78bc6e5f6fc7"}],"keystone/catalog/controllers.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"ef31fa028ffa4d6f7db5d3d643367673181d8ed3","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    _mutable_parameters \u003d frozenset([\u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":145,"context_line":"    _public_parameters \u003d frozenset([\u0027id\u0027, \u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":146,"context_line":"    _required_parameters \u003d frozenset([\u0027description\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @controller.protected()"},{"line_number":149,"context_line":"    def create_region_with_id(self, context, region_id, region):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Fh8Q%3D","line":146,"updated":"2014-03-05 15:33:51.000000000","message":"description should be optional","commit_id":"9fe1d6d6ca494dc077d8ab5543b3d58d7508e41d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c7835ef5d7b0b8b8cb18efcf3b3f7fa10edd9813","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    _mutable_parameters \u003d frozenset([\u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":145,"context_line":"    _public_parameters \u003d frozenset([\u0027id\u0027, \u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":146,"context_line":"    _required_parameters \u003d frozenset([\u0027description\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @controller.protected()"},{"line_number":149,"context_line":"    def create_region_with_id(self, context, region_id, region):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FcWw%3D","line":146,"in_reply_to":"AAAAVn%2F%2FcbQ%3D","updated":"2014-03-06 02:16:26.000000000","message":"Thinking we will need a migration to fix this... thought?","commit_id":"9fe1d6d6ca494dc077d8ab5543b3d58d7508e41d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f975475cdc7c60c3f468d18aab62d527342078c4","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    _mutable_parameters \u003d frozenset([\u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":145,"context_line":"    _public_parameters \u003d frozenset([\u0027id\u0027, \u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":146,"context_line":"    _required_parameters \u003d frozenset([\u0027description\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @controller.protected()"},{"line_number":149,"context_line":"    def create_region_with_id(self, context, region_id, region):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FcbQ%3D","line":146,"in_reply_to":"AAAAVn%2F%2FcdY%3D","updated":"2014-03-06 02:07:31.000000000","message":"https://github.com/openstack/keystone/blob/master/keystone/common/sql/migrate_repo/versions/037_add_region_table.py#L27","commit_id":"9fe1d6d6ca494dc077d8ab5543b3d58d7508e41d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5fa43a8ae82adc3308b46a4a47af38d4107110f9","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    _mutable_parameters \u003d frozenset([\u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":145,"context_line":"    _public_parameters \u003d frozenset([\u0027id\u0027, \u0027parent_region_id\u0027, \u0027description\u0027])"},{"line_number":146,"context_line":"    _required_parameters \u003d frozenset([\u0027description\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @controller.protected()"},{"line_number":149,"context_line":"    def create_region_with_id(self, context, region_id, region):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FcdY%3D","line":146,"in_reply_to":"AAAAVn%2F%2Fh8Q%3D","updated":"2014-03-06 02:01:35.000000000","message":"Makes sense according to  the identity V3 API: https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#regions-v3regions\n\nbut sending a create request without any parameters or description results in the following: \n\nhttp://paste.openstack.org/show/72738/\n\nSQL fails out because the description column is NULL.\n\nSo, I think we should probably make the impl work to fit what the API spec details.","commit_id":"9fe1d6d6ca494dc077d8ab5543b3d58d7508e41d"}]}