)]}'
{"etc/keystone.conf.sample":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"ddde3d50f2515f48791660d9f8695acc0febdf19","unresolved":false,"context_lines":[{"line_number":575,"context_line":"#driver\u003dkeystone.credential.backends.sql.Credential"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"[database]"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"#"},{"line_number":581,"context_line":"# Options defined in keystone.openstack.common.db.options"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7adec928_59ec968f","side":"PARENT","line":578,"updated":"2014-05-16 14:35:47.000000000","message":"these options should not be removed from config","commit_id":"3ca5ce43773549eed2d2ad3863966a1a95cdf3b6"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"680b8cc9571424099ea03588e4dc1e91691b5b4b","unresolved":false,"context_lines":[{"line_number":575,"context_line":"#driver\u003dkeystone.credential.backends.sql.Credential"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"[database]"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"#"},{"line_number":581,"context_line":"# Options defined in keystone.openstack.common.db.options"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7adec928_b7e5a139","side":"PARENT","line":578,"in_reply_to":"7adec928_59ec968f","updated":"2014-05-16 15:31:13.000000000","message":"Any recommendations to use tools/config/generate_sample.sh ?","commit_id":"3ca5ce43773549eed2d2ad3863966a1a95cdf3b6"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e3276b8627929eb824210fe41dd8a0bb49d23f4b","unresolved":false,"context_lines":[{"line_number":309,"context_line":"#"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"# The file name to use with SQLite (string value)"},{"line_number":312,"context_line":"#sqlite_db\u003doslo.sqlite"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"# If True, SQLite uses synchronous mode (boolean value)"},{"line_number":315,"context_line":"#sqlite_synchronous\u003dtrue"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7adec928_07d5eae3","line":312,"updated":"2014-05-20 09:03:51.000000000","message":"these option was moved to the \"database\" group, and the new version of oslo.db was not uploaded to pypi, unfortunately. Please, use oslo.db code from master for now.","commit_id":"82085bad4142c83f560589137338628279866ede"}],"keystone/tests/ksfixtures/database.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"be11f860efd4078592af53e169598cdfeddccf0e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            shutil.copyfile(pristine, db)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@run_once"},{"line_number":63,"context_line":"def initialize_sql_session():"},{"line_number":64,"context_line":"    # Make sure the DB is located in the correct location, in this case set"},{"line_number":65,"context_line":"    # the default value, as this should be able to be overridden in some"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_14cf78b4","side":"PARENT","line":62,"updated":"2014-06-17 16:56:24.000000000","message":"could you please clarify this change?","commit_id":"b6843ded671ffe859d8cb254acc696a475af73cf"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"03da00c82727b6ccd576f540b8809ea607a98fc5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            shutil.copyfile(pristine, db)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@run_once"},{"line_number":63,"context_line":"def initialize_sql_session():"},{"line_number":64,"context_line":"    # Make sure the DB is located in the correct location, in this case set"},{"line_number":65,"context_line":"    # the default value, as this should be able to be overridden in some"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_c1760ba3","side":"PARENT","line":62,"in_reply_to":"1ae5cdf2_085ad829","updated":"2014-06-18 10:10:05.000000000","message":"I\u0027m sorry, I was wrong.\n\nEarlier in oslo.db.options we used oslo.config `set_defaults` https://github.com/vikt0rs/oslo.db/blob/master/oslo/db/options.py#L140 method which has no cleanup mechanism https://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L558. A modern version of oslo.db uses `register_opts` method https://github.com/openstack/oslo.db/blob/master/oslo/db/options.py#L143 which has cleanup mechanism https://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L1729 https://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L1588.\n\nSo every execution all the options will be cleared. And we must set options at every fixture initialization, not just once.","commit_id":"b6843ded671ffe859d8cb254acc696a475af73cf"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"dd88273a85cf76cf3e746e81d692b901111a9b41","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            shutil.copyfile(pristine, db)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@run_once"},{"line_number":63,"context_line":"def initialize_sql_session():"},{"line_number":64,"context_line":"    # Make sure the DB is located in the correct location, in this case set"},{"line_number":65,"context_line":"    # the default value, as this should be able to be overridden in some"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_d51409a1","side":"PARENT","line":62,"in_reply_to":"1ae5cdf2_14cf78b4","updated":"2014-06-18 08:39:43.000000000","message":"`set_defaults` from oslo.db `options` module takes config instance to set default options in it, not global config object, so `connection` must be set every time when the fixture is initialized, not once. Do we need this clarification in the commit message or comments in the code snippet?","commit_id":"b6843ded671ffe859d8cb254acc696a475af73cf"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"6005d79b7eb442daf6a4fdc25aa7c99cc41c1404","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            shutil.copyfile(pristine, db)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@run_once"},{"line_number":63,"context_line":"def initialize_sql_session():"},{"line_number":64,"context_line":"    # Make sure the DB is located in the correct location, in this case set"},{"line_number":65,"context_line":"    # the default value, as this should be able to be overridden in some"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_085ad829","side":"PARENT","line":62,"in_reply_to":"1ae5cdf2_d51409a1","updated":"2014-06-18 08:50:20.000000000","message":"But we still pass the global CONF instance, so it shouldn\u0027t be any different, right? There must be an explanation, but unfortunately I can\u0027t give you one right off the top of my head :(","commit_id":"b6843ded671ffe859d8cb254acc696a475af73cf"},{"author":{"_account_id":11717,"name":"Ryan Oshima","email":"ryan.oshima@hp.com","username":"RyanOshima"},"change_message_id":"1490679036ccc96224f58089cc770ee76a789e2a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# NOTE(I159): Every execution all the options will be cleared. The method must"},{"line_number":63,"context_line":"# be called at the every fixture initialization."},{"line_number":64,"context_line":"def initialize_sql_session():"},{"line_number":65,"context_line":"    # Make sure the DB is located in the correct location, in this case set"},{"line_number":66,"context_line":"    # the default value, as this should be able to be overridden in some"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ae5cdf2_be0d5a91","line":63,"updated":"2014-06-19 16:25:09.000000000","message":"*at every\"*","commit_id":"4c4bf4c29d096cd8d0eeb6c3cf28aacf232fa10b"}],"keystone/tests/test_backend_sql.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cbf6236079439a5f562703f227e9571c612356f3","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        self.assertRaises(KeyError, FakeTable().lookup)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"class SqlModuleInitialization(tests.TestCase):"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    @mock.patch.object(sql.core, \u0027CONF\u0027)"},{"line_number":532,"context_line":"    @mock.patch.object(options, \u0027set_defaults\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_fc96e192","line":529,"updated":"2014-06-20 18:37:49.000000000","message":"This still isn\u0027t used. Move adding to a separate commit after this one.","commit_id":"8db9ba790696c5572a8fce3be913f05fa391c491"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c7c5727866a2f994e5bb7617337af15a52973a85","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        self.assertRaises(KeyError, FakeTable().lookup)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"class SqlModuleInitialization(tests.TestCase):"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    @mock.patch.object(sql.core, \u0027CONF\u0027)"},{"line_number":532,"context_line":"    @mock.patch.object(options, \u0027set_defaults\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1ae5cdf2_3ce209a0","line":529,"in_reply_to":"1ae5cdf2_fc96e192","updated":"2014-06-20 18:55:25.000000000","message":"Never mind, I thought this was a base class for a different test.","commit_id":"8db9ba790696c5572a8fce3be913f05fa391c491"}]}