)]}'
{"id":"openstack%2Fkeystone~772566","triplet_id":"openstack%2Fkeystone~master~I30d013349f80c8e74c99ea8945346f8ef6ea58f1","project":"openstack/keystone","branch":"master","topic":"deprecation_warn_as_error","hashtags":[],"change_id":"I30d013349f80c8e74c99ea8945346f8ef6ea58f1","subject":"Don\u0027t error on deprecation warnings","status":"ABANDONED","created":"2021-01-26 15:56:00.000000000","updated":"2021-01-26 17:35:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6179c25e77f65b7c27c25048d7adea9e1856af2c","_number":772566,"virtual_id_number":772566,"owner":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"all":[{"value":1,"date":"2021-01-26 16:12:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-26 16:12:29.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2021-01-26 16:43:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"a10d9fe122cc5daac9076a79c2e24891af898ad0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2021-01-26 15:56:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f02db5d7a46001bd18582a81086e163915f0dc7","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2021-01-26 16:12:29.000000000","message":"Patch Set 1: Code-Review+1\n\nI see Mike actually handled this back in Oct: https://review.opendev.org/c/openstack/keystone/+/760678\n\nI\u0027m wondering if this is the right thing to do anyway though. Erroring on deprecations means that Keystone\u0027s unit tests will break anytime anyone deprecates anything. I can appreciate the desire to avoid having deprecation warnings, but breaking completely seems like it defeats the purpose of deprecation warnings. Maybe this could become a non-voting job to inform reviewers that there are deprecations without blocking everything?\n\nEither way, +1 to unblocking things.","accounts_in_message":[],"_revision_number":1},{"id":"ead68bd0bf3e38c3d3f2a2c7d9f7e49549ceb5db","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2021-01-26 16:20:41.000000000","message":"Patch Set 1:\n\nYeah, just realized that when Gerrit linked it in the merge conflicts section after I had pushed the review up.\n\nI\u0027l bring this up for discussion during today\u0027s keystone meeting.\n\n\u003e Patch Set 1: Code-Review+1\n\u003e \n\u003e I see Mike actually handled this back in Oct: https://review.opendev.org/c/openstack/keystone/+/760678\n\u003e \n\u003e I\u0027m wondering if this is the right thing to do anyway though. Erroring on deprecations means that Keystone\u0027s unit tests will break anytime anyone deprecates anything. I can appreciate the desire to avoid having deprecation warnings, but breaking completely seems like it defeats the purpose of deprecation warnings. Maybe this could become a non-voting job to inform reviewers that there are deprecations without blocking everything?\n\u003e \n\u003e Either way, +1 to unblocking things.","accounts_in_message":[],"_revision_number":1},{"id":"730ae9871e1a7f913467d10775e3a550458eac65","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-26 16:43:19.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/45c958a91e754a82862f01c39d90c589 : FAILURE in 40m 12s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/b7731bdfd58846dbb192af6c3a60eaff : FAILURE in 41m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a5c89f6906d9af6be50777c418dd0fcf2eb1b227","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-26 16:43:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/45c958a91e754a82862f01c39d90c589 : FAILURE in 40m 12s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/b7731bdfd58846dbb192af6c3a60eaff : FAILURE in 41m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6179c25e77f65b7c27c25048d7adea9e1856af2c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2021-01-26 17:35:21.000000000","message":"Abandoned\n\nAbandoned in favor of https://review.opendev.org/c/openstack/keystone/+/760678","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b010b77e11bc9fcc6af2d82747ac06d871a5f22f","revisions":{"b010b77e11bc9fcc6af2d82747ac06d871a5f22f":{"kind":"REWORK","_number":1,"created":"2021-01-26 15:56:00.000000000","uploader":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"ref":"refs/changes/66/772566/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/66/772566/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/66/772566/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/66/772566/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/66/772566/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/66/772566/1"}}},"commit":{"parents":[{"commit":"c239cc66615b41a0c09e031b3e268c82678bac12","subject":"Add openstack-python3-wallaby-jobs-arm64 job","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/c239cc66615b41a0c09e031b3e268c82678bac12"}]}],"author":{"name":"Kristi Nikolla","email":"kristi@nikolla.me","date":"2021-01-26 15:44:08.000000000","tz":-300},"committer":{"name":"Kristi Nikolla","email":"kristi@nikolla.me","date":"2021-01-26 15:55:48.000000000","tz":-300},"subject":"Don\u0027t error on deprecation warnings","message":"Don\u0027t error on deprecation warnings\n\noslo.db 8.5.0 deprecates sqlalchemy-migrate in favor of using\nalembic. Keystone doesn\u0027t support alembic yet, and since this\ndeprecation warning is causing unit tests to fail, this change\nstops treating deprecation warnings as errors until we have\nsuccesfully migrated. [0]\n\n[0]. http://eavesdrop.openstack.org/meetings/keystone/2021/keystone.2021-01-19-16.58.log.html#l-67\n\nChange-Id: I30d013349f80c8e74c99ea8945346f8ef6ea58f1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b010b77e11bc9fcc6af2d82747ac06d871a5f22f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/b010b77e11bc9fcc6af2d82747ac06d871a5f22f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}