)]}'
{"keystone/catalog/core.py":[{"author":{"_account_id":10680,"name":"Kanagaraj Manickam","username":"mkr1481","inactive":true},"change_message_id":"2053e295374fa4f197dfde4947e72310419d6cae","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # development opens for Juno. For right now, if \u0027description\u0027 is not"},{"line_number":76,"context_line":"        # provided by the user, set it to an empty string to comply with the"},{"line_number":77,"context_line":"        # Identity V3 API Regions spec."},{"line_number":78,"context_line":"        if \u0027description\u0027 not in region_ref:"},{"line_number":79,"context_line":"            region_ref[\u0027description\u0027] \u003d \"\""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            return self.driver.create_region(region_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FW6s%3D","line":78,"updated":"2014-03-06 16:50:54.000000000","message":"For some reason, if the region_ref is None, it will throw :\n\"TypeError: argument of type \u0027NoneType\u0027 is not iterable\"\n\nTo avoid this, kindly check for None.","commit_id":"143821c6968dc04dc4a8fcfae7d09f360d19c0df"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8265db173a3c3e6aee307eff4cbf414f1da43f9f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # provided by the user, set it to an empty string to comply with the"},{"line_number":77,"context_line":"        # Identity V3 API Regions spec."},{"line_number":78,"context_line":"        if \u0027description\u0027 not in region_ref:"},{"line_number":79,"context_line":"            region_ref[\u0027description\u0027] \u003d \"\""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            return self.driver.create_region(region_ref)"},{"line_number":82,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FW90%3D","line":79,"updated":"2014-03-06 16:40:37.000000000","message":"Alternately, we could set the description equal to the name?","commit_id":"143821c6968dc04dc4a8fcfae7d09f360d19c0df"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"cdc31dea6afb1d65b8aab251c8688789832e7a15","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # can not be null. So if the user doesn\u0027t pass in a description then"},{"line_number":73,"context_line":"        # set it to an empty string."},{"line_number":74,"context_line":"        if \u0027description\u0027 not in region_ref:"},{"line_number":75,"context_line":"            region_ref[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            return self.driver.create_region(region_ref)"},{"line_number":78,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BK%2FE%3D","line":75,"updated":"2014-03-28 16:37:59.000000000","message":"use the one liner\n\n  region_ref.setdefault(\u0027description\u0027, \u0027\u0027)","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d58fd3a43cd696f250da84aa1477d72d0fc575b1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # can not be null. So if the user doesn\u0027t pass in a description then"},{"line_number":73,"context_line":"        # set it to an empty string."},{"line_number":74,"context_line":"        if \u0027description\u0027 not in region_ref:"},{"line_number":75,"context_line":"            region_ref[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            return self.driver.create_region(region_ref)"},{"line_number":78,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FU8E%3D","line":75,"in_reply_to":"AAAAWH%2F%2BK%2FE%3D","updated":"2014-04-22 13:57:11.000000000","message":"Done","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9747aaf7b9f6f57327631809fe5dc271dcd8a201","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        # NOTE(lbragstad): The description column of the region database"},{"line_number":82,"context_line":"        # can not be null. So if the user doesn\u0027t pass in a description then"},{"line_number":83,"context_line":"        # set it to an empty string."},{"line_number":84,"context_line":"        region_ref.setdefault(\u0027description\u0027, \u0027\u0027)"},{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            return self.driver.create_region(region_ref)"},{"line_number":87,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCV4%3D","line":84,"updated":"2014-04-24 13:45:47.000000000","message":"the tests don\u0027t actually seem to exercise this at all as they always include an empty string description too","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"}],"keystone/tests/test_v3.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"cdc31dea6afb1d65b8aab251c8688789832e7a15","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            # that \u0027description\u0027 is an empty string, set in the"},{"line_number":657,"context_line":"            # catalog.Core.Manager"},{"line_number":658,"context_line":"            else:"},{"line_number":659,"context_line":"                self.assertEqual(\u0027\u0027, entity[\u0027description\u0027])"},{"line_number":660,"context_line":"        return entity"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    # service validation"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BK%2BI%3D","line":659,"updated":"2014-03-28 16:37:59.000000000","message":"not really a fan of the conditional here, see comment in next module","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c16ab73b06de630a1f0101d36f87c74410166a1e","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            # that \u0027description\u0027 is an empty string, set in the"},{"line_number":657,"context_line":"            # catalog.Core.Manager"},{"line_number":658,"context_line":"            else:"},{"line_number":659,"context_line":"                self.assertEqual(\u0027\u0027, entity[\u0027description\u0027])"},{"line_number":660,"context_line":"        return entity"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    # service validation"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BKBo%3D","line":659,"in_reply_to":"AAAAWH%2F%2BK%2BI%3D","updated":"2014-03-28 18:27:52.000000000","message":"Couldn\u0027t this be done with:\n    self.assertEqual(ref.get(\u0027description\u0027, \u0027\u0027), entity[\u0027description\u0027])","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d58fd3a43cd696f250da84aa1477d72d0fc575b1","unresolved":false,"context_lines":[{"line_number":656,"context_line":"            # that \u0027description\u0027 is an empty string, set in the"},{"line_number":657,"context_line":"            # catalog.Core.Manager"},{"line_number":658,"context_line":"            else:"},{"line_number":659,"context_line":"                self.assertEqual(\u0027\u0027, entity[\u0027description\u0027])"},{"line_number":660,"context_line":"        return entity"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    # service validation"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FU3E%3D","line":659,"in_reply_to":"AAAAWH%2F%2BK%2BI%3D","updated":"2014-04-22 13:57:11.000000000","message":"Done","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"}],"keystone/tests/test_v3_catalog.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"cdc31dea6afb1d65b8aab251c8688789832e7a15","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027/regions\u0027,"},{"line_number":89,"context_line":"            body\u003d{\u0027region\u0027: ref},"},{"line_number":90,"context_line":"            expected_status\u003d201)"},{"line_number":91,"context_line":"        self.assertValidRegionResponse(r, ref)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_create_region_description_uniqueness(self):"},{"line_number":94,"context_line":"        \"\"\"Call ``POST /regions`` without descriptions in the request bodies."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BK%2BU%3D","line":91,"updated":"2014-03-28 16:37:59.000000000","message":"i think i prefer brant\u0027s approach to testing this behavior, which is to have to the test set ref[\u0027description\u0027] \u003d \u0027\u0027 here, so that the assertValidRegionResponse can do a strict, non-conditional check","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d58fd3a43cd696f250da84aa1477d72d0fc575b1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027/regions\u0027,"},{"line_number":89,"context_line":"            body\u003d{\u0027region\u0027: ref},"},{"line_number":90,"context_line":"            expected_status\u003d201)"},{"line_number":91,"context_line":"        self.assertValidRegionResponse(r, ref)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_create_region_description_uniqueness(self):"},{"line_number":94,"context_line":"        \"\"\"Call ``POST /regions`` without descriptions in the request bodies."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FU3A%3D","line":91,"in_reply_to":"AAAAWH%2F%2BK%2BU%3D","updated":"2014-04-22 13:57:11.000000000","message":"Done","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c16ab73b06de630a1f0101d36f87c74410166a1e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027/regions\u0027,"},{"line_number":89,"context_line":"            body\u003d{\u0027region\u0027: ref},"},{"line_number":90,"context_line":"            expected_status\u003d201)"},{"line_number":91,"context_line":"        self.assertValidRegionResponse(r, ref)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_create_region_description_uniqueness(self):"},{"line_number":94,"context_line":"        \"\"\"Call ``POST /regions`` without descriptions in the request bodies."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2BKBE%3D","line":91,"in_reply_to":"AAAAWH%2F%2BK%2BU%3D","updated":"2014-03-28 18:27:52.000000000","message":"Either as dolph suggested this or see my comment in the previous module.","commit_id":"533dd148833abd8f25489c2907a071c329bdba3d"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9747aaf7b9f6f57327631809fe5dc271dcd8a201","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertValidRegionResponse(r, ref)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_create_region_without_description(self):"},{"line_number":93,"context_line":"        \"\"\"Call ``POST /regions`` without description in the request body.\"\"\""},{"line_number":94,"context_line":"        ref \u003d self.new_region_ref()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        ref[\u0027description\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCXA%3D","line":93,"updated":"2014-04-24 13:45:47.000000000","message":"the method name and docstr don\u0027t reflect the reality of this test - it\u0027s not testing \"without\" a description, it\u0027s testing *with* an *empty* string description","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1d0ff6e402bcc8c46fb1331a83b55da20819e36","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertValidRegionResponse(r, ref)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_create_region_without_description(self):"},{"line_number":93,"context_line":"        \"\"\"Call ``POST /regions`` without description in the request body.\"\"\""},{"line_number":94,"context_line":"        ref \u003d self.new_region_ref()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        ref[\u0027description\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCM8%3D","line":93,"in_reply_to":"AAAAXH%2F%2FCXA%3D","updated":"2014-04-24 14:08:35.000000000","message":"Done","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9747aaf7b9f6f57327631809fe5dc271dcd8a201","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertValidRegionResponse(r, ref)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_create_region_description_uniqueness(self):"},{"line_number":105,"context_line":"        \"\"\"Call ``POST /regions`` without descriptions in the request bodies."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        # NOTE(lbragstad): Make sure we can create two regions that have the"},{"line_number":108,"context_line":"        # same description."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCWg%3D","line":105,"updated":"2014-04-24 13:45:47.000000000","message":"similar comment as above","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1d0ff6e402bcc8c46fb1331a83b55da20819e36","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertValidRegionResponse(r, ref)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_create_region_description_uniqueness(self):"},{"line_number":105,"context_line":"        \"\"\"Call ``POST /regions`` without descriptions in the request bodies."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        # NOTE(lbragstad): Make sure we can create two regions that have the"},{"line_number":108,"context_line":"        # same description."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCMg%3D","line":105,"in_reply_to":"AAAAXH%2F%2FCWg%3D","updated":"2014-04-24 14:08:35.000000000","message":"Done","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9747aaf7b9f6f57327631809fe5dc271dcd8a201","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        \"\"\"Call ``POST /regions`` without descriptions in the request bodies."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        # NOTE(lbragstad): Make sure we can create two regions that have the"},{"line_number":108,"context_line":"        # same description."},{"line_number":109,"context_line":"        ref1 \u003d self.new_region_ref()"},{"line_number":110,"context_line":"        ref2 \u003d self.new_region_ref()"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCWU%3D","line":108,"updated":"2014-04-24 13:45:47.000000000","message":"that both have empty strings as descriptions?","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1d0ff6e402bcc8c46fb1331a83b55da20819e36","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        \"\"\"Call ``POST /regions`` without descriptions in the request bodies."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        # NOTE(lbragstad): Make sure we can create two regions that have the"},{"line_number":108,"context_line":"        # same description."},{"line_number":109,"context_line":"        ref1 \u003d self.new_region_ref()"},{"line_number":110,"context_line":"        ref2 \u003d self.new_region_ref()"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCJ8%3D","line":108,"in_reply_to":"AAAAXH%2F%2FCWU%3D","updated":"2014-04-24 14:08:35.000000000","message":"Done","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9747aaf7b9f6f57327631809fe5dc271dcd8a201","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        ref2 \u003d self.new_region_ref()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        ref1[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":113,"context_line":"        ref2[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp1 \u003d self.post("},{"line_number":116,"context_line":"            \u0027/regions\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCWM%3D","line":113,"updated":"2014-04-24 13:45:47.000000000","message":"a similar test to this one without descriptions in the request body at all would be nice","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1d0ff6e402bcc8c46fb1331a83b55da20819e36","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        ref2 \u003d self.new_region_ref()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        ref1[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":113,"context_line":"        ref2[\u0027description\u0027] \u003d \u0027\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        resp1 \u003d self.post("},{"line_number":116,"context_line":"            \u0027/regions\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FCJ4%3D","line":113,"in_reply_to":"AAAAXH%2F%2FCWM%3D","updated":"2014-04-24 14:08:35.000000000","message":"Done","commit_id":"10e3c5b43f873d685750576fdbb57fe5185fda67"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"a7454c9e8d3f0a1fc629722cf45fd6768c2380b0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        region_desc \u003d \u0027Some Region Description\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        ref1[\u0027description\u0027] \u003d region_desc"},{"line_number":119,"context_line":"        ref2[\u0027description\u0027] \u003d region_desc"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        resp1 \u003d self.post("},{"line_number":122,"context_line":"            \u0027/regions\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bad4c104_72aacb71","line":119,"updated":"2014-04-29 19:49:56.000000000","message":"By the test title, isn\u0027t the descriptions suppose to be unique?","commit_id":"7ca6a7cc5b8b5b5da6e5f9bf5595fff94cedb342"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"60cfdb15b43d825ca71c19a4daed667fb91be7b1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        region_desc \u003d \u0027Some Region Description\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        ref1[\u0027description\u0027] \u003d region_desc"},{"line_number":119,"context_line":"        ref2[\u0027description\u0027] \u003d region_desc"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        resp1 \u003d self.post("},{"line_number":122,"context_line":"            \u0027/regions\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_ce1da275","line":119,"in_reply_to":"9ad9bd40_2eca8e4f","updated":"2014-05-01 13:56:33.000000000","message":"Done","commit_id":"7ca6a7cc5b8b5b5da6e5f9bf5595fff94cedb342"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2b40178712221023af505f109862c35e5f9fb093","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        region_desc \u003d \u0027Some Region Description\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        ref1[\u0027description\u0027] \u003d region_desc"},{"line_number":119,"context_line":"        ref2[\u0027description\u0027] \u003d region_desc"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        resp1 \u003d self.post("},{"line_number":122,"context_line":"            \u0027/regions\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_2eca8e4f","line":119,"in_reply_to":"9ad9bd40_49ad1e88","updated":"2014-05-01 13:48:07.000000000","message":"Sounds good, will have another patch pushed up soon.","commit_id":"7ca6a7cc5b8b5b5da6e5f9bf5595fff94cedb342"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"bc545c4901a1a71d5065fd5bf2c5883a23115cac","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        region_desc \u003d \u0027Some Region Description\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        ref1[\u0027description\u0027] \u003d region_desc"},{"line_number":119,"context_line":"        ref2[\u0027description\u0027] \u003d region_desc"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        resp1 \u003d self.post("},{"line_number":122,"context_line":"            \u0027/regions\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_49ad1e88","line":119,"in_reply_to":"9ad9bd40_f125060b","updated":"2014-04-30 19:12:56.000000000","message":"++ change the method name","commit_id":"7ca6a7cc5b8b5b5da6e5f9bf5595fff94cedb342"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"89311ae6ed06d035d087b949e29c2b57f12d049a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        region_desc \u003d \u0027Some Region Description\u0027"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        ref1[\u0027description\u0027] \u003d region_desc"},{"line_number":119,"context_line":"        ref2[\u0027description\u0027] \u003d region_desc"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        resp1 \u003d self.post("},{"line_number":122,"context_line":"            \u0027/regions\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_f125060b","line":119,"in_reply_to":"bad4c104_72aacb71","updated":"2014-04-30 12:25:25.000000000","message":"Rather the name of the test should be changed, because description of the test is right","commit_id":"7ca6a7cc5b8b5b5da6e5f9bf5595fff94cedb342"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"bc545c4901a1a71d5065fd5bf2c5883a23115cac","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            expected_status\u003d201)"},{"line_number":131,"context_line":"        self.assertValidRegionResponse(resp2, ref2)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_create_regions_without_descriptions(self):"},{"line_number":134,"context_line":"        \"\"\"Call ``POST /regions`` with no description in the request bodies."},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        # NOTE(lbragstad): Make sure we can create two regions that have"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_49f27e9b","line":133,"updated":"2014-04-30 19:12:56.000000000","message":"Is this testing to make sure you can have two descriptions with an empty string?","commit_id":"7ca6a7cc5b8b5b5da6e5f9bf5595fff94cedb342"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2b40178712221023af505f109862c35e5f9fb093","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            expected_status\u003d201)"},{"line_number":131,"context_line":"        self.assertValidRegionResponse(resp2, ref2)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_create_regions_without_descriptions(self):"},{"line_number":134,"context_line":"        \"\"\"Call ``POST /regions`` with no description in the request bodies."},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        # NOTE(lbragstad): Make sure we can create two regions that have"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_4ef51282","line":133,"in_reply_to":"9ad9bd40_49f27e9b","updated":"2014-05-01 13:48:07.000000000","message":"Yes, if a user doesn\u0027t include a description when creating a region (following the identity V3 api spec for regions) we need to be able to make sure we handle that case. @dolphm wanted to handle that case in the Manger: \n\nhttps://review.openstack.org/#/c/78658/8/keystone/catalog/core.py\n\nWhere we just set description to an empty string when one isn\u0027t provided.","commit_id":"7ca6a7cc5b8b5b5da6e5f9bf5595fff94cedb342"}]}