)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"45bdfe96dfc773f6766870d0d58df6e0559fdf8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d211d51c_69e1140a","updated":"2021-12-08 16:47:42.000000000","message":"Assuming that we have test coverage to ensure that the redelegations are deleted correctly with this change it LGTM.","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"16fa293d87360181a6d12a11edad6fd73b20fb2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11d884de_bc8f39a8","updated":"2021-12-08 16:54:29.000000000","message":"Looks good to me. Chain deletion seems to be tested here https://github.com/openstack/keystone/blob/b20e5c5aa777dca0576698c1c8e002a7f71cf1e4/keystone/tests/unit/test_v3_auth.py#L4788","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"adcc66912701cf022a1f7773bd205c792c4b4833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6f49567_6aa2ffa5","updated":"2021-12-08 16:53:20.000000000","message":"Looks like this is covered by https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_v3_auth.py#L4783","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4a4a26196997c7d0d0abe9888e40b5d229303ac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e2b04ff_f7e5ab93","updated":"2021-12-08 16:53:51.000000000","message":"That said, we could implement a test to ensure the sql query is built probably, but I\u0027m fine with the existing coverage.","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"616f1326d02db03f7e0655265be7dcb16133cdc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c8576d2_5da6f168","updated":"2021-12-08 16:47:43.000000000","message":"lgtm","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"}],"keystone/trust/backends/sql.py":[{"author":{"_account_id":28326,"name":"yuezhongtao","display_name":"zhongtao yue","email":"751349974@qq.com","username":"yuezhongtao"},"change_message_id":"17f3066f78491804842368db899b2eaad3c4bdb0","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            trusts \u003d (session.query(TrustModel)."},{"line_number":178,"context_line":"                      filter_by(deleted_at\u003dNone)."},{"line_number":179,"context_line":"                      filter_by(trustor_user_id\u003dtrustor_user_id))"},{"line_number":180,"context_line":"            if redelegated_trust_id:"},{"line_number":181,"context_line":"                trusts \u003d trusts.filter_by("},{"line_number":182,"context_line":"                    redelegated_trust_id\u003dredelegated_trust_id)"},{"line_number":183,"context_line":"            return [trust_ref.to_dict() for trust_ref in trusts]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @sql.handle_conflicts(conflict_type\u003d\u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b18abead_ff0cccf3","line":182,"range":{"start_line":180,"start_character":12,"end_line":182,"end_character":62},"updated":"2021-09-08 14:32:48.000000000","message":"why not apply this filter to session.query() directly.","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"333e3cd57bf575e9e00232dffe2278b6d51eb92e","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            trusts \u003d (session.query(TrustModel)."},{"line_number":178,"context_line":"                      filter_by(deleted_at\u003dNone)."},{"line_number":179,"context_line":"                      filter_by(trustor_user_id\u003dtrustor_user_id))"},{"line_number":180,"context_line":"            if redelegated_trust_id:"},{"line_number":181,"context_line":"                trusts \u003d trusts.filter_by("},{"line_number":182,"context_line":"                    redelegated_trust_id\u003dredelegated_trust_id)"},{"line_number":183,"context_line":"            return [trust_ref.to_dict() for trust_ref in trusts]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @sql.handle_conflicts(conflict_type\u003d\u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b2e8e4ea_66c896c7","line":182,"range":{"start_line":180,"start_character":12,"end_line":182,"end_character":62},"in_reply_to":"b18abead_ff0cccf3","updated":"2021-09-16 13:10:40.000000000","message":"By doing so, i\u0027ll modify the behavior of this function.\n\nFor example: Checking trusts of a user A will not show any of his/her redelegated trusts if I add a filter_by with a None value for redelegated_trust_id.\n\nThe idea was to keep the behavior as it is for other calls and improve the search for this specific one.","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9f63c92413b812eb38547de4df4ffbba28616775","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            trusts \u003d (session.query(TrustModel)."},{"line_number":178,"context_line":"                      filter_by(deleted_at\u003dNone)."},{"line_number":179,"context_line":"                      filter_by(trustor_user_id\u003dtrustor_user_id))"},{"line_number":180,"context_line":"            if redelegated_trust_id:"},{"line_number":181,"context_line":"                trusts \u003d trusts.filter_by("},{"line_number":182,"context_line":"                    redelegated_trust_id\u003dredelegated_trust_id)"},{"line_number":183,"context_line":"            return [trust_ref.to_dict() for trust_ref in trusts]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @sql.handle_conflicts(conflict_type\u003d\u0027trust\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"13e1d54e_2d3d5b35","line":182,"range":{"start_line":180,"start_character":12,"end_line":182,"end_character":62},"in_reply_to":"b2e8e4ea_66c896c7","updated":"2021-12-08 16:42:01.000000000","message":"Make sense - but it would be nice to have a test to ensure the query is updated accordingly.","commit_id":"23477a13ab29e952a77184c5cf989ecfa175a3ab"}]}