)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"631e4e680885566cebb5d82d3bb3b9540f024ab1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"887ed9ba_c544afe1","updated":"2021-12-08 16:28:39.000000000","message":"Looks good to me, all of these options are reflected in oslo.cache.","commit_id":"f4836231e3227fb92fa6dd8ea5a887b2db1e623f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"29050243c4036f536c41f9d282993d1ab4037392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3478e7e9_a2bd397e","updated":"2021-12-08 16:27:59.000000000","message":"Looks good, I just think we need to update the release name.","commit_id":"f4836231e3227fb92fa6dd8ea5a887b2db1e623f"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"e194a3822f76a24ea3a4914b64d684eea1a28d51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c4ec66c_7a7fa97a","updated":"2021-12-08 16:28:29.000000000","message":"Perhaps worth noting that the [cache] options are prefixed by `memcache_`, but otherwise this looks good. ","commit_id":"f4836231e3227fb92fa6dd8ea5a887b2db1e623f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c45bf15e1a659cb914ac99b03b7ece6ffc29150b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bcd40c4f_dcb4b166","in_reply_to":"4c4ec66c_7a7fa97a","updated":"2021-12-08 23:33:24.000000000","message":"Makes sense. I\u0027ve updated the deprecated reason and release note to address that point.","commit_id":"f4836231e3227fb92fa6dd8ea5a887b2db1e623f"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"d60642975fe410e9a7d596ec86215d7310459f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5fab2859_eda5ff23","updated":"2021-12-10 15:16:34.000000000","message":"One nit, but otherwise LGTM","commit_id":"103c55412d599cd7b47494dd8302e53ac30a06a9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"61bd22319f196df2cfa47f260b2b301b5b0ed2e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d03f19ef_075da2c9","updated":"2021-12-09 01:18:06.000000000","message":"Updated deprecated_reason again to use the consistent explanation.","commit_id":"103c55412d599cd7b47494dd8302e53ac30a06a9"}],"keystone/conf/memcache.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"29050243c4036f536c41f9d282993d1ab4037392","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":23,"context_line":"    deprecated_reason\u003d\u0027This option has had no effect. Use ``[cache]`` options \u0027"},{"line_number":24,"context_line":"                      \u0027instead.\u0027,"},{"line_number":25,"context_line":"    deprecated_since\u003d\u0027X\u0027,"},{"line_number":26,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":27,"context_line":"Number of seconds memcached server is considered dead before it is tried again."},{"line_number":28,"context_line":"This is used by the key value store system."}],"source_content_type":"text/x-python","patch_set":3,"id":"79216290_afa43a76","line":25,"updated":"2021-12-08 16:27:59.000000000","message":"I think we can use Yoga here","commit_id":"f4836231e3227fb92fa6dd8ea5a887b2db1e623f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c45bf15e1a659cb914ac99b03b7ece6ffc29150b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":23,"context_line":"    deprecated_reason\u003d\u0027This option has had no effect. Use ``[cache]`` options \u0027"},{"line_number":24,"context_line":"                      \u0027instead.\u0027,"},{"line_number":25,"context_line":"    deprecated_since\u003d\u0027X\u0027,"},{"line_number":26,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":27,"context_line":"Number of seconds memcached server is considered dead before it is tried again."},{"line_number":28,"context_line":"This is used by the key value store system."}],"source_content_type":"text/x-python","patch_set":3,"id":"f8bd1a1e_61d9a67c","line":25,"in_reply_to":"79216290_afa43a76","updated":"2021-12-08 23:33:24.000000000","message":"Done","commit_id":"f4836231e3227fb92fa6dd8ea5a887b2db1e623f"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"d60642975fe410e9a7d596ec86215d7310459f79","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":79,"context_line":"    deprecated_reason\u003d\u0027This option has no effect. \u0027"},{"line_number":80,"context_line":"                      \u0027Configure ``keystone.conf [cache] \u0027"},{"line_number":81,"context_line":"                      \u0027pool_connection_get_timeout`` option to set the \u0027"},{"line_number":82,"context_line":"                      \u0027connection_get_timeout of memcached instead. \u0027,"},{"line_number":83,"context_line":"    deprecated_since\u003d\u0027Y\u0027,"},{"line_number":84,"context_line":"    help\u003dutils.fmt(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"327aa305_77f845c4","line":81,"range":{"start_line":81,"start_character":23,"end_line":81,"end_character":50},"updated":"2021-12-10 15:16:34.000000000","message":"Nit: missed the memcache_ on this parameter","commit_id":"103c55412d599cd7b47494dd8302e53ac30a06a9"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"99ef35b00570c98066a5ef628988f64996d47597","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":79,"context_line":"    deprecated_reason\u003d\u0027This option has no effect. \u0027"},{"line_number":80,"context_line":"                      \u0027Configure ``keystone.conf [cache] \u0027"},{"line_number":81,"context_line":"                      \u0027pool_connection_get_timeout`` option to set the \u0027"},{"line_number":82,"context_line":"                      \u0027connection_get_timeout of memcached instead. \u0027,"},{"line_number":83,"context_line":"    deprecated_since\u003d\u0027Y\u0027,"},{"line_number":84,"context_line":"    help\u003dutils.fmt(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"4b654eb2_71501f49","line":81,"updated":"2021-12-10 15:18:25.000000000","message":"nit: the prefix was added to the other options but you missed this one. can be fixed in a followup.","commit_id":"103c55412d599cd7b47494dd8302e53ac30a06a9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"245908b5e889cc3404568f76bc2dfb0e5f01c42d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":79,"context_line":"    deprecated_reason\u003d\u0027This option has no effect. \u0027"},{"line_number":80,"context_line":"                      \u0027Configure ``keystone.conf [cache] \u0027"},{"line_number":81,"context_line":"                      \u0027pool_connection_get_timeout`` option to set the \u0027"},{"line_number":82,"context_line":"                      \u0027connection_get_timeout of memcached instead. \u0027,"},{"line_number":83,"context_line":"    deprecated_since\u003d\u0027Y\u0027,"},{"line_number":84,"context_line":"    help\u003dutils.fmt(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"33274d69_f5872e0f","line":81,"range":{"start_line":81,"start_character":23,"end_line":81,"end_character":50},"in_reply_to":"327aa305_77f845c4","updated":"2021-12-12 13:56:13.000000000","message":"Done","commit_id":"103c55412d599cd7b47494dd8302e53ac30a06a9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"359a009f54b12c7966bfb0c0d4c1c3eea07e64fe","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    deprecated_for_removal\u003dTrue,"},{"line_number":79,"context_line":"    deprecated_reason\u003d\u0027This option has no effect. \u0027"},{"line_number":80,"context_line":"                      \u0027Configure ``keystone.conf [cache] \u0027"},{"line_number":81,"context_line":"                      \u0027pool_connection_get_timeout`` option to set the \u0027"},{"line_number":82,"context_line":"                      \u0027connection_get_timeout of memcached instead. \u0027,"},{"line_number":83,"context_line":"    deprecated_since\u003d\u0027Y\u0027,"},{"line_number":84,"context_line":"    help\u003dutils.fmt(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"63ed6140_178b7c07","line":81,"in_reply_to":"4b654eb2_71501f49","updated":"2021-12-12 13:56:18.000000000","message":"Done","commit_id":"103c55412d599cd7b47494dd8302e53ac30a06a9"}]}