)]}'
{"etc/keystone.conf.sample":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f6f98ca1c168a21edbc37f294784a7f9bdad325d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# Size of RPC connection pool (integer value)"},{"line_number":122,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Modules of exceptions that are permitted to be recreatedupon"},{"line_number":125,"context_line":"# receiving exception data from an rpc call. (list value)"},{"line_number":126,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":127,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAWH%2F%2Fflc%3D","line":124,"updated":"2014-03-17 15:22:05.000000000","message":"what happened here?","commit_id":"b80a06b49ab6b8bf758fc63af3396bf5c355fdf2"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0cefa7626151ae66d08226f95f74effdaab749f3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# Size of RPC connection pool (integer value)"},{"line_number":122,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Modules of exceptions that are permitted to be recreatedupon"},{"line_number":125,"context_line":"# receiving exception data from an rpc call. (list value)"},{"line_number":126,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":127,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAWH%2F%2Ffgo%3D","line":124,"in_reply_to":"AAAAWH%2F%2Fflc%3D","updated":"2014-03-17 18:17:45.000000000","message":"hmm, weird…fixed","commit_id":"b80a06b49ab6b8bf758fc63af3396bf5c355fdf2"}],"keystone/assignment/controllers.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"b7f3ccf0256f87848b2a22cc0deeceee099e2b6e","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        self._require_matching_id(project_id, project)"},{"line_number":422,"context_line":"        self._require_matching_domain_id("},{"line_number":423,"context_line":"            project_id, project, self.assignment_api.get_project)"},{"line_number":424,"context_line":"        ref \u003d self.assignment_api.update_project(project_id, project)"},{"line_number":425,"context_line":"        return ProjectV3.wrap_member(context, ref)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FgVk%3D","line":424,"updated":"2014-03-17 14:22:30.000000000","message":"I would rather see this check on the manager class, as it would not be possible to bypass.  I realize that would be a significant reworking of this patch and don\u0027t want to hold it up.  Please add a comment to that effect and I can +2","commit_id":"0bcf1337d19c1c653311c7bff2bfa9de5bf9aafe"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"4ff1f6f1667b26b5df2189412f250e8395abe99b","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        self._require_matching_id(project_id, project)"},{"line_number":422,"context_line":"        self._require_matching_domain_id("},{"line_number":423,"context_line":"            project_id, project, self.assignment_api.get_project)"},{"line_number":424,"context_line":"        ref \u003d self.assignment_api.update_project(project_id, project)"},{"line_number":425,"context_line":"        return ProjectV3.wrap_member(context, ref)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Ff50%3D","line":424,"in_reply_to":"AAAAWH%2F%2FgVk%3D","updated":"2014-03-17 14:44:44.000000000","message":"I added a comment to the common checkin \"controllers.py\" to this effect","commit_id":"0bcf1337d19c1c653311c7bff2bfa9de5bf9aafe"}],"keystone/common/config.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"77c2cc71d809513cc759ae736280824c0abac281","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                        \u0027driver, by specifying a list_limit in the \u0027"},{"line_number":111,"context_line":"                        \u0027appropriate section (e.g. [assignment]).\u0027),"},{"line_number":112,"context_line":"        cfg.BoolOpt(\u0027domain_id_immutable\u0027, default\u003dFalse,"},{"line_number":113,"context_line":"                    help\u003d\u0027Set this to True if you want to disable the \u0027"},{"line_number":114,"context_line":"                         \u0027ability for user, group and project entities \u0027"},{"line_number":115,"context_line":"                         \u0027to be moved between domains by updating their \u0027"},{"line_number":116,"context_line":"                         \u0027domain_id. This can be used to further restrict \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FkMA%3D","line":113,"updated":"2014-03-16 23:49:55.000000000","message":"(nit) change \"True\" to \"true\", see the generated help text (#domain_id_immutable\u003dfalse)","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ef4689eef0bf597c0e920958eb5080cf2939020d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                        \u0027driver, by specifying a list_limit in the \u0027"},{"line_number":111,"context_line":"                        \u0027appropriate section (e.g. [assignment]).\u0027),"},{"line_number":112,"context_line":"        cfg.BoolOpt(\u0027domain_id_immutable\u0027, default\u003dFalse,"},{"line_number":113,"context_line":"                    help\u003d\u0027Set this to True if you want to disable the \u0027"},{"line_number":114,"context_line":"                         \u0027ability for user, group and project entities \u0027"},{"line_number":115,"context_line":"                         \u0027to be moved between domains by updating their \u0027"},{"line_number":116,"context_line":"                         \u0027domain_id. This can be used to further restrict \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FiFU%3D","line":113,"in_reply_to":"AAAAWH%2F%2FkMA%3D","updated":"2014-03-17 09:35:05.000000000","message":"Done","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"}],"keystone/common/controller.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"77c2cc71d809513cc759ae736280824c0abac281","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                                    domain_scope\u003dNone):"},{"line_number":520,"context_line":"        \"\"\"Ensures the value matches the reference\u0027s Domain ID, if any.\"\"\""},{"line_number":521,"context_line":"        if CONF.domain_id_immutable and \u0027domain_id\u0027 in ref:"},{"line_number":522,"context_line":"            if domain_scope is not None:"},{"line_number":523,"context_line":"                existing_ref \u003d get_member(ref_id, domain_scope)"},{"line_number":524,"context_line":"            else:"},{"line_number":525,"context_line":"                existing_ref \u003d get_member(ref_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FkLw%3D","line":522,"updated":"2014-03-16 23:49:55.000000000","message":"rather than require a domain_scope argument and having to check it here, could pass in a functor for get_admin that adds the domain_scope when required...\n\n self._require_matching_domain_id(user_id, user,\n     functools.partial(self.identity_api.get_user, domain_scope\u003ddomain_scope))\n\nThis function and the base controller in general shouldn\u0027t have anything to do with domain_scope.","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ef4689eef0bf597c0e920958eb5080cf2939020d","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                                    domain_scope\u003dNone):"},{"line_number":520,"context_line":"        \"\"\"Ensures the value matches the reference\u0027s Domain ID, if any.\"\"\""},{"line_number":521,"context_line":"        if CONF.domain_id_immutable and \u0027domain_id\u0027 in ref:"},{"line_number":522,"context_line":"            if domain_scope is not None:"},{"line_number":523,"context_line":"                existing_ref \u003d get_member(ref_id, domain_scope)"},{"line_number":524,"context_line":"            else:"},{"line_number":525,"context_line":"                existing_ref \u003d get_member(ref_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FiFw%3D","line":522,"in_reply_to":"AAAAWH%2F%2FkLw%3D","updated":"2014-03-17 09:35:05.000000000","message":"nice!!!!!  Done.","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"}],"keystone/tests/test_v3_identity.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"77c2cc71d809513cc759ae736280824c0abac281","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        self.assertValidProjectResponse(r, ref)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def test_update_project_domain_id(self):"},{"line_number":425,"context_line":"        \"\"\"Call ``PATCH /projects/{project_id} with domain_id``.\"\"\""},{"line_number":426,"context_line":"        project \u003d self.new_project_ref(domain_id\u003dself.domain[\u0027id\u0027])"},{"line_number":427,"context_line":"        self.assignment_api.create_project(project[\u0027id\u0027], project)"},{"line_number":428,"context_line":"        project[\u0027domain_id\u0027] \u003d CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FkK4%3D","line":425,"updated":"2014-03-16 23:49:55.000000000","message":"(nit) move `` after \"/projects/{project_id}\"","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ef4689eef0bf597c0e920958eb5080cf2939020d","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        self.assertValidProjectResponse(r, ref)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def test_update_project_domain_id(self):"},{"line_number":425,"context_line":"        \"\"\"Call ``PATCH /projects/{project_id} with domain_id``.\"\"\""},{"line_number":426,"context_line":"        project \u003d self.new_project_ref(domain_id\u003dself.domain[\u0027id\u0027])"},{"line_number":427,"context_line":"        self.assignment_api.create_project(project[\u0027id\u0027], project)"},{"line_number":428,"context_line":"        project[\u0027domain_id\u0027] \u003d CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FiK8%3D","line":425,"in_reply_to":"AAAAWH%2F%2FkK4%3D","updated":"2014-03-17 09:35:05.000000000","message":"Done","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"77c2cc71d809513cc759ae736280824c0abac281","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        self.assertValidUserResponse(r, user)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def test_update_user_domain_id(self):"},{"line_number":597,"context_line":"        \"\"\"Call ``PATCH /users/{user_id} with domain_id``.\"\"\""},{"line_number":598,"context_line":"        user \u003d self.new_user_ref(domain_id\u003dself.domain[\u0027id\u0027])"},{"line_number":599,"context_line":"        self.identity_api.create_user(user[\u0027id\u0027], user)"},{"line_number":600,"context_line":"        user[\u0027domain_id\u0027] \u003d CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FkKs%3D","line":597,"updated":"2014-03-16 23:49:55.000000000","message":"(nit) move `` after \"/projects/{project_id}\"","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ef4689eef0bf597c0e920958eb5080cf2939020d","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        self.assertValidUserResponse(r, user)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    def test_update_user_domain_id(self):"},{"line_number":597,"context_line":"        \"\"\"Call ``PATCH /users/{user_id} with domain_id``.\"\"\""},{"line_number":598,"context_line":"        user \u003d self.new_user_ref(domain_id\u003dself.domain[\u0027id\u0027])"},{"line_number":599,"context_line":"        self.identity_api.create_user(user[\u0027id\u0027], user)"},{"line_number":600,"context_line":"        user[\u0027domain_id\u0027] \u003d CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FiKw%3D","line":597,"in_reply_to":"AAAAWH%2F%2FkKs%3D","updated":"2014-03-17 09:35:05.000000000","message":"Done","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"77c2cc71d809513cc759ae736280824c0abac281","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        self.assertValidGroupResponse(r, group)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def test_update_group_domain_id(self):"},{"line_number":704,"context_line":"        \"\"\"Call ``PATCH /groups/{group_id} with domain_id``.\"\"\""},{"line_number":705,"context_line":"        group \u003d self.new_group_ref(domain_id\u003dself.domain[\u0027id\u0027])"},{"line_number":706,"context_line":"        self.identity_api.create_group(group[\u0027id\u0027], group)"},{"line_number":707,"context_line":"        group[\u0027domain_id\u0027] \u003d CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FkKo%3D","line":704,"updated":"2014-03-16 23:49:55.000000000","message":"(nit) move `` after \"/projects/{project_id}\"","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ef4689eef0bf597c0e920958eb5080cf2939020d","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        self.assertValidGroupResponse(r, group)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def test_update_group_domain_id(self):"},{"line_number":704,"context_line":"        \"\"\"Call ``PATCH /groups/{group_id} with domain_id``.\"\"\""},{"line_number":705,"context_line":"        group \u003d self.new_group_ref(domain_id\u003dself.domain[\u0027id\u0027])"},{"line_number":706,"context_line":"        self.identity_api.create_group(group[\u0027id\u0027], group)"},{"line_number":707,"context_line":"        group[\u0027domain_id\u0027] \u003d CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FiKs%3D","line":704,"in_reply_to":"AAAAWH%2F%2FkKo%3D","updated":"2014-03-17 09:35:05.000000000","message":"Done","commit_id":"07b11d597c00009871024764dd5eb8dbeb78543a"}]}