)]}'
{"keystone/tests/test_backend_ldap.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"cb2fe5db87d46695953b678afeb16d324e25c232","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"                       \u0027description:name:something\u0027]"},{"line_number":1038,"context_line":"        mapping \u003d self.identity_api.driver.user._parse_extra_attrs(option_list)"},{"line_number":1039,"context_line":"        expected_dict \u003d {\u0027description\u0027: \u0027name\u0027, \u0027gecos\u0027: \u0027password\u0027,"},{"line_number":1040,"context_line":"                         \u0027fake\u0027: \u0027invalid\u0027, \u0027invalid2\u0027: \u0027\u0027}"},{"line_number":1041,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"# TODO(henry-nash): These need to be removed when the full LDAP implementation"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FtOI%3D","line":1040,"updated":"2014-04-18 03:12:20.000000000","message":"I believe it is preferred if you use\nfake_invalid_value \u003d uuid.uuid4().hex\nexpected_dict \u003d {\u0027description\u0027: \u0027name\u0027, \u0027gecos\u0027: \u0027password\u0027,\n\t\t\t \u0027fake\u0027: fake_invalid_value, \u0027invalid2\u0027: \u0027\u0027}\n\nOr since the rest of the example didn\u0027t do this, did it just seemed annoying to do this?","commit_id":"10051adace7cd728d46cd4c999e3019fdbf2d961"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"859080c0c8f7ddfcfd8cc50a6057e23cc8f10e79","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"                       \u0027description:name:something\u0027]"},{"line_number":1038,"context_line":"        mapping \u003d self.identity_api.driver.user._parse_extra_attrs(option_list)"},{"line_number":1039,"context_line":"        expected_dict \u003d {\u0027description\u0027: \u0027name\u0027, \u0027gecos\u0027: \u0027password\u0027,"},{"line_number":1040,"context_line":"                         \u0027fake\u0027: \u0027invalid\u0027, \u0027invalid2\u0027: \u0027\u0027}"},{"line_number":1041,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"# TODO(henry-nash): These need to be removed when the full LDAP implementation"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FmVY%3D","line":1040,"in_reply_to":"AAAAXH%2F%2FmgE%3D","updated":"2014-04-18 22:59:59.000000000","message":"I figured that was the case","commit_id":"10051adace7cd728d46cd4c999e3019fdbf2d961"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a8ffb40a36c47e7b14138f96a7aba50e516a53e2","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"                       \u0027description:name:something\u0027]"},{"line_number":1038,"context_line":"        mapping \u003d self.identity_api.driver.user._parse_extra_attrs(option_list)"},{"line_number":1039,"context_line":"        expected_dict \u003d {\u0027description\u0027: \u0027name\u0027, \u0027gecos\u0027: \u0027password\u0027,"},{"line_number":1040,"context_line":"                         \u0027fake\u0027: \u0027invalid\u0027, \u0027invalid2\u0027: \u0027\u0027}"},{"line_number":1041,"context_line":"        self.assertDictEqual(expected_dict, mapping)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"# TODO(henry-nash): These need to be removed when the full LDAP implementation"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FmgE%3D","line":1040,"in_reply_to":"AAAAXH%2F%2FtOI%3D","updated":"2014-04-18 22:19:16.000000000","message":"Since this change is a change in how the server works I wanted to make as few changes as possible to the existing tests; that way it\u0027s clear to reviewers the change in behavior.\n\nIf I also changed the test to use uuid\u0027s for the values it wouldn\u0027t be as clear what the current change is doing.","commit_id":"10051adace7cd728d46cd4c999e3019fdbf2d961"}]}