)]}'
{"keystone/catalog/backends/kvs.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"6c25c73e33c53013a6715a1ef17fa3bbabef721f","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def create_service(self, service_id, service):"},{"line_number":90,"context_line":"        self.db.set(\u0027service-%s\u0027 % service_id, service)"},{"line_number":91,"context_line":"        service_list \u003d set(self.db.get(\u0027service_list\u0027, []))"},{"line_number":92,"context_line":"        service_list.add(service_id)"},{"line_number":93,"context_line":"        self.db.set(\u0027service_list\u0027, list(service_list))"},{"line_number":94,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BuVk%3D","line":91,"updated":"2014-03-24 20:27:25.000000000","message":"Following the same logic, it would be ideal to include a try/catch at this point?","commit_id":"270cd6d4094f187a72cb505ffaa72ecca2dbc741"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6ad5463788900172cd1318e84da549958b72b4ca","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def create_service(self, service_id, service):"},{"line_number":90,"context_line":"        self.db.set(\u0027service-%s\u0027 % service_id, service)"},{"line_number":91,"context_line":"        service_list \u003d set(self.db.get(\u0027service_list\u0027, []))"},{"line_number":92,"context_line":"        service_list.add(service_id)"},{"line_number":93,"context_line":"        self.db.set(\u0027service_list\u0027, list(service_list))"},{"line_number":94,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BsW0%3D","line":91,"in_reply_to":"AAAAWH%2F%2BuVk%3D","updated":"2014-03-25 01:38:18.000000000","message":"this one shouldn\u0027t raise NotFound, it\u0027ll return an empty list if there\u0027s no service_list.","commit_id":"270cd6d4094f187a72cb505ffaa72ecca2dbc741"}],"keystone/catalog/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b8c8dac5e510d04a8c24593d13bdf51f111c587f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def __init__(self):"},{"line_number":68,"context_line":"        super(Manager, self).__init__(CONF.catalog.driver)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create_region(self, region_ref):"},{"line_number":71,"context_line":"        return self.driver.create_region(region_ref)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_region(self, region_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B1xc%3D","line":70,"updated":"2014-03-23 15:30:35.000000000","message":"The methods like this that just forward on the request to the driver should be removed. The forwarding happens automagically.","commit_id":"e1d01f7f51145be8e26eae6f6e8413323ba38130"}]}