)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34165,"name":"Sacha Pateyron","email":"sacha.pateyron@cea.fr","username":"sachapateyron"},"change_message_id":"142d16e142607d8437234571d6ad5bd4390159d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ddce6b5_9817fb99","updated":"2021-11-15 13:44:42.000000000","message":"Build succeeded.\n\nCan you review my patch please.\n\nThank you in advance.","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"cd24c7ab0857c00b286b5a279875aeb18748af86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f4ea3e2_feb43e78","updated":"2022-03-14 19:40:28.000000000","message":"Not the right approach.  As much as I would like Keystone to support BASIC_AUTH instead of the password in the body of the token request, doing it for Kerberos is not the right approach for Kerberos based clients, and sets a bad precedent.  I do not know if the SPNEGO protocol has been modified to allow for Kerberos proxying via HTTP(S) but it is at this level that things should be targetted, not at poking holes in an otherwise secure protocol...the BASIC_AUTH fallback for Kerberos set a bad example.\n\nIs there a mechanism in the python web libraries for dealing with proxied Kerberos?  If so, that is what we should use.","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"196d6cb8708ff2eb6fc11333390d60c6a4ed2b89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b14b9a7d_e83b3a7f","updated":"2022-03-11 16:35:31.000000000","message":"There can be many more authentication schemes:\nhttps://developer.mozilla.org/en-US/docs/Web/HTTP/Authentication#authentication_schemes","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"d3ba1953768950de56121a5ff91c3be1199571f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ea83ffe_bccd6e73","updated":"2022-03-11 16:34:29.000000000","message":"Would it be possible to add unit and/or functional tests to this?  A release note would be helpful as well.","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"de5c6d78bfb7c97027cf1b45c0c904e0b51d7d96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51512d80_df6e1318","updated":"2021-10-25 13:36:25.000000000","message":"You have an error in the PEP8 check for Python27.  A pain, but we need to carry 2.7 for a while.  Rechecking will not solve it.","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":34165,"name":"Sacha Pateyron","email":"sacha.pateyron@cea.fr","username":"sachapateyron"},"change_message_id":"563f1847344e90a852f3ac9571ee244da4d5f133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29bbab87_8b1897f0","updated":"2021-10-21 12:28:50.000000000","message":"recheck","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":34165,"name":"Sacha Pateyron","email":"sacha.pateyron@cea.fr","username":"sachapateyron"},"change_message_id":"8a31e8704fce646ddd934e329588d26d52c86731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2aa7742b_df767c6b","updated":"2021-10-28 07:25:14.000000000","message":"recheck","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":34165,"name":"Sacha Pateyron","email":"sacha.pateyron@cea.fr","username":"sachapateyron"},"change_message_id":"e664f55903686bd27d314003bf5aca0e42abff14","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54f6296c_1f892dc5","in_reply_to":"51512d80_df6e1318","updated":"2021-10-26 08:55:54.000000000","message":"How did you get the information that\u0027s wan an error in the pep8 check ?","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"234f0d119d048d5d3b8c01bef232591d14b2afdb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"657e167f_a5a6cbe9","in_reply_to":"54f6296c_1f892dc5","updated":"2021-10-27 23:10:46.000000000","message":"Disregard, I read it too quickly.  The error is in the Tempest check, which timed out in the last run, and was an ephemeral (?) error in Py27  the time before that (\u0027/home/zuul/src/opendev.org/openstack/keystone/etc/keystone.conf.sample\u0027)  which I cannot explain.","commit_id":"1efc0c5c6730c9066f47edf953bf805aec0fd3c0"}]}
