)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dae202c0938853aecbb40bc2539c2d5b775cd3a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Stanek \u003cdstanek@dstanek.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-20 00:42:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"More notification unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3d8d744005ba9006cefbc0feb740cc2662f57146"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2B1sU%3D","line":7,"updated":"2014-03-23 16:10:59.000000000","message":"why do we need more unit tests?","commit_id":"5464fe0f2f0dc60f0b83ef01fae1a93851862687"}],"keystone/tests/test_notifications.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dae202c0938853aecbb40bc2539c2d5b775cd3a6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            notifications._send_notification(operation, resource_type,"},{"line_number":153,"context_line":"                                             resource)"},{"line_number":154,"context_line":"            mocked.assert_called_once_with(*expected_args)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class NotificationsForEntities(test_v3.RestfulTestCase):"},{"line_number":158,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B1s8%3D","line":155,"updated":"2014-03-23 16:10:59.000000000","message":"why was this line removed? was\n\n notifications._send_notification(operation, resource_type, resource)","commit_id":"5464fe0f2f0dc60f0b83ef01fae1a93851862687"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dae202c0938853aecbb40bc2539c2d5b775cd3a6","unresolved":false,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"        with mock.patch(\u0027keystone.notifications.LOG\u0027, self.mock_log):"},{"line_number":529,"context_line":"            notifications.register_event_callback("},{"line_number":530,"context_line":"                CREATED_OPERATION, \u0027thing\u0027, callback)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        expected_log_data \u003d {"},{"line_number":533,"context_line":"            \u0027callback\u0027: \u0027keystone.tests.test_notifications.callback\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B1so%3D","line":530,"updated":"2014-03-23 16:10:59.000000000","message":"give a name to the \u0027thing\u0027 magic number so that reviewers know what it is. Also, could use random value --\n\n resource_type \u003d uuid.uuid4().hex\n notifications.register_event_callback(\n     CREATED_OPERATION, resource_type, callback)","commit_id":"5464fe0f2f0dc60f0b83ef01fae1a93851862687"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dae202c0938853aecbb40bc2539c2d5b775cd3a6","unresolved":false,"context_lines":[{"line_number":533,"context_line":"            \u0027callback\u0027: \u0027keystone.tests.test_notifications.callback\u0027,"},{"line_number":534,"context_line":"            \u0027event\u0027: \u0027identity.thing.created\u0027"},{"line_number":535,"context_line":"        }"},{"line_number":536,"context_line":"        self.verify_log_message([expected_log_data])"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def test_a_method_callback(self):"},{"line_number":539,"context_line":"        class C(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B1sY%3D","line":536,"updated":"2014-03-23 16:10:59.000000000","message":"the plan is to test that the code works based on the logs that were written? the code needs to be more testable than this.","commit_id":"5464fe0f2f0dc60f0b83ef01fae1a93851862687"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"aab94dd3c08092ec0c9194807585bc4a8f14e4e8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"#        self.useFixture(mockpatch.PatchObject("},{"line_number":58,"context_line":"#            notifications, \u0027_send_notification\u0027, fake_notify))"},{"line_number":59,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class NotificationsWrapperTestCase(testtools.TestCase):"},{"line_number":62,"context_line":"    def create_fake_ref(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2F6f8%3D","line":59,"updated":"2014-04-16 14:41:18.000000000","message":"^","commit_id":"68a96ba9c46bf2c8975a0778096270c6482c1245"}]}