)]}'
{"keystone/notifications.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"a9447aa90f39455b242c4bb95487e953a8dff589","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# a new action is supported."},{"line_number":41,"context_line":"ACTIONS \u003d frozenset([\u0027created\u0027, \u0027deleted\u0027, \u0027disabled\u0027, \u0027updated\u0027])"},{"line_number":42,"context_line":"# resource types that can be notified"},{"line_number":43,"context_line":"_SUBSCRIBERS \u003d {}"},{"line_number":44,"context_line":"_notifier \u003d None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9prI%3D","line":43,"updated":"2014-04-03 03:22:53.000000000","message":"why is SUBSCRIBERS all caps but notifier is not?  Seems inconsistent. What is the convention we are trying to follow here?","commit_id":"e941dc4e8c0a21c61bae5e19e599e4b935413944"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d1dd94bd1ea775f56e59b90bf234089d0e1761d7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# a new action is supported."},{"line_number":41,"context_line":"ACTIONS \u003d frozenset([\u0027created\u0027, \u0027deleted\u0027, \u0027disabled\u0027, \u0027updated\u0027])"},{"line_number":42,"context_line":"# resource types that can be notified"},{"line_number":43,"context_line":"_SUBSCRIBERS \u003d {}"},{"line_number":44,"context_line":"_notifier \u003d None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9cfo%3D","line":43,"in_reply_to":"AAAAWH%2F9prI%3D","updated":"2014-04-04 13:34:07.000000000","message":"Good question.","commit_id":"e941dc4e8c0a21c61bae5e19e599e4b935413944"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"a9447aa90f39455b242c4bb95487e953a8dff589","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    if public:"},{"line_number":214,"context_line":"        notifier \u003d _get_notifier()"},{"line_number":215,"context_line":"        if notifier:"},{"line_number":216,"context_line":"            context \u003d {}"},{"line_number":217,"context_line":"            event_type \u003d \u0027%(service)s.%(resource_type)s.%(operation)s\u0027 % {"},{"line_number":218,"context_line":"                \u0027service\u0027: service,"},{"line_number":219,"context_line":"                \u0027resource_type\u0027: resource_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9prg%3D","line":216,"updated":"2014-04-03 03:22:53.000000000","message":"So why did you move this code here?  Just to put it closer to the spot where it was used?  Was there any other reason why?","commit_id":"e941dc4e8c0a21c61bae5e19e599e4b935413944"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d1dd94bd1ea775f56e59b90bf234089d0e1761d7","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    if public:"},{"line_number":214,"context_line":"        notifier \u003d _get_notifier()"},{"line_number":215,"context_line":"        if notifier:"},{"line_number":216,"context_line":"            context \u003d {}"},{"line_number":217,"context_line":"            event_type \u003d \u0027%(service)s.%(resource_type)s.%(operation)s\u0027 % {"},{"line_number":218,"context_line":"                \u0027service\u0027: service,"},{"line_number":219,"context_line":"                \u0027resource_type\u0027: resource_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9cfU%3D","line":216,"in_reply_to":"AAAAWH%2F9prg%3D","updated":"2014-04-04 13:34:07.000000000","message":"Yes. While it\u0027s not a lot of CPU cycles I didn\u0027t want to create the objects until they would be used.","commit_id":"e941dc4e8c0a21c61bae5e19e599e4b935413944"}]}