)]}'
{"keystone/common/sql/migrate_repo/versions/044_service_enabled.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4bd8e2c6ca52a0d06b23eb2dc2f7b6b38249878e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"def _migrate_enabled_from_extra(migrate_engine, service_table):"},{"line_number":39,"context_line":"    \"\"\"Remove `enabled` from `extra`, put it in the `enabled` column.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    eps \u003d list(service_table.select().execute())"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    for ep in eps:"},{"line_number":44,"context_line":"        extra_dict \u003d jsonutils.loads(ep.extra)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BwOQ%3D","line":41,"updated":"2014-03-24 15:55:27.000000000","message":"(nit) services instead of eps?","commit_id":"41808fb31e98478f5444d746ec3defe416ed6a2a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4bd8e2c6ca52a0d06b23eb2dc2f7b6b38249878e","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    eps \u003d list(service_table.select().execute())"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    for ep in eps:"},{"line_number":44,"context_line":"        extra_dict \u003d jsonutils.loads(ep.extra)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if \u0027enabled\u0027 not in extra_dict:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BwOE%3D","line":43,"updated":"2014-03-24 15:55:27.000000000","message":"(nit) for service in services?","commit_id":"41808fb31e98478f5444d746ec3defe416ed6a2a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4bd8e2c6ca52a0d06b23eb2dc2f7b6b38249878e","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    eps \u003d list(service_table.select().execute())"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    for ep in eps:"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2BwNs%3D","line":74,"updated":"2014-03-24 15:55:27.000000000","message":"Same nits as above","commit_id":"41808fb31e98478f5444d746ec3defe416ed6a2a"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f9b6ba45cadae51bb1b9e52d30a935fe9fd94ab1","unresolved":false,"context_lines":[{"line_number":3577,"context_line":"        service_id \u003d uuid.uuid4().hex"},{"line_number":3578,"context_line":"        new_service \u003d {"},{"line_number":3579,"context_line":"            \u0027id\u0027: service_id,"},{"line_number":3580,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":3581,"context_line":"            \u0027type\u0027: uuid.uuid4().hex,"},{"line_number":3582,"context_line":"            \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":3583,"context_line":"            \u0027description\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BxjM%3D","line":3580,"updated":"2014-03-24 13:35:44.000000000","message":"the input to create_service shouldn\u0027t have to change.\n\nThe test would fail only because now the create_service includes \u0027enabled\u0027 in the response. So the change to this test should be to add \u0027enabled\u0027 to new_service after create so that assertDictEqual works. e.g., remove this line and at line 3588 do\n\n new_service[\u0027enabled\u0027] \u003d True","commit_id":"067f2e52286773c2e09694030ff5b7d66dbd8f19"}],"keystone/tests/test_sql_upgrade.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ee34ec1a264620567e4b5e8bf1815bcca960eaff","unresolved":false,"context_lines":[{"line_number":2154,"context_line":"        # `extra` JSON."},{"line_number":2155,"context_line":""},{"line_number":2156,"context_line":"        # We\u0027ll need a service entry since it\u0027s the foreign key for services."},{"line_number":2157,"context_line":"        service_id \u003d add_service()"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"        new_ep \u003d lambda **extra_data: add_service(**extra_data)"},{"line_number":2160,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2Bwjo%3D","line":2157,"updated":"2014-03-24 15:28:10.000000000","message":"Is this actually needed? I don\u0027t see it used anywhere.","commit_id":"34396f3a859d08e5ff3fd5a19d9278dc4b59f012"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e4c63233cd2af36a4e6a86b64412fc5edb44aba6","unresolved":false,"context_lines":[{"line_number":2154,"context_line":"        # `extra` JSON."},{"line_number":2155,"context_line":""},{"line_number":2156,"context_line":"        # We\u0027ll need a service entry since it\u0027s the foreign key for services."},{"line_number":2157,"context_line":"        service_id \u003d add_service()"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"        new_ep \u003d lambda **extra_data: add_service(**extra_data)"},{"line_number":2160,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAWH%2F%2BwWE%3D","line":2157,"in_reply_to":"AAAAWH%2F%2Bwjo%3D","updated":"2014-03-24 15:38:37.000000000","message":"remove this and the comment... an endpoint needs a service but a service doesn\u0027t need another service.","commit_id":"34396f3a859d08e5ff3fd5a19d9278dc4b59f012"}]}