)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"18cd9b1991a46d93a85a44f484cae43ed52fc4d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64662678_d34cb014","updated":"2022-02-08 16:09:33.000000000","message":"recheck","commit_id":"aebd037f501ca3aa9e927f304382c231dacb2938"}],"keystone/tests/unit/test_sql_banned_operations.py":[{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"ba7c8e2cdffb013a121d352026a44628e3db4b84","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from keystone.common.sql.legacy_migrations import contract_repo"},{"line_number":28,"context_line":"from keystone.common.sql.legacy_migrations import data_migration_repo"},{"line_number":29,"context_line":"from keystone.common.sql.legacy_migrations import expand_repo"},{"line_number":30,"context_line":"from keystone.common.sql import upgrades"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"17f9e493_11331dff","line":29,"updated":"2022-02-04 17:02:37.000000000","message":"After this change, those tests would only apply to legacy migrations. In effect, as I understand it, we\u0027ll stop supporting online rolling upgrades, so a release note is necessary.","commit_id":"aebd037f501ca3aa9e927f304382c231dacb2938"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"47c094ef97392a06be854658d749a38bed1bc64a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from keystone.common.sql.legacy_migrations import contract_repo"},{"line_number":28,"context_line":"from keystone.common.sql.legacy_migrations import data_migration_repo"},{"line_number":29,"context_line":"from keystone.common.sql.legacy_migrations import expand_repo"},{"line_number":30,"context_line":"from keystone.common.sql import upgrades"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"af153b3c_0b6548ae","line":29,"in_reply_to":"17f9e493_11331dff","updated":"2022-02-04 17:12:18.000000000","message":"\u003e After this change, those tests would only apply to legacy migrations.\n\nFor now, but only in the short term.\n\n\u003e In effect, as I understand it, we\u0027ll stop supporting online rolling upgrades, so a release note is necessary.\n\nNope, we\u0027re not going to do anything silly like that 😄 This is just prepping for the introduction of alembic but we haven\u0027t added anything yet. In the alembic\u0027ful future, we\u0027re still going to split our migrations, albeit into branches instead of repos (we\u0027re also going to only have two branches - expand and contract - since this is what neutron does and it\u0027s perfectly okay for them). These tests just need to be updated/duplicated+reworked to test the new alembic-based migration flow. That has to happen when we integrate alembic fully. The end result should be quite similar: after all, in an alembic-based world, instead of checking if e.g. we\u0027re using destructive operations in the expand *repo*, we\u0027ll simply check if we\u0027re using these operations in the expand *branch*.\n\nHopefully this clears up any confusion.","commit_id":"aebd037f501ca3aa9e927f304382c231dacb2938"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"854eb85e8396b31d106a38e32c3bbc39f373145f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from keystone.common.sql.legacy_migrations import contract_repo"},{"line_number":28,"context_line":"from keystone.common.sql.legacy_migrations import data_migration_repo"},{"line_number":29,"context_line":"from keystone.common.sql.legacy_migrations import expand_repo"},{"line_number":30,"context_line":"from keystone.common.sql import upgrades"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3b4301ce_e7b87553","line":29,"in_reply_to":"af153b3c_0b6548ae","updated":"2022-02-07 09:51:01.000000000","message":"Yep, thanks, for the reply!","commit_id":"aebd037f501ca3aa9e927f304382c231dacb2938"}]}