)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"ac8556fa5b17ef15fc9ce35d6f86e576ace6baa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f984c0ae_e365cc21","updated":"2022-07-22 11:41:13.000000000","message":"I would like to see some testing of this, but since it is a feature used only by developers maybe they are not needed.","commit_id":"2b55f992b36e554be16429e6280ae02a765b55c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"531aa43d690b94181b2d8b2efb9db5646bff7c53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ab22f31c_c4b492be","in_reply_to":"f984c0ae_e365cc21","updated":"2022-07-27 10:01:37.000000000","message":"Yeah, pretty much. We\u0027d also effectively be testing core SQLAlchemy functionality","commit_id":"2b55f992b36e554be16429e6280ae02a765b55c3"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"a132de06af811cdbdded5c15801f8d894260bed5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"28fd5be1_179ef8b8","updated":"2023-07-01 19:57:54.000000000","message":"2023-06-30 20:02:06.160 | {0} tempest.api.network.test_networks.BulkNetworkOpsIpV6Test.test_bulk_create_delete_subnet [71.197819s] ... FAILED\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 | Captured traceback:\n2023-06-30 20:02:06.160 | ~~~~~~~~~~~~~~~~~~~\n2023-06-30 20:02:06.160 |     Traceback (most recent call last):\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |       File \"/opt/stack/old/tempest/.tox/tempest/lib/python3.10/site-packages/urllib3/connectionpool.py\", line 449, in _make_request\n2023-06-30 20:02:06.160 |     six.raise_from(e, None)\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |       File \"\u003cstring\u003e\", line 3, in raise_from\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |       File \"/opt/stack/old/tempest/.tox/tempest/lib/python3.10/site-packages/urllib3/connectionpool.py\", line 444, in _make_request\n2023-06-30 20:02:06.160 |     httplib_response \u003d conn.getresponse()\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |       File \"/usr/lib/python3.10/http/client.py\", line 1374, in getresponse\n2023-06-30 20:02:06.160 |     response.begin()\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |       File \"/usr/lib/python3.10/http/client.py\", line 318, in begin\n2023-06-30 20:02:06.160 |     version, status, reason \u003d self._read_status()\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |       File \"/usr/lib/python3.10/http/client.py\", line 279, in _read_status\n2023-06-30 20:02:06.160 |     line \u003d str(self.fp.readline(_MAXLINE + 1), \"iso-8859-1\")\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |       File \"/usr/lib/python3.10/socket.py\", line 705, in readinto\n2023-06-30 20:02:06.160 |     return self._sock.recv_into(b)\n2023-06-30 20:02:06.160 | \n2023-06-30 20:02:06.160 |     TimeoutError: timed out","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"1f9a86b75711fc3343f94732cb6995434c2494d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"dcf8463a_934df630","updated":"2023-06-20 03:25:44.000000000","message":"Admittedly I do not understand how this works, but it looks not harmful.","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"38dea7529e8de44344b4f64b0da094bc3ecdf293","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"24950f22_60c9973c","updated":"2023-06-22 21:56:08.000000000","message":"I need more coffee for this. I\u0027ll give it a more in-depth read tomorrow. Thanks Stephen for your patience.","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"43c222c16ccc4577a4cf9c5db7a5ded0d899d8b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1bd6f8a4_9279b66b","updated":"2023-04-04 00:05:53.000000000","message":"Is there a document explaining how any of this is supposed to work? I read through Alembic tutorial. But I cannot seem to link its material and this code.","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"6a38a375495eb48481d56023b3759b3fea78a74a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d63ca8c6_6fc22a77","updated":"2023-06-27 11:54:33.000000000","message":"Please see me comment / attempt to use this https://review.opendev.org/c/openstack/keystone/+/885463/comments/a7e91ece_77e3d924.\n\nCould you kindly tell me if I should be able to apply this patch on master and then run \n\n  tox --notest -r -e py38\n  source .tox/py38/bin/activate\n  alembic -c keystone/common/sql/alembic.ini upgrade heads\n  alembic -c keystone/common/sql/alembic.ini revision --autogenerate\n\nwith no new revision being created?\nOr am I holding this wrong?","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"9152a59ec3689997e878fc55b17c933547de2536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"968f3816_39e80d2f","updated":"2023-06-29 13:41:22.000000000","message":"This looks ok, it also isn\u0027t on a critical path of running the service, so we should merge this early and fix things as we generate new migrations.","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"686dff8c33cb75ec7f95b62cf77e8fa7f4d11ef4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f78387c5_07f25453","updated":"2023-07-01 19:58:03.000000000","message":"recheck - timed out","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b0acc7d4f02f499b4b45d762fcb1ccf9a7219b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"29b98b8f_4bdcf935","in_reply_to":"d1222f17_84ace489","updated":"2023-06-27 12:34:35.000000000","message":"I added a follow-up patch [1] to document this.\n\n[1] https://review.opendev.org/c/openstack/keystone/+/887035","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"850101218772ec64968db75d7f2d79d3fb46c579","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d1222f17_84ace489","in_reply_to":"d63ca8c6_6fc22a77","updated":"2023-06-27 12:22:09.000000000","message":"Because `keystone` is using multiple branches, we need to provide our own tool. That\u0027s what the `manage.py` file is for. Instead, you want to do:\n\n```\nsource .tox/py38/bin/activate\npython -m keystone.common.sql.migrations.manage upgrade heads\npython -m keystone.common.sql.migrations.manage revision --autogenerate\n```\n\nHowever, I notice that this change isn\u0027t getting picked up, while if I e.g. add a new column it is. That\u0027s because I\u0027m explicitly ignoring this column [1] because there is a mismatch between the models and migrations. I have patches later in the series to address these issues so that we stop skipping those columns and I think one of those changes [2] might actually do what you\u0027re attempting to do?\n\n[1] https://review.opendev.org/c/openstack/keystone/+/826147/12/keystone/common/sql/migrations/env.py#66\n[2] https://review.opendev.org/c/openstack/keystone/+/879678/","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"}],"keystone/common/sql/migrations/autogen.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"edda8bb2690b7522c527f35652f403bf0553de60","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        # setting nullable\u003dTrue is clearly an expand operation (it makes the"},{"line_number":112,"context_line":"        # database more permissive) and the opposite is also true. As such,"},{"line_number":113,"context_line":"        # shouldn\u0027t we simply emit the directive if we\u0027re in the relevant phase"},{"line_number":114,"context_line":"        # and skip otherwise? This is only left because zzzeek wrote that"},{"line_number":115,"context_line":"        # neutron code and I\u0027m sure he had good reason for this."},{"line_number":116,"context_line":"        msg \u003d _("},{"line_number":117,"context_line":"            \"Don\u0027t know if operation is an expand or contract at the moment: \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3107adb1_a64e89da","line":114,"updated":"2023-06-13 14:16:44.000000000","message":"i would have written this like 6 years ago so...do we actually reach this assertion?   if it\u0027s being reached and there is a better answer to return, then by all means change it.","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d6b2abd4ef80af8eac853e6d00df044c09dd842","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        # setting nullable\u003dTrue is clearly an expand operation (it makes the"},{"line_number":112,"context_line":"        # database more permissive) and the opposite is also true. As such,"},{"line_number":113,"context_line":"        # shouldn\u0027t we simply emit the directive if we\u0027re in the relevant phase"},{"line_number":114,"context_line":"        # and skip otherwise? This is only left because zzzeek wrote that"},{"line_number":115,"context_line":"        # neutron code and I\u0027m sure he had good reason for this."},{"line_number":116,"context_line":"        msg \u003d _("},{"line_number":117,"context_line":"            \"Don\u0027t know if operation is an expand or contract at the moment: \""}],"source_content_type":"text/x-python","patch_set":12,"id":"b6a16055_d7887881","line":114,"in_reply_to":"3107adb1_a64e89da","updated":"2023-06-13 17:25:00.000000000","message":"We do. I\u0027ve hit it in either Cinder and Nova and had to manually generate the migration. If you don\u0027t see any clear reason for us to this though then I\u0027ll change it, sure (in a follow-up so the initial code looks similar to the other projects)","commit_id":"1bcf8cee0d93c2844b810fa30c2e3d9ba99e813e"}]}