)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"26facac329cc7162f566101b87c3192ebedf6b1f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed the size limit tests in Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- None can not be compated to an integer in Python 3"},{"line_number":10,"context_line":"- In Python 3 a request body must be bytes"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bp python3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAXH%2F%2FilA%3D","line":9,"updated":"2014-04-19 21:51:41.000000000","message":"So there is a typo here.  Is compated supposed to compared?  This typo needs to be fixed and a little more detail would be helpful","commit_id":"c576cf44361043e8c3138c7562bdc55afe75cd5e"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"cb0701a82031328c67df60e5074dcb878f43f53a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed the size limit tests in Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- None can not be compared to an integer in Python 3"},{"line_number":10,"context_line":"- In Python 3 a request body must be bytes"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"bp python3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAXX%2F%2F0lg%3D","line":9,"updated":"2014-04-26 03:27:14.000000000","message":"nit: can not should be cannot (one word not two)","commit_id":"c4d2b665831e3426ec6bf2ca14b0dc028a351b00"}],"keystone/middleware/core.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"26facac329cc7162f566101b87c3192ebedf6b1f","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    @webob.dec.wsgify()"},{"line_number":222,"context_line":"    def __call__(self, req):"},{"line_number":223,"context_line":"        if req.content_length is None:"},{"line_number":224,"context_line":"            if req.is_body_readable:"},{"line_number":225,"context_line":"                limiter \u003d utils.LimitingReader(req.body_file,"},{"line_number":226,"context_line":"                                               CONF.max_request_body_size)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fijk%3D","line":223,"updated":"2014-04-19 21:51:41.000000000","message":"Interesting. So in python 3 checking if a None value is greater than something gets flagged but this is not caught in python 2.x correct?","commit_id":"c576cf44361043e8c3138c7562bdc55afe75cd5e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"389437404220f9aa46d7b87aa9c63e6408e370d1","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    @webob.dec.wsgify()"},{"line_number":222,"context_line":"    def __call__(self, req):"},{"line_number":223,"context_line":"        if req.content_length is None:"},{"line_number":224,"context_line":"            if req.is_body_readable:"},{"line_number":225,"context_line":"                limiter \u003d utils.LimitingReader(req.body_file,"},{"line_number":226,"context_line":"                                               CONF.max_request_body_size)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FASM%3D","line":223,"in_reply_to":"AAAAXH%2F%2Fijk%3D","updated":"2014-04-24 18:12:41.000000000","message":"Yep:\n\nIn 2:\n   \u003e\u003e\u003e None \u003e 2\n   False\n\nIn 3:\n    \u003e\u003e\u003e None \u003e 2\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    TypeError: unorderable types: NoneType() \u003e int()\n    \u003e\u003e\u003e","commit_id":"c576cf44361043e8c3138c7562bdc55afe75cd5e"}],"keystone/tests/test_sizelimit.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"26facac329cc7162f566101b87c3192ebedf6b1f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_content_length_acceptable(self):"},{"line_number":40,"context_line":"        self.request.headers[\u0027Content-Length\u0027] \u003d MAX_REQUEST_BODY_SIZE"},{"line_number":41,"context_line":"        self.request.body \u003d b\"0\" * MAX_REQUEST_BODY_SIZE"},{"line_number":42,"context_line":"        response \u003d self.request.get_response(self.middleware)"},{"line_number":43,"context_line":"        self.assertEqual(200, response.status_int)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fijg%3D","line":41,"updated":"2014-04-19 21:51:41.000000000","message":"would be helpful to have a comment that states why in python 3 you need to declare the \"0\" as a bytes type string object to get the proper calculation you desire","commit_id":"c576cf44361043e8c3138c7562bdc55afe75cd5e"}]}
