)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"ef83532ed2bc4e693a6edda279655491815b0443","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c1280f4d_fc68b211","updated":"2022-06-03 15:11:21.000000000","message":"Hello Alexandre,\n\nIt looks like the work in this patch is related to [1].  If that is the case can you re-propose [1] for this cycle?  We need to get that merged before we\u0027re able to get this in.  Also, this patch will need documentation as well as a release note.\n\nThanks,\n/Dave\n\n[1]: https://review.opendev.org/c/openstack/keystone-specs/+/748748/8/specs/keystone/wallaby/federated-identity-mapping-support-project-json-definition.rst ","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"55e05ef8eaede64372c0ede040d874016f6c3c64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbf91d06_50b8b869","updated":"2025-08-13 13:27:16.000000000","message":"Hello Alexandre, \nI have added support for this via https://review.opendev.org/c/openstack/keystone/+/742235. \n\nCan you help us reviewing and testing that patch?","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"df51ee20f270611d9e1692a035aecce4b226379c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db5e2e53_f57c9ae0","updated":"2022-06-24 13:42:58.000000000","message":"We have a patch that is open since Jul 21 that implements the spec mentioned here: https://review.opendev.org/c/openstack/keystone/+/742235","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"ca62136993d895bb6f0ed0d90b0b34e5a2833d21","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"508e91ef_d6769de4","in_reply_to":"c1280f4d_fc68b211","updated":"2022-06-08 12:16:44.000000000","message":"Thanks David for reviewing this, adding docs and release notes makes sense.\nI will review the specs and repropose something soon.","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"07353af0417d6f7ccca7bc0bf7c64e38b175719b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc27bac3_e29c9f8a","in_reply_to":"db5e2e53_f57c9ae0","updated":"2022-06-24 13:43:33.000000000","message":"When I say Jul 21, you should read July of 2021","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"}],"keystone/auth/plugins/mapped.py":[{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"4480f7f3b4ececba24153a1ceabb2580e245b5af","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            # Check and see if the project already exists and if it"},{"line_number":148,"context_line":"            # does not, try to create it."},{"line_number":149,"context_line":"            # domain_id \u003d get_domain_id(shadow_project,idp_domain_id)"},{"line_number":150,"context_line":"            domain_id \u003d idp_domain_id"},{"line_number":151,"context_line":"            if \u0027domain\u0027 in shadow_project:"},{"line_number":152,"context_line":"                if \u0027id\u0027 in shadow_project[\u0027domain\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"31215b7e_4cdc3753","line":149,"updated":"2022-05-31 16:00:46.000000000","message":"oops, I will drop this code comment in next spin","commit_id":"ea943b77e12a74ae1aed34cc750195f38ebe66e4"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"5861104ba1c0dae15140fcaf27bff01597cfb367","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            # Check and see if the project already exists and if it"},{"line_number":148,"context_line":"            # does not, try to create it."},{"line_number":149,"context_line":"            # domain_id \u003d get_domain_id(shadow_project,idp_domain_id)"},{"line_number":150,"context_line":"            domain_id \u003d idp_domain_id"},{"line_number":151,"context_line":"            if \u0027domain\u0027 in shadow_project:"},{"line_number":152,"context_line":"                if \u0027id\u0027 in shadow_project[\u0027domain\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f585edb_9da426b9","line":149,"in_reply_to":"31215b7e_4cdc3753","updated":"2022-06-01 06:17:24.000000000","message":"Done","commit_id":"ea943b77e12a74ae1aed34cc750195f38ebe66e4"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6fa5edde9a0f6c1d9a2bbb1b64390f613524c613","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                # mapping and what it\u0027s saying to create. If there is something"},{"line_number":264,"context_line":"                # wrong with how the mapping is, we should bail early before we"},{"line_number":265,"context_line":"                # create anything."},{"line_number":266,"context_line":"                _validate_shadow_mapping("},{"line_number":267,"context_line":"                    mapped_properties[\u0027projects\u0027],"},{"line_number":268,"context_line":"                    existing_roles,"},{"line_number":269,"context_line":"                    idp_domain_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d333363e_91216cf1","line":266,"updated":"2022-06-03 15:12:41.000000000","message":"What\u0027s the purpose of this change?\n\nI see that you moved the functions outside, but I don\u0027t see them being used in any other place.","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"ca62136993d895bb6f0ed0d90b0b34e5a2833d21","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                # mapping and what it\u0027s saying to create. If there is something"},{"line_number":264,"context_line":"                # wrong with how the mapping is, we should bail early before we"},{"line_number":265,"context_line":"                # create anything."},{"line_number":266,"context_line":"                _validate_shadow_mapping("},{"line_number":267,"context_line":"                    mapped_properties[\u0027projects\u0027],"},{"line_number":268,"context_line":"                    existing_roles,"},{"line_number":269,"context_line":"                    idp_domain_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"47d4cd38_11cb8b13","line":266,"in_reply_to":"b72538d8_fd3ff425","updated":"2022-06-08 12:16:44.000000000","message":"Yes, I just added 5 lines in create_projects_from_mapping involving function \"too complex\" pep8 issue on handle_unscopped_token, so I decide to move both inner.\nValidate_shadow_mapping remain unchanged.","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"},{"author":{"_account_id":28595,"name":"Victor Coutellier","email":"victor.coutellier@gmail.com","username":"alistarle"},"change_message_id":"370055c59956d53811224f4e12eeec2b06af9159","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                # mapping and what it\u0027s saying to create. If there is something"},{"line_number":264,"context_line":"                # wrong with how the mapping is, we should bail early before we"},{"line_number":265,"context_line":"                # create anything."},{"line_number":266,"context_line":"                _validate_shadow_mapping("},{"line_number":267,"context_line":"                    mapped_properties[\u0027projects\u0027],"},{"line_number":268,"context_line":"                    existing_roles,"},{"line_number":269,"context_line":"                    idp_domain_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b72538d8_fd3ff425","line":266,"in_reply_to":"d333363e_91216cf1","updated":"2022-06-06 08:20:26.000000000","message":"It is just to avoid tox issue. The function where this code was located will be too complex if we had more line of code in it, so we choose to move inner function outside to not hit that issue.","commit_id":"695aa21605203157775411cea4e77eca52fdf5f9"}]}