)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"512401024e31467860f7939cb394ec2adff16255","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2014-04-01 14:46:33 +0300"},{"line_number":4,"context_line":"Commit:     Ilya Pekelny \u003cipekelny@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-01 16:03:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compatible server default value in the models."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MySQL has no native boolean type. MySQL boolean type is just an alias"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F93Js%3D","line":6,"updated":"2014-04-01 15:29:35.000000000","message":"I like the commit, but your reasoning in the commit message seems to be misleading for me.\n\nThe problem we\u0027ve got here is that we want to be able to compare the database schema obtained by running migration scripts on a given backend to be equal to the one generated from model definitions. This particular case is about comparing default values for columns. Reflection of a boolean column default value will return either \u0027true\u0027 or \u0027false\u0027, but what we\u0027ve got here is \u00271\u0027, so the test will fail for PostgreSQL (while it\u0027s completely ok for MySQL, e.g.).","commit_id":"554aa724ac9e8cbbab8d18ca06ce49b79506f00b"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"116e15fc56fa8fc3f8b1cdf3ff306780c4ff6d11","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2014-04-01 14:46:33 +0300"},{"line_number":4,"context_line":"Commit:     Ilya Pekelny \u003cipekelny@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-01 16:03:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compatible server default value in the models."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MySQL has no native boolean type. MySQL boolean type is just an alias"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F9vTQ%3D","line":6,"in_reply_to":"AAAAWH%2F93Js%3D","updated":"2014-04-02 13:18:35.000000000","message":"I think the commit message as is makes it clear.","commit_id":"554aa724ac9e8cbbab8d18ca06ce49b79506f00b"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"01f1d8b33afc888647293fba8598132bb79a15e8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2014-04-01 14:46:33 +0300"},{"line_number":4,"context_line":"Commit:     Ilya Pekelny \u003cipekelny@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-01 16:03:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Compatible server default value in the models."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MySQL has no native boolean type. MySQL boolean type is just an alias"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAWH%2F9vKI%3D","line":6,"in_reply_to":"AAAAWH%2F9vTQ%3D","updated":"2014-04-02 13:35:55.000000000","message":"I\u0027d argue that psycopg2 returning proper Python bool values has nothing to do with column defaults which are reflected by SQLAlchemy (that, in fact, will be strings - \"\u0027true\u0027\"/\"\u0027false\u0027\").\n\nAnyway, the commit itself is correct. But I still think it would benefit from describing the reason of the problem in details. Not going to insist on this though, so, core reviewers, feel free to approve this without waiting for me to remove -1 :)","commit_id":"554aa724ac9e8cbbab8d18ca06ce49b79506f00b"}],"keystone/catalog/backends/sql.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"6d8eff38e7c38fef55f8355c983c75efae31c1c9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":58,"context_line":"    type \u003d sql.Column(sql.String(255))"},{"line_number":59,"context_line":"    enabled \u003d sql.Column(sql.Boolean, nullable\u003dFalse, default\u003dTrue,"},{"line_number":60,"context_line":"                         server_default\u003dsqlalchemy.sql.expression.true())"},{"line_number":61,"context_line":"    extra \u003d sql.Column(sql.JsonBlob())"},{"line_number":62,"context_line":"    endpoints \u003d sqlalchemy.orm.relationship(\"Endpoint\", backref\u003d\"service\")"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAXH%2F%2FAgo%3D","line":60,"updated":"2014-04-24 17:40:20.000000000","message":"thank you","commit_id":"52d1fbfbe1476c01685c86a0b91f3fe8b110eaa5"}]}