)]}'
{"keystone/catalog/backends/sql.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"548a3d60585f749934e419f31e5dc65ca43af50f","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        return catalog"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_raw_catalog(self):"},{"line_number":280,"context_line":"        session \u003d sql.get_session()"},{"line_number":281,"context_line":"        t \u003d True  # variable for singleton for PEP8, E712."},{"line_number":282,"context_line":"        services \u003d (session.query(Service).filter(Service.enabled \u003d\u003d t)."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9c0w%3D","line":279,"updated":"2014-04-04 12:48:01.000000000","message":"you\u0027re introducing a new public method to the driver -- make it private","commit_id":"d6c1e6dc43fe00bf1adb6a349c3fe99e4c60f2a2"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"548a3d60585f749934e419f31e5dc65ca43af50f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"def format_v3_catalog(d, services):"},{"line_number":295,"context_line":"    def make_v3_endpoint(endpoint):"},{"line_number":296,"context_line":"        endpoint \u003d endpoint.to_dict()"},{"line_number":297,"context_line":"        del endpoint[\u0027service_id\u0027]"},{"line_number":298,"context_line":"        del endpoint[\u0027legacy_endpoint_id\u0027]"},{"line_number":299,"context_line":"        del endpoint[\u0027enabled\u0027]"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9c04%3D","line":297,"updated":"2014-04-04 12:48:01.000000000","message":"is service_id actually appearing in the catalog too? that\u0027s not part of the bug report","commit_id":"d6c1e6dc43fe00bf1adb6a349c3fe99e4c60f2a2"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e233dec07ce2e332344cb88c2ca9b9d9c0fbdcdc","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        def make_v3_endpoint(endpoint):"},{"line_number":293,"context_line":"            endpoint \u003d endpoint.to_dict()"},{"line_number":294,"context_line":"            del endpoint[\u0027service_id\u0027]"},{"line_number":295,"context_line":"            del endpoint[\u0027legacy_endpoint_id\u0027]"},{"line_number":296,"context_line":"            del endpoint[\u0027enabled\u0027]"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            endpoint[\u0027url\u0027] \u003d core.format_url(endpoint[\u0027url\u0027], d)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9bvU%3D","line":295,"updated":"2014-04-04 15:02:17.000000000","message":"nit: add a comment that these are for internal use only?","commit_id":"96b650430829a87ceea069e31965781a6298a0da"}],"keystone/tests/test_v3.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"548a3d60585f749934e419f31e5dc65ca43af50f","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            raise AssertionError(msg)"},{"line_number":539,"context_line":"        self.assertIsInstance(dt, datetime.datetime)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def assertValidTokenResponse(self, r, user\u003dNone):"},{"line_number":542,"context_line":"        self.assertTrue(r.headers.get(\u0027X-Subject-Token\u0027))"},{"line_number":543,"context_line":"        token \u003d r.result[\u0027token\u0027]"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9czc%3D","line":541,"updated":"2014-04-04 12:48:01.000000000","message":"not all tokens have catalogs, but...","commit_id":"d6c1e6dc43fe00bf1adb6a349c3fe99e4c60f2a2"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"548a3d60585f749934e419f31e5dc65ca43af50f","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        catalog \u003d token.get(\u0027catalog\u0027)"},{"line_number":565,"context_line":"        if catalog:"},{"line_number":566,"context_line":"            for service in catalog:"},{"line_number":567,"context_line":"                #Bypass the check for XML"},{"line_number":568,"context_line":"                if isinstance(service, six.string_types):"},{"line_number":569,"context_line":"                    continue"},{"line_number":570,"context_line":"                for endpoint in service[\u0027endpoints\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9czU%3D","line":567,"updated":"2014-04-04 12:48:01.000000000","message":"why?","commit_id":"d6c1e6dc43fe00bf1adb6a349c3fe99e4c60f2a2"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"548a3d60585f749934e419f31e5dc65ca43af50f","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        return token"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    def assertValidScopedTokenResponse(self, r, *args, **kwargs):"},{"line_number":587,"context_line":"        require_catalog \u003d kwargs.pop(\u0027require_catalog\u0027, True)"},{"line_number":588,"context_line":"        endpoint_filter \u003d kwargs.pop(\u0027endpoint_filter\u0027, False)"},{"line_number":589,"context_line":"        ep_filter_assoc \u003d kwargs.pop(\u0027ep_filter_assoc\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9czk%3D","line":586,"updated":"2014-04-04 12:48:01.000000000","message":"scoped tokens have catalogs","commit_id":"d6c1e6dc43fe00bf1adb6a349c3fe99e4c60f2a2"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"548a3d60585f749934e419f31e5dc65ca43af50f","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        token \u003d self.assertValidTokenResponse(r, *args, **kwargs)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if require_catalog:"},{"line_number":593,"context_line":"            self.assertIn(\u0027catalog\u0027, token)"},{"line_number":594,"context_line":"            # sub test for the OS-EP-FILTER extension enabled"},{"line_number":595,"context_line":"            if endpoint_filter:"},{"line_number":596,"context_line":"                # verify the catalog hs no more than the endpoints"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9czw%3D","line":593,"updated":"2014-04-04 12:48:01.000000000","message":"you should write tests for the catalog here, where it\u0027s always present","commit_id":"d6c1e6dc43fe00bf1adb6a349c3fe99e4c60f2a2"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0763e663355af7885ba0622a730ef5d39659a7f1","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        catalog \u003d token.get(\u0027catalog\u0027)"},{"line_number":565,"context_line":"        if catalog:"},{"line_number":566,"context_line":"            for service in catalog:"},{"line_number":567,"context_line":"                #Bypass the check for XML"},{"line_number":568,"context_line":"                if isinstance(service, six.string_types):"},{"line_number":569,"context_line":"                    continue"},{"line_number":570,"context_line":"                for endpoint in service[\u0027endpoints\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9cTs%3D","line":567,"updated":"2014-04-04 13:57:31.000000000","message":"why?","commit_id":"96b650430829a87ceea069e31965781a6298a0da"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e233dec07ce2e332344cb88c2ca9b9d9c0fbdcdc","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        catalog \u003d token.get(\u0027catalog\u0027)"},{"line_number":565,"context_line":"        if catalog:"},{"line_number":566,"context_line":"            for service in catalog:"},{"line_number":567,"context_line":"                #Bypass the check for XML"},{"line_number":568,"context_line":"                if isinstance(service, six.string_types):"},{"line_number":569,"context_line":"                    continue"},{"line_number":570,"context_line":"                for endpoint in service[\u0027endpoints\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9buM%3D","line":567,"in_reply_to":"AAAAWH%2F9cTs%3D","updated":"2014-04-04 15:02:17.000000000","message":"reminder that comments should have a space between # and character.","commit_id":"96b650430829a87ceea069e31965781a6298a0da"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0763e663355af7885ba0622a730ef5d39659a7f1","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                    continue"},{"line_number":570,"context_line":"                for endpoint in service[\u0027endpoints\u0027]:"},{"line_number":571,"context_line":"                    self.assertNotIn(\u0027legacy_endpoint_id\u0027, endpoint)"},{"line_number":572,"context_line":"                    self.assertNotIn(\u0027enabled\u0027, endpoint)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        return token"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9cYQ%3D","line":572,"updated":"2014-04-04 13:57:31.000000000","message":"assert against service_id","commit_id":"96b650430829a87ceea069e31965781a6298a0da"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e233dec07ce2e332344cb88c2ca9b9d9c0fbdcdc","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                    continue"},{"line_number":570,"context_line":"                for endpoint in service[\u0027endpoints\u0027]:"},{"line_number":571,"context_line":"                    self.assertNotIn(\u0027legacy_endpoint_id\u0027, endpoint)"},{"line_number":572,"context_line":"                    self.assertNotIn(\u0027enabled\u0027, endpoint)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        return token"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9buc%3D","line":572,"in_reply_to":"AAAAWH%2F9cYQ%3D","updated":"2014-04-04 15:02:17.000000000","message":"@dolph, the service_id was deleted in the endpoint","commit_id":"96b650430829a87ceea069e31965781a6298a0da"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0763e663355af7885ba0622a730ef5d39659a7f1","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        token \u003d self.assertValidTokenResponse(r, *args, **kwargs)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if require_catalog:"},{"line_number":593,"context_line":"            self.assertIn(\u0027catalog\u0027, token)"},{"line_number":594,"context_line":"            # sub test for the OS-EP-FILTER extension enabled"},{"line_number":595,"context_line":"            if endpoint_filter:"},{"line_number":596,"context_line":"                # verify the catalog hs no more than the endpoints"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F9cTo%3D","line":593,"updated":"2014-04-04 13:57:31.000000000","message":"move the above check here","commit_id":"96b650430829a87ceea069e31965781a6298a0da"}]}