)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3e51ed547435a14a7e2c6f14639f296495fe0105","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When we check the EC2 signature without the port part of the host value"},{"line_number":10,"context_line":"received, we should properly split host:port. Keep in mind the splitting"},{"line_number":11,"context_line":"should work for values like [fc00::]:123 too."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1d90dfcea3568e2a9b22069daa428ea6a2a38bd6"},{"line_number":14,"context_line":"Closes-Bug: #1988168"},{"line_number":15,"context_line":"(cherry picked from commit 6c35b366e3c8c6d7f47471b93f5315582301c5ef)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c146d4d3_a8b5b13b","line":12,"updated":"2022-09-16 19:54:08.000000000","message":"This patch is not a clean cherry pick (see my inline comment about details). Though there is no conflict when backporting this patch, in general it is a good practice to add a \"Note\" in the commit message to make it easier to review the patch to stable reviewers, like:\n\nNote: the patch needed a change due to compatibility reason as stable/train still supports python2.","commit_id":"8d883f011c586f0e79c56f0f70f9455997d70012"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3e51ed547435a14a7e2c6f14639f296495fe0105","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8fd0684_7a52543c","updated":"2022-09-16 19:54:08.000000000","message":"The backport looks OK (i\u0027ve added some minor comments), giving +1 only until the stable/ussuri version merges.","commit_id":"8d883f011c586f0e79c56f0f70f9455997d70012"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a9850af8154819b4cba87ddf62b74ffc1be822be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"95b1a66b_a6c8274c","updated":"2022-11-03 10:56:00.000000000","message":"Ussuri backport has merged, so this is good to go as well, upgrading to +2+W. (what I commented on this patch is still valid)","commit_id":"8d883f011c586f0e79c56f0f70f9455997d70012"}],"keystone/api/ec2tokens.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3e51ed547435a14a7e2c6f14639f296495fe0105","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# This file handles all flask-restful resources for /v3/ec2tokens"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from six.moves.urllib import parse as urllib_parse"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import flask"},{"line_number":18,"context_line":"from keystoneclient.contrib.ec2 import utils as ec2_utils"}],"source_content_type":"text/x-python","patch_set":2,"id":"feaa39bf_6c132179","line":15,"updated":"2022-09-16 19:54:08.000000000","message":"Note: this has changed compared to the original patch / the patch on stable/ussuri, which was:\n\nimport urllib.parse\n\nsix is needed because stable/train still supports py27.","commit_id":"8d883f011c586f0e79c56f0f70f9455997d70012"}]}
