)]}'
{"keystone/assignment/backends/sql.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"364be8f22d9ebe9755f1717d37b630dca2d12a09","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                sql_constraints).distinct()"},{"line_number":297,"context_line":"        return [role.to_dict() for role in query.all()]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def get_group_project_roles(self, user_id, group_refs, project_ref):"},{"line_number":300,"context_line":"        role_list \u003d []"},{"line_number":301,"context_line":"        for group in group_refs:"},{"line_number":302,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FBqE%3D","line":299,"updated":"2014-04-24 15:09:19.000000000","message":"simplify the driver interface as much as possible to make it explicit:\n\n- you\u0027re \"listing roles\" so that should clearly be in the method name\n- you don\u0027t use the \"user_id\", so remove it\n- you don\u0027t need to pass group \"refs\" here, you just need a list of \"group_ids\"\n- you don\u0027t need a complete project \"ref\" here, you just need a \"project_id\" (and from that, the domain_id could be looked up, or passed in as \"project_domain_id\")","commit_id":"3ed9049d61e41883bd48d6d325f44e0e041e128f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"364be8f22d9ebe9755f1717d37b630dca2d12a09","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                role_list +\u003d self._roles_from_role_dicts("},{"line_number":306,"context_line":"                    metadata_ref.get(\u0027roles\u0027, {}), False)"},{"line_number":307,"context_line":"            except exception.MetadataNotFound:"},{"line_number":308,"context_line":"                # no group grant, skip"},{"line_number":309,"context_line":"                pass"},{"line_number":310,"context_line":"            if CONF.os_inherit.enabled:"},{"line_number":311,"context_line":"            # Now get any inherited group roles for the owning domain"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FBow%3D","line":308,"updated":"2014-04-24 15:09:19.000000000","message":"s/grant/assignment/","commit_id":"3ed9049d61e41883bd48d6d325f44e0e041e128f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"364be8f22d9ebe9755f1717d37b630dca2d12a09","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                # no group grant, skip"},{"line_number":309,"context_line":"                pass"},{"line_number":310,"context_line":"            if CONF.os_inherit.enabled:"},{"line_number":311,"context_line":"            # Now get any inherited group roles for the owning domain"},{"line_number":312,"context_line":"                try:"},{"line_number":313,"context_line":"                    metadata_ref \u003d self._get_metadata("},{"line_number":314,"context_line":"                        group_id\u003dgroup[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FBpo%3D","line":311,"updated":"2014-04-24 15:09:19.000000000","message":"this comment should be indented once more","commit_id":"3ed9049d61e41883bd48d6d325f44e0e041e128f"}],"keystone/assignment/core.py":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"7572b0a3ed486c7fa14f234bd22b5d8dafc89ab3","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        def _get_group_project_roles(user_id, project_ref):"},{"line_number":131,"context_line":"            return self.identity_api.get_group_project_roles(user_id,"},{"line_number":132,"context_line":"                                                             project_ref)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        def _get_user_project_roles(user_id, project_ref):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F6UA%3D","line":131,"updated":"2014-04-08 14:53:21.000000000","message":"Just a question (because I\u0027m not sure), Its implementation has some improvement over the previous code?","commit_id":"acc5bca4a802198c57082d5b59b027967af66253"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"af5725f2aa5477aecb66846700bdc7200f7daac0","unresolved":false,"context_lines":[{"line_number":932,"context_line":""},{"line_number":933,"context_line":"    @abc.abstractmethod"},{"line_number":934,"context_line":"    def get_group_project_roles(self, groups, project_id, project_domain_id):"},{"line_number":935,"context_line":"        \"\"\"Get group roles of for a specific project."},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        Supports the ``OS-INHERIT`` role inheritance from the project\u0027s domain"},{"line_number":938,"context_line":"        if supported by the assignment driver."}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_29bc4fbb","line":935,"updated":"2014-07-01 15:49:55.000000000","message":"typo: \"of for\"","commit_id":"8df4b3ed18dadb97959e5b55c9a3840bc9aac5d9"}],"keystone/identity/backends/kvs.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"dbf6c8ce60ff08d4826d4df0588cfd69fef842dd","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    def get_group_project_roles(self, user_id, project_ref):"},{"line_number":220,"context_line":"        user_ref \u003d self._get_user(user_id)"},{"line_number":221,"context_line":"        group_ids \u003d user_ref.get(\u0027groups\u0027, [])"},{"line_number":222,"context_line":"        roles \u003d [self.get_group(x) for x in group_ids if"},{"line_number":223,"context_line":"                 self.get_group(x)[\u0027tenant_id\u0027] \u003d\u003d project_ref[\u0027id\u0027]]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if CONF.os_inherit.enabled:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F62U%3D","line":222,"updated":"2014-04-08 13:58:09.000000000","message":"perhaps a more descriptive name could be given to the \"x\" variable.","commit_id":"acc5bca4a802198c57082d5b59b027967af66253"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"7572b0a3ed486c7fa14f234bd22b5d8dafc89ab3","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        user_ref \u003d self._get_user(user_id)"},{"line_number":221,"context_line":"        group_ids \u003d user_ref.get(\u0027groups\u0027, [])"},{"line_number":222,"context_line":"        roles \u003d [self.get_group(x) for x in group_ids if"},{"line_number":223,"context_line":"                 self.get_group(x)[\u0027tenant_id\u0027] \u003d\u003d project_ref[\u0027id\u0027]]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if CONF.os_inherit.enabled:"},{"line_number":226,"context_line":"            roles +\u003d [self.get_group(x) for x in group_ids if"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F6Xk%3D","line":223,"updated":"2014-04-08 14:53:21.000000000","message":"You need to be sure if tenant_id exists. The tests are failing.","commit_id":"acc5bca4a802198c57082d5b59b027967af66253"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4d655cf5a4ad30be583c1e99cf59983b8da2249a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from keystone import identity"},{"line_number":20,"context_line":"from keystone.openstack.common.gettextutils import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class _UserIdToDomainId(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FcZg%3D","line":22,"updated":"2014-05-01 01:54:17.000000000","message":"Why add this if nothing uses it?","commit_id":"3ed9049d61e41883bd48d6d325f44e0e041e128f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"364be8f22d9ebe9755f1717d37b630dca2d12a09","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from keystone import identity"},{"line_number":20,"context_line":"from keystone.openstack.common.gettextutils import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class _UserIdToDomainId(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FBtY%3D","line":22,"updated":"2014-04-24 15:09:19.000000000","message":"undo changes to this file?","commit_id":"3ed9049d61e41883bd48d6d325f44e0e041e128f"}],"keystone/identity/backends/ldap.py":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"7572b0a3ed486c7fa14f234bd22b5d8dafc89ab3","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        memberships \u003d self.get_all(query)"},{"line_number":343,"context_line":"        return memberships"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def get_group_project_roles(self, user_dn, project_ref):"},{"line_number":346,"context_line":"        query \u003d \u0027(\u0026(objectClass\u003d%s)(%s\u003d%s)\u0027 \\"},{"line_number":347,"context_line":"            \u0027(project_id\u003d%s)%s)\u0027 % (self.object_class,"},{"line_number":348,"context_line":"                self.member_attribute,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F6ZQ%3D","line":345,"updated":"2014-04-08 14:53:21.000000000","message":"I would like you comment this function","commit_id":"acc5bca4a802198c57082d5b59b027967af66253"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"dbf6c8ce60ff08d4826d4df0588cfd69fef842dd","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        memberships \u003d self.get_all(query)"},{"line_number":343,"context_line":"        return memberships"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def get_group_project_roles(self, user_dn, project_ref):"},{"line_number":346,"context_line":"        query \u003d \u0027(\u0026(objectClass\u003d%s)(%s\u003d%s)\u0027 \\"},{"line_number":347,"context_line":"            \u0027(project_id\u003d%s)%s)\u0027 % (self.object_class,"},{"line_number":348,"context_line":"                self.member_attribute,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F680%3D","line":345,"updated":"2014-04-08 13:58:09.000000000","message":"If this function is only used here, perhaps it could be \"private\", meaning, it could have an underscore prepended to the name.","commit_id":"acc5bca4a802198c57082d5b59b027967af66253"}],"keystone/identity/backends/sql.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"dbf6c8ce60ff08d4826d4df0588cfd69fef842dd","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def get_group_project_roles(self, user_id, project_ref):"},{"line_number":186,"context_line":"        session \u003d sql.get_session()"},{"line_number":187,"context_line":"        self.get_user(user_id)"},{"line_number":188,"context_line":"        query \u003d session.query(Group).join(UserGroupMembership)"},{"line_number":189,"context_line":"        query \u003d query.filter_by(user_id\u003duser_id)"},{"line_number":190,"context_line":"        query \u003d query.filter(\u0027project_id\u0027 \u003d\u003d project_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F64M%3D","line":187,"updated":"2014-04-08 13:58:09.000000000","message":"I think this function call is not needed here. At least the way it is used now.","commit_id":"acc5bca4a802198c57082d5b59b027967af66253"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"dbf6c8ce60ff08d4826d4df0588cfd69fef842dd","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        query \u003d session.query(Group).join(UserGroupMembership)"},{"line_number":189,"context_line":"        query \u003d query.filter_by(user_id\u003duser_id)"},{"line_number":190,"context_line":"        query \u003d query.filter(\u0027project_id\u0027 \u003d\u003d project_ref[\u0027id\u0027])"},{"line_number":191,"context_line":"        roles \u003d [g.to_dict() for g in query]"},{"line_number":192,"context_line":"        if CONF.os_inherit.enabled:"},{"line_number":193,"context_line":"            query \u003d session.query(Group).join(UserGroupMembership)"},{"line_number":194,"context_line":"            query \u003d query.filter_by(user_id\u003duser_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F63A%3D","line":191,"updated":"2014-04-08 13:58:09.000000000","message":"perhaps a more descriptive name could be given to the \"g\" variable.","commit_id":"acc5bca4a802198c57082d5b59b027967af66253"}]}
