)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"096d368f90e8b2f359567293c91ee4f8c85b7a65","unresolved":false,"context_lines":[{"line_number":817,"context_line":"        # in a case-insensitive way.  We use the case specified in the"},{"line_number":818,"context_line":"        # mapping for the model to ensure we have a predictable way of"},{"line_number":819,"context_line":"        # retrieving values later."},{"line_number":820,"context_line":"        lower_res \u003d dict(zip(map(string.lower, res[1].keys()),"},{"line_number":821,"context_line":"                             res[1].values()))"},{"line_number":822,"context_line":"        for k in obj.known_keys:"},{"line_number":823,"context_line":"            if k in self.attribute_ignore:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2Fv3M%3D","line":820,"updated":"2014-04-10 16:50:43.000000000","message":"You don\u0027t want to use string.lower here. The string module shouldn\u0027t be used for much in Py2 and was gutted in Py3. How about (untested, but you get the idea):\n\n    lower_res \u003d dict((k.lower(), v) for k, v in six.iteritems(res[1])","commit_id":"ddfb1b89e157109994dded5ce50673aef13913f1"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"8179e8d80668d5d3e5274f202637fdd01d7e6ed5","unresolved":false,"context_lines":[{"line_number":817,"context_line":"        # in a case-insensitive way.  We use the case specified in the"},{"line_number":818,"context_line":"        # mapping for the model to ensure we have a predictable way of"},{"line_number":819,"context_line":"        # retrieving values later."},{"line_number":820,"context_line":"        lower_res \u003d dict(zip(map(string.lower, res[1].keys()),"},{"line_number":821,"context_line":"                             res[1].values()))"},{"line_number":822,"context_line":"        for k in obj.known_keys:"},{"line_number":823,"context_line":"            if k in self.attribute_ignore:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FvxU%3D","line":820,"in_reply_to":"AAAAW3%2F%2Fv3M%3D","updated":"2014-04-10 17:04:12.000000000","message":"Done","commit_id":"ddfb1b89e157109994dded5ce50673aef13913f1"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"096d368f90e8b2f359567293c91ee4f8c85b7a65","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                continue"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"            try:"},{"line_number":827,"context_line":"                v \u003d lower_res[string.lower("},{"line_number":828,"context_line":"                    self.attribute_mapping.get(k, k))]"},{"line_number":829,"context_line":"            except KeyError:"},{"line_number":830,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2Fv28%3D","line":827,"updated":"2014-04-10 16:50:43.000000000","message":"Same thing. How about:\n\n    v \u003d lower_res[self.attribute_mapping.get(k, k).lower()]","commit_id":"ddfb1b89e157109994dded5ce50673aef13913f1"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"8179e8d80668d5d3e5274f202637fdd01d7e6ed5","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                continue"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"            try:"},{"line_number":827,"context_line":"                v \u003d lower_res[string.lower("},{"line_number":828,"context_line":"                    self.attribute_mapping.get(k, k))]"},{"line_number":829,"context_line":"            except KeyError:"},{"line_number":830,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FvzA%3D","line":827,"in_reply_to":"AAAAW3%2F%2Fv28%3D","updated":"2014-04-10 17:04:12.000000000","message":"Done","commit_id":"ddfb1b89e157109994dded5ce50673aef13913f1"}],"keystone/tests/test_backend_ldap.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4ed001abb045b6a11baa22414bb82f68d2c66dd5","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        mock_ldap_get.return_value \u003d ("},{"line_number":991,"context_line":"            \u0027cn\u003djunk,dc\u003dexample,dc\u003dcom\u0027,"},{"line_number":992,"context_line":"            {"},{"line_number":993,"context_line":"                \u0027sN\u0027: [u\u0027junk\u0027],"},{"line_number":994,"context_line":"                \u0027eMaIl\u0027: [u\u0027junk\u0027]"},{"line_number":995,"context_line":"            }"},{"line_number":996,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAW3%2F%2Fvkc%3D","line":993,"updated":"2014-04-10 17:23:39.000000000","message":"Could you use two different uuids here and check or their value in user below?","commit_id":"2d931f3ef90a14f8289864608cac3e9497735c88"}]}
