)]}'
{"id":"openstack%2Fkeystone~866723","triplet_id":"openstack%2Fkeystone~master~I59ebf0fa77391d49b2349e918fc55f96318c42a6","project":"openstack/keystone","branch":"master","attention_set":{},"removed_from_attention_set":{"16465":{"account":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"last_update":"2023-02-23 21:39:42.000000000","reason":"Change was submitted"},"34980":{"account":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"last_update":"2023-02-23 21:39:42.000000000","reason":"Change was submitted"},"7973":{"account":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"last_update":"2023-02-23 19:33:07.000000000","reason":"\u003cGERRIT_ACCOUNT_7973\u003e replied on the change","reason_account":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"}}},"hashtags":[],"change_id":"I59ebf0fa77391d49b2349e918fc55f96318c42a6","subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","status":"MERGED","created":"2022-12-06 14:57:43.000000000","updated":"2023-03-22 04:03:07.000000000","submitted":"2023-02-23 21:39:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"866723","meta_rev_id":"da6ef0ea363b84b1914623e25a4910e5b9652699","_number":866723,"virtual_id_number":866723,"owner":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-02-23 21:39:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"recommended":{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},"all":[{"value":1,"date":"2022-12-14 16:11:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},{"value":2,"date":"2023-02-23 19:33:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":1,"date":"2023-01-31 15:11:04.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":2,"date":"2023-01-31 15:47:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":0,"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},{"value":1,"date":"2023-02-23 19:33:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"}],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"}],"CC":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-06 16:17:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-12-06 16:33:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-14 16:11:22.000000000","updated_by":{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},"reviewer":{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},"state":"REVIEWER"},{"updated":"2023-01-31 15:11:04.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"},{"updated":"2023-01-31 15:47:56.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"},{"updated":"2023-02-02 08:03:02.000000000","updated_by":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"},{"updated":"2023-02-13 11:21:09.000000000","updated_by":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"},{"updated":"2023-02-13 11:21:09.000000000","updated_by":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2023-03-22 04:03:07.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"CC"}],"messages":[{"id":"b785f9d0170218016a56d1f3e982fe67cda9a2ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2022-12-06 14:57:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"13465946386c98753c471e39d779d6fdc91e765f","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-06 16:17:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2b5cfc4487664bf2983191991d023e03\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/b958daf1883f4586b115128357fafaae : SUCCESS in 47m 56s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/8b58d00093664034b8c0bf070a357fec : TIMED_OUT in 1h 00m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0c9628bf69b922ec4043afddc240a33b9992970a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-06 16:33:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/164dabaa218b447786eab5ad21ea084f\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6bcaa72160f64cc38e672f2590c8a7d9 : SUCCESS in 16m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c6b12be7943a460497e79df562e3c8f1 : SUCCESS in 5m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1031ffb70003417d996e7eab418fc8b4 : SUCCESS in 12m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7c30dda07bd94b07b76aefbdd04197e6 : SUCCESS in 14m 05s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/0180b38a5020494796b78d3edd1fcf9b : SUCCESS in 12m 59s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92bf8d8c1661476a912fdf4c388b9817 : SUCCESS in 12m 22s\n- grenade https://zuul.opendev.org/t/openstack/build/825586e615df440dae115c91c3f45836 : SUCCESS in 53m 56s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/11e27ccd18ad4c13918875dee40a3f9e : SUCCESS in 1h 34m 25s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/b4357c93f90f4d369fb31d3b268f05cf : SUCCESS in 31m 52s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/5db955e670a748d884cde7b53b9712dc : SUCCESS in 40m 16s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/76922b0ac7bc478eb21652989198d005 : SUCCESS in 26m 44s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/4935926700b44994ba1ca2c8bc497da1 : SUCCESS in 28m 16s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/f3e5d88ff246409bb97624916cec780d : SUCCESS in 10m 41s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/ee4178e61a184a8d80fd29392378feef : FAILURE in 13m 45s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dd616cb93d7649a59f42e4c0c089a124 : SUCCESS in 49m 15s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/b184bc656606490f86ce12fea3665c1a : SUCCESS in 46m 50s","accounts_in_message":[],"_revision_number":1},{"id":"465384dd3eca7983766247443ecd4d6413d5563c","author":{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},"date":"2022-12-14 16:11:22.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dd19500116ac78c40e85ef7f8061ae6e6b289910","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2023-01-31 15:11:04.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5d5cc612e8b46ba62bd93b419705910a7bde37c6","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-01-31 15:47:56.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2e0e29b48c52c631590cac1e396b44130a988478","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-02 08:03:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5c0c9f7c3978c4f09267881c2f90d0f0d0bfe572","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-13 11:22:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2c9b4faf03084784eeaa8539641cc54eab548fe5","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2023-02-23 19:33:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e32eebddb510e34a19a05293839ef223e69bd92e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-23 19:33:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5a52756a559e622db843e7d1d4f6d90c0cc4e4f4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-23 21:39:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9ec44c797fb845668665a47688f5fe1d\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/222f3d8b12d24919991b7fad0aeaa48e : SUCCESS in 5m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cf1a6f5c2eea48059aa4fab2bbe1942c : SUCCESS in 15m 42s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5cfb6f7ca978457d9e56017311368157 : SUCCESS in 16m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c0835bdd0634f5282771939946e53cf : SUCCESS in 12m 10s\n- grenade https://zuul.opendev.org/t/openstack/build/95912cebde8e4a3496e1043b3cc002fa : SUCCESS in 44m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2e247e7feb90402a86581383c1d8f392 : SUCCESS in 1h 15m 59s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/1e2bbf7b757e42a4b9951776d69e5fce : SUCCESS in 31m 36s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/84aa7a169d8544f587ec874af166cbe5 : SUCCESS in 27m 11s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/80cff58fb3e144d4b7cfd4ebe1e5ee51 : SUCCESS in 42m 37s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/bda5d56e5cbf4d6e809a84d268d8a4bd : SUCCESS in 49m 47s","accounts_in_message":[],"_revision_number":1},{"id":"2b7ad7ee760d37e12801556140a1773c0f7ef4e3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-23 21:39:42.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"87f11a8b033ee06520dd1b4afdf68e53629c762a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-23 21:41:23.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fdc508f8b53e43eca5ebbce4a322108d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9cef1956800e410eb4cd1210044f1134 : SUCCESS in 1m 17s","accounts_in_message":[],"_revision_number":1},{"id":"da6ef0ea363b84b1914623e25a4910e5b9652699","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2023-03-22 04:03:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ff632a81fb09e6d9f3298e494d53eb6df50269cf","revisions":{"ff632a81fb09e6d9f3298e494d53eb6df50269cf":{"kind":"REWORK","_number":1,"created":"2022-12-06 14:57:43.000000000","uploader":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"ref":"refs/changes/23/866723/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/23/866723/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/23/866723/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/23/866723/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/23/866723/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/23/866723/1"}}},"commit":{"parents":[{"commit":"7d4047cb69139c22f4e321e9ba8b287a47168df2","subject":"Merge \"requirements: Bump linter requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/7d4047cb69139c22f4e321e9ba8b287a47168df2"}]}],"author":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2022-12-05 14:33:47.000000000","tz":180},"committer":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2022-12-06 14:48:43.000000000","tz":180},"subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","message":"[PooledLDAPHandler] Ensure result3() invokes message.clean()\n\nresult3 does not invoke message.clean() when an exception is thrown\nby `message.connection.result3()` call, causing pool connection\nassociated with the message to be marked active forever. This causes\na denial-of-service on ldappool.\n\nThe fix ensures message.clean() is invoked by wrapping the offending\ncall in try-except-finally and putting the message.clean() in finally\nblock.\n\nCloses-Bug: #1998789\n\nChange-Id: I59ebf0fa77391d49b2349e918fc55f96318c42a6\nSigned-off-by: Mustafa Kemal Gilor \u003cmustafa.gilor@canonical.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ff632a81fb09e6d9f3298e494d53eb6df50269cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/ff632a81fb09e6d9f3298e494d53eb6df50269cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"}}]}],"submit_requirements":[]}