)]}'
{"keystone/tests/ksfixtures/hacking.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"cd4dfc8a3dadcc3db1a8fc6e68d4f144a83e6fc7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# NOTE(morganfainberg) This file shouldn\u0027t have flake8 run on it as it has"},{"line_number":14,"context_line":"# code examples that will fail normal CI pep8/flake8 tests. This is expected."},{"line_number":15,"context_line":"# The code has been moved here to ensure that proper tests occur on the"},{"line_number":16,"context_line":"# test_hacking_checks test cases."},{"line_number":17,"context_line":"# flake8: noqa"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FPYU%3D","line":15,"updated":"2014-04-23 04:56:01.000000000","message":"so a real nit, but if you do another patch:   after mentioning in the comment that the code has been moved here say, \"and the flake8 ignore file directive has been added in this file as well to ensure.. \"\n\nIts a nice reminder so folks don\u0027t wonder, how did they flag the ksfixtures directory so that flake8 won\u0027t run on it and then the person goes looks at run_tests.sh to figure that out...","commit_id":"cf78ff71a939bf91fa658d13e607de9f2863fbdd"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"890bf46a4490b2224ff2605288cdb774eff2a5df","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class HackingCode(fixtures.Fixture):"},{"line_number":23,"context_line":"    \"\"\"A fixture to house the various code examples for the keystone hacking"},{"line_number":24,"context_line":"    style checks."},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    mutable_default_args \u003d {"},{"line_number":28,"context_line":"        \u0027code\u0027: \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FiB4%3D","line":25,"updated":"2014-04-13 16:36:34.000000000","message":"add a comment why we\u0027re doing this -- so we can flake8 test\nthe test_hacking_checks test cases.","commit_id":"cf78ff71a939bf91fa658d13e607de9f2863fbdd"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6b56c446c3cf1d14f4733ef8e62c43d06d5ee401","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class HackingCode(fixtures.Fixture):"},{"line_number":23,"context_line":"    \"\"\"A fixture to house the various code examples for the keystone hacking"},{"line_number":24,"context_line":"    style checks."},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    mutable_default_args \u003d {"},{"line_number":28,"context_line":"        \u0027code\u0027: \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FhyA%3D","line":25,"in_reply_to":"AAAAW3%2F%2FiB4%3D","updated":"2014-04-13 19:17:29.000000000","message":"Did this as a comment instead of a docstring on line 13. I\u0027ll convert to a docstring if another patchset is warranted.","commit_id":"cf78ff71a939bf91fa658d13e607de9f2863fbdd"}],"keystone/tests/test_hacking_checks.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d115ba7c281a2a01d1ba8447149670e73b090688","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            def f(bad\u003d[]):  # noqa"},{"line_number":73,"context_line":"                pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":"        expected_errors \u003d ["},{"line_number":77,"context_line":"            (7, 10, \u0027K001\u0027),"},{"line_number":78,"context_line":"            (10, 15, \u0027K001\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXX%2F%2F0%2Bc%3D","side":"PARENT","line":75,"updated":"2014-04-25 23:41:47.000000000","message":"if these aren\u0027t being used in more than one place (and there\u0027s no subsequent patchset to do so either), what\u0027s the point of this patchset?","commit_id":"ec6d5d4718e47e6f3e05a959fa348d3ca01efb7f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"890bf46a4490b2224ff2605288cdb774eff2a5df","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(BaseStyleCheck, self).setUp()"},{"line_number":27,"context_line":"        self.code_ex \u003d self.useFixture(hacking_fixtures.HackingCode())"},{"line_number":28,"context_line":"        self.addCleanup(delattr, self, \u0027code_ex\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_checker(self):"},{"line_number":31,"context_line":"        \"\"\"Returns the checker to be used for tests in this class.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FiB8%3D","line":28,"updated":"2014-04-13 16:36:34.000000000","message":"why is this line necessary? add a comment.","commit_id":"cf78ff71a939bf91fa658d13e607de9f2863fbdd"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6b56c446c3cf1d14f4733ef8e62c43d06d5ee401","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(BaseStyleCheck, self).setUp()"},{"line_number":27,"context_line":"        self.code_ex \u003d self.useFixture(hacking_fixtures.HackingCode())"},{"line_number":28,"context_line":"        self.addCleanup(delattr, self, \u0027code_ex\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_checker(self):"},{"line_number":31,"context_line":"        \"\"\"Returns the checker to be used for tests in this class.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2Fhx4%3D","line":28,"in_reply_to":"AAAAW3%2F%2FiB8%3D","updated":"2014-04-13 19:17:29.000000000","message":"It\u0027s the same semantics as we use elsewhere, it\u0027s to ensure we don\u0027t leave refs of objects around after we\u0027re done with testing (limiting memory bloat). In this case there isn\u0027t a large amount of code being left around, but if the checks expand, we want to not leave the data around.\n\nIt stems from unit tests not deleting the testcase when done (afaik).","commit_id":"cf78ff71a939bf91fa658d13e607de9f2863fbdd"}]}