)]}'
{"id":"openstack%2Fkeystone~874841","triplet_id":"openstack%2Fkeystone~stable%2Fzed~I59ebf0fa77391d49b2349e918fc55f96318c42a6","project":"openstack/keystone","branch":"stable/zed","attention_set":{},"removed_from_attention_set":{"16465":{"account":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"last_update":"2023-03-20 11:19:36.000000000","reason":"Change was submitted"},"34980":{"account":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"last_update":"2023-03-20 11:19:36.000000000","reason":"Change was submitted"},"7414":{"account":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"last_update":"2023-03-14 18:10:17.000000000","reason":"\u003cGERRIT_ACCOUNT_7414\u003e replied on the change","reason_account":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}},"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2023-03-20 09:58:55.000000000","reason":"\u003cGERRIT_ACCOUNT_14250\u003e replied on the change","reason_account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}}},"hashtags":[],"change_id":"I59ebf0fa77391d49b2349e918fc55f96318c42a6","subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","status":"MERGED","created":"2023-02-24 07:07:44.000000000","updated":"2023-03-20 11:21:01.000000000","submitted":"2023-03-20 11:19:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"874841","cherry_pick_of_change":866723,"cherry_pick_of_patch_set":1,"meta_rev_id":"93259784591e8fdcce47d7b9937a91b3326edcf2","_number":874841,"virtual_id_number":874841,"owner":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-03-20 11:19:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":2,"date":"2023-03-14 15:24:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":1,"date":"2023-03-14 18:10:17.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":2,"date":"2023-03-20 09:58:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":1,"date":"2023-03-20 09:58:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-24 08:08:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-02-24 08:34:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-14 15:24:12.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"},{"updated":"2023-03-14 15:24:31.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"},{"updated":"2023-03-14 15:24:31.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"},{"updated":"2023-03-14 15:24:31.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"}],"messages":[{"id":"077b7dff9be56be72cdab0784ecdc6a575251e1d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-24 07:07:44.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"4a232a4f8b8cd4abbfe2edc765a74eb88736b26c","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-24 08:08:16.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dd0f6b4b677240829eb3a535833fd805\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/69dc1c6e5d16451d9fcac63ffe350b06 : SUCCESS in 58m 19s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/fe27647ec7834046aa0b3edd9ceade5d : SUCCESS in 9m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"283a5885b2ec04fbeb2e57b78e38e8fa7347fc81","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-24 08:34:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7c96d6783064468ea0efde639dce02d1\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2485e8f5c8564115858ea35730003b54 : SUCCESS in 13m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4aa970b179684adf920068f655550618 : SUCCESS in 4m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5c548406d879475390cbd712e49d2042 : SUCCESS in 9m 49s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4bbff0c23ad541c6b4c8069012b4b97c : SUCCESS in 10m 29s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a0074af24ccb427aa3fb517c807cae78 : SUCCESS in 11m 05s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c84d69674d24c819ca33da1162245af : SUCCESS in 11m 22s\n- grenade https://zuul.opendev.org/t/openstack/build/c67a948d52e5416cbd50a9d0cd9bdb62 : SUCCESS in 1h 19m 26s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/18cb22934a88418ea5999fddf3b2e33e : SUCCESS in 1h 21m 49s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/23380bffe92d4e33bcaa94bbd5a32026 : SUCCESS in 28m 35s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/c3b7514d52d14248936ca648ad3549b7 : SUCCESS in 35m 43s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0e9e07ea96a84ef58eaed86651e9063d : SUCCESS in 40m 10s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/5ab08d69b7734e268488bfd475aa60e1 : SUCCESS in 37m 52s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/bb0db6839fb54a63a45ed5e40230d3a0 : SUCCESS in 10m 01s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/5668454ec422461a853bf078a4b41fea : SUCCESS in 42m 53s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/673fa5d67384482b8a63998a5a98e191 : SUCCESS in 56m 01s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/e0a01843137d4637a2b7ff9d41db1813 : SUCCESS in 30m 32s","accounts_in_message":[],"_revision_number":1},{"id":"87265de83b4c666db6534c1744662ebf4265577c","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2023-03-14 15:24:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"488a1b543b88778db6341de90852ffa8a918b65d","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2023-03-14 18:10:17.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2db598c5cd866673fc4041ed573653f835f13ef4","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-03-20 09:58:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"209cfd3e84daf86271a874f23d670f32afa98bdd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-20 09:59:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f66cc55d7a21f85442df5b00c6ba9644c07e954d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-20 11:19:36.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/20dafa7256c64a78aeafc9af4130c735\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a81b8d9fd4c44acfb531397827f49822 : SUCCESS in 6m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/22fe1c6c81c34420bc98342540a5523f : SUCCESS in 10m 47s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/95e56f2cc4a84845ac76824b5af052e2 : SUCCESS in 11m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81693ff095474ea7a42bcbeeef2589e4 : SUCCESS in 14m 57s\n- grenade https://zuul.opendev.org/t/openstack/build/cca3b96cf0c542a089774be0d6e8b5d1 : SUCCESS in 1h 00m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3c051593e4f84b0eb511986349de5e59 : SUCCESS in 1h 14m 42s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/b94276dfe60b4da9a8c611bac9cc8c63 : SUCCESS in 43m 58s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/c00ff9ec7f1448f692efcd12e0e8da96 : SUCCESS in 36m 18s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1d06b39f161944c99830e085e3722f1c : SUCCESS in 55m 00s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/543bef48df70429db53ac7634827d4fd : SUCCESS in 53m 38s","accounts_in_message":[],"_revision_number":1},{"id":"f187507be05af7456f52d723055b7f08406b650e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-20 11:19:36.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"93259784591e8fdcce47d7b9937a91b3326edcf2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-20 11:21:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fea1c91ff2a145db967bd5ae2b5c8c96\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ca5f38afdeb4e12a3ef2fee870c2919 : SUCCESS in 1m 03s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7c30c9e000b58055b61d8cf58e52493f2b5aba8a","revisions":{"7c30c9e000b58055b61d8cf58e52493f2b5aba8a":{"kind":"REWORK","_number":1,"created":"2023-02-24 07:07:44.000000000","uploader":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"ref":"refs/changes/41/874841/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/41/874841/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/41/874841/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/41/874841/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/41/874841/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/41/874841/1"}}},"commit":{"parents":[{"commit":"e4e097c5bcf981199563bd721ac643900d3fb616","subject":"Limit token expiration to application credential expiration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/e4e097c5bcf981199563bd721ac643900d3fb616"}]}],"author":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2022-12-05 14:33:47.000000000","tz":180},"committer":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2023-02-24 07:07:44.000000000","tz":0},"subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","message":"[PooledLDAPHandler] Ensure result3() invokes message.clean()\n\nresult3 does not invoke message.clean() when an exception is thrown\nby `message.connection.result3()` call, causing pool connection\nassociated with the message to be marked active forever. This causes\na denial-of-service on ldappool.\n\nThe fix ensures message.clean() is invoked by wrapping the offending\ncall in try-except-finally and putting the message.clean() in finally\nblock.\n\nCloses-Bug: #1998789\n\nChange-Id: I59ebf0fa77391d49b2349e918fc55f96318c42a6\nSigned-off-by: Mustafa Kemal Gilor \u003cmustafa.gilor@canonical.com\u003e\n(cherry picked from commit ff632a81fb09e6d9f3298e494d53eb6df50269cf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/7c30c9e000b58055b61d8cf58e52493f2b5aba8a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/7c30c9e000b58055b61d8cf58e52493f2b5aba8a"}]},"branch":"refs/heads/stable/zed"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}