)]}'
{"id":"openstack%2Fkeystone~874843","triplet_id":"openstack%2Fkeystone~stable%2Fxena~I59ebf0fa77391d49b2349e918fc55f96318c42a6","project":"openstack/keystone","branch":"stable/xena","attention_set":{},"removed_from_attention_set":{"34980":{"account":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"last_update":"2023-05-19 16:13:30.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I59ebf0fa77391d49b2349e918fc55f96318c42a6","subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","status":"MERGED","created":"2023-02-24 07:08:18.000000000","updated":"2023-05-19 16:14:52.000000000","submitted":"2023-05-19 16:13:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"874843","cherry_pick_of_change":866723,"cherry_pick_of_patch_set":1,"meta_rev_id":"abbcc1e8d2270d7ccaae51b81a5ac7a2a1dc6069","_number":874843,"virtual_id_number":874843,"owner":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-19 16:13:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":2,"date":"2023-05-19 14:44:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":2,"date":"2023-03-20 09:59:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":1,"date":"2023-05-19 14:44:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-24 08:11:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-02-24 08:45:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-20 09:59:51.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"},{"updated":"2023-05-19 14:44:07.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"}],"messages":[{"id":"650d320db9e0f922756878358375a203c7843c1b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-24 07:08:18.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"ea0f54da96d6a4e47d5a5233ab8d82ca65dc3a97","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-24 08:11:13.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b033c1f803a947cc919e3249df46bc15\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/d773956e4f324c9da019ed409af4d3ff : SUCCESS in 12m 44s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/c6540317280145708663cc94ef172cb8 : TIMED_OUT in 1h 00m 57s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"08f005a02a11e07a76c4421c10b1ac567b287039","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-24 08:45:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5df11f948641471e8544e5945f01fc49\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a4ce9819282d403ea0f8dfc9a69259df : SUCCESS in 47m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e8206d85dddf488cbdcb5255dc320706 : SUCCESS in 5m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4ac75364d98749aaa130b1b0cb10249b : SUCCESS in 13m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/deade24b0f1341ff94c05adea58d4b6a : SUCCESS in 38m 54s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/784f75ac5f794dc399ec9113ea8fcaac : SUCCESS in 16m 19s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0b9c4cc27cb244b297dfe3ca655a8786 : SUCCESS in 13m 28s\n- grenade https://zuul.opendev.org/t/openstack/build/56dbcb4d3f74401c850c924b927595f2 : SUCCESS in 1h 01m 36s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f6cf1060256a49e0bafb3e4eef451047 : SUCCESS in 1h 25m 38s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/79bf68075c78434093b4ac1b2ca4741e : SUCCESS in 26m 51s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/2bf2d27f6ef24bf7b1f2ea1c61070db4 : SUCCESS in 51m 36s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f16ccbb32e37484dba13dd2f228b1e94 : SUCCESS in 35m 53s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/9272b2b5f4b14a688194b42fc13e3656 : SUCCESS in 43m 47s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/1467412d5aab45f98335c1e43263c59f : FAILURE in 8m 19s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/d5a9e24b61b443e7a69a09136ca2ad83 : FAILURE in 11m 02s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c65a51c9b4804e09b826cb6a900d88c5 : SUCCESS in 52m 25s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/4f452d71c8f249c2ad4154300ed03ac8 : SUCCESS in 43m 14s","accounts_in_message":[],"_revision_number":1},{"id":"341f861ff4c139e44945301fe1faa736e10f3d58","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-03-20 09:59:51.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5267935aebd6e8ac5950631ae0e88a82a56ff891","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2023-05-19 14:44:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"17f200c64046a359c31c491fa47629b8b1118efa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-19 14:44:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2231d6a14247e14ac9d30a121ecb66131c805078","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-19 16:13:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2f7bd91316c542158849fb0c16090891\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dcc963a5244b4890b2330d76071c9799 : SUCCESS in 5m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2a8bbba72f2042359684eee6df4e5a79 : SUCCESS in 12m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/884b49b17a5e4246b765925a534e48e8 : SUCCESS in 13m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/59222c474e5a435697aefa0aff20d6d7 : SUCCESS in 13m 57s\n- grenade https://zuul.opendev.org/t/openstack/build/4e24046333ea4f22ba8510314c83b56c : SUCCESS in 1h 08m 22s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8df63bf4fdf0436fac2572448617a366 : SUCCESS in 1h 24m 21s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/b13eb812b4764bed9c359d9d345368ed : SUCCESS in 23m 45s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/7676a4beb83f41c68db8c57653edf499 : SUCCESS in 25m 07s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6ba67664437148afb03986ef2a9e0d4e : SUCCESS in 41m 35s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/6c50f969f074480aae14f2ae5720837d : SUCCESS in 33m 53s","accounts_in_message":[],"_revision_number":1},{"id":"aea5f6f30f81f2875da9760df32b5b78e743a68b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-19 16:13:30.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"abbcc1e8d2270d7ccaae51b81a5ac7a2a1dc6069","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-19 16:14:52.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/338b6468b8ab482fabf909fcf2459fc7\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e29d0c07f2c48f2a4807767fd533e15 : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e5805e40e26b51ce5c4a69aa31d81226d38ccf9","revisions":{"3e5805e40e26b51ce5c4a69aa31d81226d38ccf9":{"kind":"REWORK","_number":1,"created":"2023-02-24 07:08:18.000000000","uploader":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"ref":"refs/changes/43/874843/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/43/874843/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/874843/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/874843/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/874843/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/43/874843/1"}}},"commit":{"parents":[{"commit":"3a8a6c89c69819510571181adde62b68ed812752","subject":"Merge \"Only log warnings about token length when length exceeds max_token_size\" into stable/xena","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/3a8a6c89c69819510571181adde62b68ed812752"}]}],"author":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2022-12-05 14:33:47.000000000","tz":180},"committer":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2023-02-24 07:08:18.000000000","tz":0},"subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","message":"[PooledLDAPHandler] Ensure result3() invokes message.clean()\n\nresult3 does not invoke message.clean() when an exception is thrown\nby `message.connection.result3()` call, causing pool connection\nassociated with the message to be marked active forever. This causes\na denial-of-service on ldappool.\n\nThe fix ensures message.clean() is invoked by wrapping the offending\ncall in try-except-finally and putting the message.clean() in finally\nblock.\n\nCloses-Bug: #1998789\n\nChange-Id: I59ebf0fa77391d49b2349e918fc55f96318c42a6\nSigned-off-by: Mustafa Kemal Gilor \u003cmustafa.gilor@canonical.com\u003e\n(cherry picked from commit ff632a81fb09e6d9f3298e494d53eb6df50269cf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/3e5805e40e26b51ce5c4a69aa31d81226d38ccf9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/3e5805e40e26b51ce5c4a69aa31d81226d38ccf9"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
