)]}'
{"id":"openstack%2Fkeystone~874845","triplet_id":"openstack%2Fkeystone~stable%2Ftrain~I59ebf0fa77391d49b2349e918fc55f96318c42a6","project":"openstack/keystone","branch":"stable/train","attention_set":{},"removed_from_attention_set":{"34980":{"account":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"last_update":"2023-02-24 11:28:50.000000000","reason":"\u003cGERRIT_ACCOUNT_34980\u003e replied on the change","reason_account":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"}}},"hashtags":[],"change_id":"I59ebf0fa77391d49b2349e918fc55f96318c42a6","subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","status":"ABANDONED","created":"2023-02-24 07:11:51.000000000","updated":"2023-03-13 11:50:13.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":866723,"cherry_pick_of_patch_set":1,"meta_rev_id":"1177d7c6e2f663d40f1e16e741d952cfb89087dc","_number":874845,"virtual_id_number":874845,"owner":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-02-24 09:16:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-24 09:16:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c1dd047fda11e64c7374c27f4538d426b3a25181","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-24 07:11:51.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"335913637d0db28c8648ab05c16f590071fa8a93","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-24 09:16:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/9fea6ba3b23947419c38d3508bc7bf70\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/07079ee11703489e81894efcb1aec143 : SUCCESS in 38m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ab5f8e3de5734b87884b706a280ee2ee : SUCCESS in 7m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a5f095be18734a7f89dd6c70217953d2 : FAILURE in 15m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/68752f6e90c54a07b7148bf475e00a81 : SUCCESS in 13m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9ba0d8ce8b9644deae271bbc8685519b : SUCCESS in 14m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d199ebe213464de6ae42710c1748c3b3 : SUCCESS in 11m 01s\n- tempest-full https://zuul.opendev.org/t/openstack/build/b8bcfaf343cb4691a42df6e7540a659a : SUCCESS in 1h 36m 45s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/69f57c9fd8aa46678d4bf9292c7f20f0 : SUCCESS in 1h 07m 19s\n- grenade https://zuul.opendev.org/t/openstack/build/cde03647092f496e93d60c9d420e93b5 : SUCCESS in 1h 19m 30s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4f9877f4a13e40c08cd3323d7e677392 : SUCCESS in 1h 37m 55s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/0d1f6b1ccac64dfaab3979fb8d59586b : SUCCESS in 51m 16s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/d8ca1b31144e419e8ea13edbc8b9a538 : SUCCESS in 49m 51s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/6fa33ee8b0944adb856e859db664e0b7 : FAILURE in 15m 53s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/154b0836c4554050a081ed67490bc8ee : FAILURE in 15m 37s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/5c7fdc4a17f54ae7b87bf4f31df109fd : FAILURE in 14m 55s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/b1bc0c11a43544d1a1923e9dd8ce5fcc : SUCCESS in 23m 22s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/1322fa29c978424c97302d4286b7d098 : SUCCESS in 50m 30s (non-voting)\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/cd44b421c03d417b833da9006bd81a30 : SUCCESS in 1h 18m 47s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/edc367541a2e49d1ab304092736a3ede : SUCCESS in 1h 11m 14s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/77ad4a3893b44a38a274092c99ad729c : SUCCESS in 37m 27s","accounts_in_message":[],"_revision_number":1},{"id":"2c5b06bda185eaa16b0d28c9eb73f0aba8d06693","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-24 11:28:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"558221b701833c22fca3d85bbc3118191fb8cb9e","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-03-02 08:41:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"36f8d490f76ab759cd45fdc4f6ddfde6c509cf64","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-03-02 08:41:22.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"5afcaa2a06a1df596518238fa17f7e8f0986f35b","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-03-02 10:38:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d249e012b35421df74e7ddb3c7d4c424ec8ea17c","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-03-03 10:47:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1b7e2ec903562d7ec8444d5f2c1bbea10b842b1a","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-03-13 10:18:28.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":1},{"id":"1177d7c6e2f663d40f1e16e741d952cfb89087dc","tag":"autogenerated:gerrit:abandon","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-03-13 11:50:13.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8a383cbff91b2cc39b15e50ef0361b6875d4b847","revisions":{"8a383cbff91b2cc39b15e50ef0361b6875d4b847":{"kind":"REWORK","_number":1,"created":"2023-02-24 07:11:51.000000000","uploader":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"ref":"refs/changes/45/874845/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/45/874845/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/45/874845/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/45/874845/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/45/874845/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/45/874845/1"}}},"commit":{"parents":[{"commit":"236be80331d6885fb5926d320fc670a863ac5ee6","subject":"Merge \"Fix host:port handling\" into stable/train","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/236be80331d6885fb5926d320fc670a863ac5ee6"}]}],"author":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2022-12-05 14:33:47.000000000","tz":180},"committer":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2023-02-24 07:11:51.000000000","tz":0},"subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","message":"[PooledLDAPHandler] Ensure result3() invokes message.clean()\n\nresult3 does not invoke message.clean() when an exception is thrown\nby `message.connection.result3()` call, causing pool connection\nassociated with the message to be marked active forever. This causes\na denial-of-service on ldappool.\n\nThe fix ensures message.clean() is invoked by wrapping the offending\ncall in try-except-finally and putting the message.clean() in finally\nblock.\n\nCloses-Bug: #1998789\n\nChange-Id: I59ebf0fa77391d49b2349e918fc55f96318c42a6\nSigned-off-by: Mustafa Kemal Gilor \u003cmustafa.gilor@canonical.com\u003e\n(cherry picked from commit ff632a81fb09e6d9f3298e494d53eb6df50269cf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/8a383cbff91b2cc39b15e50ef0361b6875d4b847"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/8a383cbff91b2cc39b15e50ef0361b6875d4b847"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}