)]}'
{"id":"openstack%2Fkeystone~874846","triplet_id":"openstack%2Fkeystone~stable%2Fussuri~I59ebf0fa77391d49b2349e918fc55f96318c42a6","project":"openstack/keystone","branch":"stable/ussuri","attention_set":{},"removed_from_attention_set":{"34980":{"account":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"last_update":"2023-07-13 11:43:54.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I59ebf0fa77391d49b2349e918fc55f96318c42a6","subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","status":"MERGED","created":"2023-02-24 07:12:03.000000000","updated":"2023-07-13 11:45:04.000000000","submitted":"2023-07-13 11:43:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"874846","cherry_pick_of_change":866723,"cherry_pick_of_patch_set":1,"meta_rev_id":"394f50a5b0bfe6417edce6e60bd4e5412ebf7154","_number":874846,"virtual_id_number":874846,"owner":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-07-13 11:43:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":2,"date":"2023-06-27 15:49:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":2,"date":"2023-07-13 07:46:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":1,"date":"2023-07-13 09:43:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-24 08:47:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-27 15:49:12.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"},{"updated":"2023-07-13 07:46:23.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"}],"messages":[{"id":"898de78473b2b3965ad4c51ea03e42432088ded5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-24 07:12:03.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"f47ea3b35e2d9911b8e72f672319fd451c60d362","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-24 08:47:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bbe0d198c5424ec289ebcfa1eba0233d\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/728c2dfd11db416e8eda04eeb55196b3 : SUCCESS in 12m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9b48306c84e2444c879dbcb6146e57a7 : SUCCESS in 6m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/45c9ebe5dec446ddb17c08c4114b17f8 : SUCCESS in 12m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9e753d38341f446a8da97a9533fc63fa : SUCCESS in 13m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/221b6d13cdd9479e9def993cb9c70f3b : SUCCESS in 14m 35s\n- grenade https://zuul.opendev.org/t/openstack/build/54f76eb5cdb340adaee8f206edfa0d31 : SUCCESS in 1h 21m 50s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/cda7b1977f724726beb71de405da0d99 : SUCCESS in 1h 20m 45s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/7322985ac5db4d1796d5a23535a0b433 : SUCCESS in 38m 58s\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/2013e61a859c45fa978aed347c966c97 : FAILURE in 46m 35s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/52f44ecd82a44bb7bcc5a4261a13d0cb : FAILURE in 42m 00s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/c57680106eb5467a8ce277f870fd6910 : FAILURE in 11m 08s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/86ed7fb6ba89438eb08023b2995182c8 : SUCCESS in 47m 42s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/43a4d569445c4fb1aa1451203c7d72ce : SUCCESS in 1h 01m 12s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/33ecb7ecc48b485d956f4f0add63d0a3 : SUCCESS in 38m 03s","accounts_in_message":[],"_revision_number":1},{"id":"7f2fa9e617ee70dd2ce57a6d12395575cf854251","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2023-06-27 15:49:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"26f6b2e3b62794e8468986cf156fa7bc1eafbb0a","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-07-13 07:46:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b4d96ef3a21c9995461fb2a4f59bc7ca003d89e7","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-07-13 09:43:00.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e340bb8f8ef85625966d4089da80a3673bccb006","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 09:43:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"63d89f5cab4f394208c810610b93749496e39a05","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 11:43:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6824a35b980143be8042636e37a2f569\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6469b72f421944ee9e9f7866aca47a33 : SUCCESS in 5m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fa01dfbe7ce9435c98dcc2ee3abdea19 : SUCCESS in 13m 25s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a035e358bf89453db66d4fcc54b65c20 : SUCCESS in 11m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/37f17b3692a24ce09d7c050e3ba1ee3c : SUCCESS in 12m 03s\n- grenade https://zuul.opendev.org/t/openstack/build/0e71807b475545d58dbd22b90a783ada : SUCCESS in 1h 14m 07s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/997a963c09f44cd9901904f2fd860333 : SUCCESS in 1h 50m 57s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/be9e510b70f648dfb488b53c3b8ead2b : SUCCESS in 41m 19s\n- keystone-dsvm-py3-functional-federation-opensuse15-k2k https://zuul.opendev.org/t/openstack/build/1db3568ae2f94e5dbd34211d6df191b1 : FAILURE in 41m 58s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/33e1856282154653b7aed2039bd281c0 : SUCCESS in 1h 10m 31s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/d16ca9ec7d23424dad1d2aab0c8089e8 : SUCCESS in 43m 08s","accounts_in_message":[],"_revision_number":1},{"id":"037b737fbe4223e0db99f94827e81798b455b40a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 11:43:54.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"394f50a5b0bfe6417edce6e60bd4e5412ebf7154","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 11:45:04.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/60615c148e8a4d82aea0f05ab9a8ba76\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a628894e071244b4ba8b6358f899d668 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9680ee771b3b6ed93cee712aad8a0b9e19592d56","revisions":{"9680ee771b3b6ed93cee712aad8a0b9e19592d56":{"kind":"REWORK","_number":1,"created":"2023-02-24 07:12:03.000000000","uploader":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"ref":"refs/changes/46/874846/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/46/874846/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/46/874846/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/46/874846/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/46/874846/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/46/874846/1"}}},"commit":{"parents":[{"commit":"1ab860a08e527ca9e0c82a49fbf004d415fec991","subject":"Fix host:port handling","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/1ab860a08e527ca9e0c82a49fbf004d415fec991"}]}],"author":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2022-12-05 14:33:47.000000000","tz":180},"committer":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2023-02-24 07:12:03.000000000","tz":0},"subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","message":"[PooledLDAPHandler] Ensure result3() invokes message.clean()\n\nresult3 does not invoke message.clean() when an exception is thrown\nby `message.connection.result3()` call, causing pool connection\nassociated with the message to be marked active forever. This causes\na denial-of-service on ldappool.\n\nThe fix ensures message.clean() is invoked by wrapping the offending\ncall in try-except-finally and putting the message.clean() in finally\nblock.\n\nCloses-Bug: #1998789\n\nChange-Id: I59ebf0fa77391d49b2349e918fc55f96318c42a6\nSigned-off-by: Mustafa Kemal Gilor \u003cmustafa.gilor@canonical.com\u003e\n(cherry picked from commit ff632a81fb09e6d9f3298e494d53eb6df50269cf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/9680ee771b3b6ed93cee712aad8a0b9e19592d56"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/9680ee771b3b6ed93cee712aad8a0b9e19592d56"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}