)]}'
{"id":"openstack%2Fkeystone~874847","triplet_id":"openstack%2Fkeystone~stable%2Fvictoria~I59ebf0fa77391d49b2349e918fc55f96318c42a6","project":"openstack/keystone","branch":"stable/victoria","attention_set":{},"removed_from_attention_set":{"34980":{"account":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"last_update":"2023-07-13 09:39:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I59ebf0fa77391d49b2349e918fc55f96318c42a6","subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","status":"MERGED","created":"2023-02-24 07:12:14.000000000","updated":"2023-07-13 09:40:49.000000000","submitted":"2023-07-13 09:39:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"874847","cherry_pick_of_change":866723,"cherry_pick_of_patch_set":1,"meta_rev_id":"6f3f4a3e630c8ef10509b3183055f52c3bc564cc","_number":874847,"virtual_id_number":874847,"owner":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-07-13 09:39:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-03-20 10:01:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":2,"date":"2023-06-27 15:50:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-07-13 07:46:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-24 09:02:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-20 10:01:03.000000000","updated_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"},{"updated":"2023-06-27 15:50:30.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"}],"messages":[{"id":"af4421049a40ac33ada1138ed58cc81d067879a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"date":"2023-02-24 07:12:14.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"525873c553230a24782eea859a2180a73b2c7ab9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-24 09:02:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e6f00a488aa04f5ea28f06b9ffbba72f\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2bf6560bb8134631933a9f6348f43176 : SUCCESS in 18m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ea84b7eb1b0443548f6f6b3e458ab314 : SUCCESS in 5m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/70da7acea3ca4308a15c1c3e3d7e6535 : SUCCESS in 14m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/77880084e2c84b0c9ec1a0f89ce9cb1b : SUCCESS in 17m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/44d0c2ba41f64db6b323b20a49cb1318 : SUCCESS in 14m 44s\n- grenade https://zuul.opendev.org/t/openstack/build/68219826875142ba8e1f6ca2a7578db5 : SUCCESS in 1h 01m 11s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/1654e98a027e4b4c8d97c6f1d9449bee : SUCCESS in 1h 35m 00s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/fc610bbb020147a0bcdfd2a09a4e3010 : SUCCESS in 40m 21s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal https://zuul.opendev.org/t/openstack/build/010be1ae17074d8f99e8f464ad015494 : SUCCESS in 42m 57s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/2b5fb88dbd2948419c3b3753f412d963 : SUCCESS in 38m 13s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/f3516398dd0541119005736a42f70772 : FAILURE in 10m 59s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/a94b0399a33c4f0b94b0f19f81e38a09 : FAILURE in 20m 32s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9ef3d17e5d464934ab46dd251a851ae5 : SUCCESS in 1h 03m 48s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/b4304cbc79fa4a07a72bc3855936fa6b : SUCCESS in 37m 10s","accounts_in_message":[],"_revision_number":1},{"id":"6f1225a8c1bedd1c9703eb5d533d4a196a2f1b70","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-03-20 10:01:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c3a4208f24b6b972202fa74d236d911497196750","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2023-06-27 15:50:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"46ef36ab417954cfeadeab6ca65d2540d444ee69","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2023-07-13 07:46:00.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1c2e62ee89052d6606db2bf2d186ed8ec0e8f38d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 07:46:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d2bcf3695fda70152a216e323364131269c2f52b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 09:39:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9813f4e58a964e7bafc13242e851c962\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eee7a2a61b8649019c69c2348b8e469b : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0a2fa8640d074335a8efc8b3217b2d95 : SUCCESS in 13m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/722827bf13024cf3acda98399482c3bc : SUCCESS in 15m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/64d86b4662204b3e85f0c57895c95ebf : SUCCESS in 19m 00s\n- grenade https://zuul.opendev.org/t/openstack/build/72fb2188614d42388c4cd1fce47a8e75 : SUCCESS in 1h 21m 39s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/462f9e206f764885af7fff9e2f7a6177 : SUCCESS in 1h 45m 40s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/ea714cb5db494216b88773da8392f83b : SUCCESS in 36m 53s\n- keystone-dsvm-py3-functional-federation-ubuntu-focal-k2k https://zuul.opendev.org/t/openstack/build/8aac5a30aa9041a99391dd3c2ee832e9 : SUCCESS in 30m 42s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/bb1f9959e5eb4cd18c5a0b5e604ecaff : SUCCESS in 1h 07m 23s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/0afbd2f5155448eb835df28c7400c468 : SUCCESS in 50m 56s","accounts_in_message":[],"_revision_number":1},{"id":"eb1ded8b21fc5991ad7f8d2f63840203d145b072","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 09:39:05.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"6f3f4a3e630c8ef10509b3183055f52c3bc564cc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-13 09:40:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1f12ae21912849d8a43c39dc61e13bf4\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/862adb82e10842238d521f572458ef06 : SUCCESS in 1m 25s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e865f9bc179d0b007eda6c14f1206d4f00f59748","revisions":{"e865f9bc179d0b007eda6c14f1206d4f00f59748":{"kind":"REWORK","_number":1,"created":"2023-02-24 07:12:14.000000000","uploader":{"_account_id":34980,"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","username":"mustafakemalgilor"},"ref":"refs/changes/47/874847/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/47/874847/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/874847/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/874847/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/874847/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/47/874847/1"}}},"commit":{"parents":[{"commit":"fe837d87c949f6a2347cf79d81b66214f0a449b3","subject":"Fix host:port handling","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/fe837d87c949f6a2347cf79d81b66214f0a449b3"}]}],"author":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2022-12-05 14:33:47.000000000","tz":180},"committer":{"name":"Mustafa Kemal Gilor","email":"mustafa.gilor@canonical.com","date":"2023-02-24 07:12:14.000000000","tz":0},"subject":"[PooledLDAPHandler] Ensure result3() invokes message.clean()","message":"[PooledLDAPHandler] Ensure result3() invokes message.clean()\n\nresult3 does not invoke message.clean() when an exception is thrown\nby `message.connection.result3()` call, causing pool connection\nassociated with the message to be marked active forever. This causes\na denial-of-service on ldappool.\n\nThe fix ensures message.clean() is invoked by wrapping the offending\ncall in try-except-finally and putting the message.clean() in finally\nblock.\n\nCloses-Bug: #1998789\n\nChange-Id: I59ebf0fa77391d49b2349e918fc55f96318c42a6\nSigned-off-by: Mustafa Kemal Gilor \u003cmustafa.gilor@canonical.com\u003e\n(cherry picked from commit ff632a81fb09e6d9f3298e494d53eb6df50269cf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/e865f9bc179d0b007eda6c14f1206d4f00f59748"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/e865f9bc179d0b007eda6c14f1206d4f00f59748"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}