)]}'
{"keystone/tests/unit/test_sql_upgrade.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b8aa6fa7e30ea37fd09d19d5a43176e817e6b879","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    @property"},{"line_number":265,"context_line":"    def metadata(self):"},{"line_number":266,"context_line":"        \"\"\"A collection of tables and their associated schemas.\"\"\""},{"line_number":267,"context_line":"        return sqlalchemy.MetaData(self.engine)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def load_table(self, name):"},{"line_number":270,"context_line":"        table \u003d sqlalchemy.Table("}],"source_content_type":"text/x-python","patch_set":1,"id":"885412c3_59706246","side":"PARENT","line":267,"updated":"2023-04-04 23:19:45.000000000","message":"I\u0027m just curious: how does this work?\n\nThe docs for SQLAlchemy presume that the only MetaData that exists is sqlalchemy.schema.MetaData. Okay, maybe its __init__.py has \"import schema\" somewhere or something. But the first document of MetaData.__init__() is not bind\u003d, it\u0027s schema\u003d. Some other methods take bind\u003d. Is this just an omission in docs, and sqlalchemy.MetaData() is distinct, and takes bind\u003d as its first argument?","commit_id":"802539ad41718b12cfd4dd636121d1f3b1d07ffc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5102c95e83c5e081e5f373333125dfda8fe817bc","unresolved":true,"context_lines":[{"line_number":264,"context_line":"    @property"},{"line_number":265,"context_line":"    def metadata(self):"},{"line_number":266,"context_line":"        \"\"\"A collection of tables and their associated schemas.\"\"\""},{"line_number":267,"context_line":"        return sqlalchemy.MetaData(self.engine)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def load_table(self, name):"},{"line_number":270,"context_line":"        table \u003d sqlalchemy.Table("}],"source_content_type":"text/x-python","patch_set":1,"id":"afbf79ea_44c7fa05","side":"PARENT","line":267,"in_reply_to":"885412c3_59706246","updated":"2023-04-05 17:25:59.000000000","message":"\u003e I\u0027m just curious: how does this work?\n\u003e \n\u003e The docs for SQLAlchemy presume that the only MetaData that exists is sqlalchemy.schema.MetaData. Okay, maybe its __init__.py has \"import schema\" somewhere or something.\n\nYup, that happens here https://github.com/sqlalchemy/sqlalchemy/blob/rel_2_0_8/lib/sqlalchemy/__init__.py#L75\n\n\u003e But the first document of MetaData.__init__() is not bind\u003d, it\u0027s schema\u003d.\n\nIt is. It wasn\u0027t previously though.\n\n1.4.x: https://docs.sqlalchemy.org/en/14/core/metadata.html#sqlalchemy.schema.MetaData.__init__\n2.0.x: https://docs.sqlalchemy.org/en/20/core/metadata.html#sqlalchemy.schema.MetaData.__init__\n\n\u003e Some other methods take bind\u003d. Is this just an omission in docs, and sqlalchemy.MetaData() is distinct, and takes bind\u003d as its first argument?\n\nJust a breaking change. There are a few of them about.","commit_id":"802539ad41718b12cfd4dd636121d1f3b1d07ffc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c8e80589d00b98d1494dc6a6248365be6b6bab03","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    @property"},{"line_number":265,"context_line":"    def metadata(self):"},{"line_number":266,"context_line":"        \"\"\"A collection of tables and their associated schemas.\"\"\""},{"line_number":267,"context_line":"        return sqlalchemy.MetaData(self.engine)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def load_table(self, name):"},{"line_number":270,"context_line":"        table \u003d sqlalchemy.Table("}],"source_content_type":"text/x-python","patch_set":1,"id":"e3c17eb4_67db6b09","side":"PARENT","line":267,"in_reply_to":"afbf79ea_44c7fa05","updated":"2023-04-05 17:26:43.000000000","message":"Done","commit_id":"802539ad41718b12cfd4dd636121d1f3b1d07ffc"}]}