)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"485005592741909ff287680d08cdfa54eb8d16dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c07575ed_be1ec7af","updated":"2023-11-08 19:33:45.000000000","message":"I\u0027m adding Dmitry since he raised the comment issue, so he probably wants to make sure I\u0027m doing what he had in mind here.","commit_id":"80c6ecc421fe4dcc160dfc79ec5e3882796118da"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d9133b400eb4d345d90137fe683f488c7560b355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"86bc90c3_47af3bf3","updated":"2023-11-10 13:27:22.000000000","message":"Not sure what I was commenting, but change looks good 😊","commit_id":"80c6ecc421fe4dcc160dfc79ec5e3882796118da"}],"keystone/federation/utils.py":[{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"fe0075972b362d538469cc8fb1ea52886b1631f3","unresolved":true,"context_lines":[{"line_number":566,"context_line":"    def _ast_literal_eval(value):"},{"line_number":567,"context_line":"        try:"},{"line_number":568,"context_line":"            values \u003d ast.literal_eval(value)"},{"line_number":569,"context_line":"            # The literal_eval returns a singleton if there was only one value."},{"line_number":570,"context_line":"            if not isinstance(values, list):"},{"line_number":571,"context_line":"                raise ValueError"},{"line_number":572,"context_line":"        except (ValueError, SyntaxError):"}],"source_content_type":"text/x-python","patch_set":3,"id":"92e01955_4a8e7e8d","line":569,"updated":"2023-05-08 11:16:53.000000000","message":"This comment still confuses me, singelton is used in another context and I had trouble to understand what it meant until I re-evaluated what the old comment said and what the original change was.\n\nMaybe change this to something like:\n\nWe expect a list here, however literal_eval will successfully parse and return a single value, so we raise a ValueError in that case.","commit_id":"cc22c19028689e202e4b01491db50a17de6791bd"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ef4d76e770c56867f4f9afc9fed9a555d8ab4477","unresolved":false,"context_lines":[{"line_number":566,"context_line":"    def _ast_literal_eval(value):"},{"line_number":567,"context_line":"        try:"},{"line_number":568,"context_line":"            values \u003d ast.literal_eval(value)"},{"line_number":569,"context_line":"            # The literal_eval returns a singleton if there was only one value."},{"line_number":570,"context_line":"            if not isinstance(values, list):"},{"line_number":571,"context_line":"                raise ValueError"},{"line_number":572,"context_line":"        except (ValueError, SyntaxError):"}],"source_content_type":"text/x-python","patch_set":3,"id":"68fff8e5_7a27013e","line":569,"in_reply_to":"92e01955_4a8e7e8d","updated":"2023-10-12 14:18:38.000000000","message":"Done","commit_id":"cc22c19028689e202e4b01491db50a17de6791bd"}]}
